is
c7086b4a237520d2bbe5146d8b1ace1894c2b2bf.
Pulled, thanks.
In the future, please send a v2 when this happens. My scripts scan the
pull request message and find the up to X. It then determines
whether the merge has been processed by searching for a commit with a
head of X.
Regards,
Anthony
, it doesn't matter
in practice for this patch. I'll get off my soapbox now :-)
Regards,
Anthony Liguori
V5:
- Addresses comments from Andreas Färber
V4:
- Renamed from 'Citrix PV Bus' to 'Xen PV Device'
- Paramaterized vendor-id and device-id as requested by Stefano Stabellini
V3
-by: Paul Durrant paul.durr...@citrix.com
Cc: Stefano Stabellini stefano.stabell...@citrix.com
Reviewed-by: Andreas Färber afaer...@suse.de
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
V5:
- Addresses comments from Andreas Färber
V4:
- Renamed from 'Citrix PV
Peter Maydell peter.mayd...@linaro.org writes:
On 8 July 2013 15:04, Anthony Liguori anth...@codemonkey.ws wrote:
(Just a nit and responding because this happens commonly).
You probably mean Reviewed-by. Acked-by really means, I am not the
maintainer of this area, I have not reviewed
Andreas Färber afaer...@suse.de writes:
Am 08.07.2013 16:10, schrieb Peter Maydell:
On 8 July 2013 15:04, Anthony Liguori anth...@codemonkey.ws wrote:
(Just a nit and responding because this happens commonly).
You probably mean Reviewed-by. Acked-by really means, I am not the
maintainer
Stefano Stabellini stefano.stabell...@eu.citrix.com writes:
On Mon, 8 Jul 2013, Anthony Liguori wrote:
Andreas Färber afaer...@suse.de writes:
Right, it goes:
1) Acked-by:
I haven't reviewed the code in detail but the general idea seems sane.
2) Reviewed-by:
The general idea
be at least three if not four distinct patch series.
Sending it as a single series means it cannot be applied in chunks easily.
Regards,
Anthony Liguori
Alexey Kardashevskiy (4):
pseries: move interrupt controllers to hw/intc/
pseries: rework XICS
pseries: rework PAPR virtual SCSI
spapr-pci
Alexey Kardashevskiy a...@ozlabs.ru writes:
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
default-configs/ppc64-softmmu.mak |1 +
hw/intc/Makefile.objs |1 +
hw/{ppc = intc}/xics.c
-kvm
is kind of help.
The way this should be modelled is:
XICSCommon
- XICS
- XICSKVM
With vmstate et al being part of XICSCommon. See how the i8259 and
i8254 are modelled.
Regards,
Anthony Liguori
Won't that
prevent migrating from a system with a kernel xics to one without, or
vice
isn't directly
accessible as a structure field, but an element count from which the size
can be derived is.
Why? What's the point of sending the total size vs. the element count?
It's not like we have legacy that we have to support here...
Regards,
Anthony Liguori
This patch adds
to do this because you haven't converted everything to QOM yet.
Please do that to avoid these hacks.
Regards,
Anthony Liguori
}
void xics_common_init(struct icp_state *icp, qemu_irq_handler handler)
@@ -555,6 +614,10 @@ static void xics_realize(DeviceState *dev, Error **errp
more QOM conversion.
Regards,
Anthony Liguori
return tcet;
}
@@ -163,6 +184,10 @@ void spapr_tce_free(sPAPRTCETable *tcet)
{
QLIST_REMOVE(tcet, list);
+vmstate_unregister(NULL, vmstate_spapr_tce_table, tcet);
+
+QLIST_REMOVE(tcet, list
-by: Alexey Kardashevskiy a...@ozlabs.ru
---
hw/char/spapr_vty.c | 16
Please split this out. But then you can add:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
hw/net/spapr_llan.c | 24 ++--
2 files changed, 38
+#include hw/ppc/xics.h
+#include kvm_ppc.h
+#include qemu/config-file.h
+
+#include sys/ioctl.h
+
+struct icp_state_kvm {
CodingStyle
Regards,
Anthony Liguori
+struct icp_state parent;
+
+uint32_t set_xive_token;
+uint32_t get_xive_token;
+uint32_t int_off_token
= vmstate_tlbmas,
+.needed = tlbmas_needed,
+} , {
+/* FIXME: DCRs? */
+/* FIXME: timebase? */
+/* empty */
Are they needed or not needed?
If they're needed, please add them.
Regards,
Anthony Liguori
+}
+}
+};
diff
,
Anthony Liguori
+assert(req-cur_desc_num == 0);
+dprintf(VSCSI: direct segment);
+break;
+}
+case SRP_DATA_DESC_INDIRECT: {
+struct srp_indirect_buf *tmp = (struct srp_indirect_buf *)
+ (cmd-add_data + req
Alexander Graf ag...@suse.de writes:
On 08.07.2013, at 20:45, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
This adds the necessary pieces to implement savevm / migration for the
pseries machine. The most complex part
a...@ozlabs.ru
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
hw/ppc/spapr_vio.c | 20
include/hw/ppc/spapr_vio.h |5 +
2 files changed, 25 insertions(+)
diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c
index 9c18741
vmstate_icp_server;
+extern const VMStateDescription vmstate_ics;
This is the wrong way of doing whatever you're trying to do.
Regards,
Anthony Liguori
+
#endif /* __XICS_H__ */
--
1.7.10.4
mcfg_base;
+const unsigned char *dsdt_code;
+unsigned dsdt_size;
+uint16_t pvpanic_port;
This is all stuff that should be obtained via QOM.
Doing it this way just makes it all that much harder to detangle the
PC initialization mess we already have.
Regards,
Anthony Liguori
-pci_info.w32.end - 1);
I don't think you're guaranteed natural alignment here so you need to
use memcpys.
Regards,
Anthony Liguori
+
+if (guest_info-pci_info.w64.end guest_info-pci_info.w64.begin) {
+ssdt_ptr[acpi_pci64_valid[0]] = 1;
+*(uint64_t*)ssdt_ptr[acpi_pci64_start[0
Kardashevskiy a...@ozlabs.ru
I vaguely recall making the suggestion to use a live section like this.
How large is the HTAB typically?
Regards,
Anthony Liguori
---
hw/ppc/spapr.c | 269
+++-
hw/ppc/spapr_hcall.c |8 +-
include/hw/ppc/spapr.h
a...@ozlabs.ru
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
hw/ppc/spapr_pci.c | 49
+++
include/hw/pci-host/spapr.h |6 +++---
2 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/hw/ppc
don't break command line compatibility
in QEMU. So this patch needs to change.
Regards,
Anthony Liguori
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
of math on it. I doubt it's exploitable since it's
always treated as a PA, but better to be safe than sorry.
Regards,
Anthony Liguori
+}
+
int virtio_queue_get_num(VirtIODevice *vdev, int n)
{
return vdev-vq[n].vring.num;
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio
if there's no backend
* made transport size 0x200, in line with kvmtool
* set has_variable_vring_alignment
]
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
hw/virtio/Makefile.objs |1 +
hw/virtio/virtio-mmio.c | 424
virtio-mmio-bus which would be a single
set of system resources that implemented a virtio bus on top of it.
Regards,
Anthony Liguori
-- PMM
Alexander Graf ag...@suse.de writes:
On 08.07.2013, at 22:08, Anthony Liguori wrote:
I think we're trying to fit a square peg into a round hole.
virtio-mmio is a virtio transport where each device has a dedicated set
of system resources.
Alex, it sounds like you want virtio-mmio-bus
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
On Mon, 2013-07-08 at 13:39 -0500, Anthony Liguori wrote:
+.fields = (VMStateField []) {
+/* Sanity check */
+VMSTATE_UINT32_EQUAL(liobn, sPAPRTCETable),
+VMSTATE_UINT32_EQUAL(window_size
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
On Mon, 2013-07-08 at 13:45 -0500, Anthony Liguori wrote:
I vaguely recall making the suggestion to use a live section like
this. How large is the HTAB typically?
Depends on how much RAM you put in your VM. The default is around 16M
and the non-KVM version. As long as the subclasses don't introduce
any new state members, you can safely migrate between the two devices.
You should consider splitting the implementations up into separate
files just like i8259 too.
Regards,
Anthony Liguori
Regards,
Anthony Liguori
}
void
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/09/2013 10:49 AM, Anthony Liguori wrote:
On Mon, Jul 8, 2013 at 7:06 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
You should tie the vmstate section to DeviceState::vmsd. You only need
to do this because you haven't converted everything
integer without a cast [-Werror]
cc1: all warnings being treated as errors
make[1]: *** [hw/i386/pc_piix.o] Error 1
make: *** [subdir-i386-softmmu] Error 2
Regards,
Anthony Liguori
Andrew Jones (1):
e1000: cleanup
Paolo Bonzini pbonz...@redhat.com writes:
Il 02/07/2013 22:58, Anthony Liguori ha scritto:
We consume the schema in QEMU. No reason for us to consume it in a
different format than libvirt.
One reason could be that qapi-schema.json, as written, lacks a schema
that can be expressed
out that it's a Cirrus VGA
card emulated by QEMU (not real hardware). In fact, I believe the
kernel KMS driver for Cirrus only binds to the QEMU vendor/device ID
since that's the only thing reasonably testable these days.
Regards,
Anthony Liguori
Kevin Wolf kw...@redhat.com writes:
Am 02.07.2013 um 19:06 hat Anthony Liguori geschrieben:
Eric Blake ebl...@redhat.com writes:
On 07/02/2013 08:51 AM, Anthony Liguori wrote:
Amos Kong ak...@redhat.com writes:
Introduces new monitor command to query QMP schema information
Paolo Bonzini pbonz...@redhat.com writes:
Il 03/07/2013 14:54, Anthony Liguori ha scritto:
So, qapi-schema.json has to be readable/writable _mostly_ by humans.
That it is valid JSON is little more than a curious accident, because
I can assure you that it wasn't an accident.
Sure
support for VTY.
Regards,
Anthony Liguori
On 06/27/2013 04:45 PM, Alexey Kardashevskiy wrote:
This series spent quite a lot of time waiting when David's PCI series
reaches the upstream but it does not seem to happen soon so I rebased
those on top of agraf/ppc-next rebased on top qemu.org
at a
PAGE_SIZE=4096 or something like that.
Even hard coding 4096 here in QEMU would be better than using
TARGET_PAGE_SIZE.
Regards,
Anthony Liguori
+
+pci_register_bar(pci_dev, 1, PCI_BASE_ADDRESS_MEM_PREFETCH,
+ d-mmio);
+
+return 0;
+}
+
+static Property
introduce something akin to kref now that referencing counting
has gotten fancy?
Regards,
Anthony Liguori
--
1.7.3.4
...@redhat.com
Maybe I'm being too meta here, but why not just return qapi-schema.json
as a string and call it as day?
It's JSON already and since QMP is JSON, the client already has a JSON
parser. Adding another level of complexity doesn't add much value IMHO.
It's pretty simple too.
Regards,
Anthony
setting an arbitrary timeout is a bad idea.
Should we send a signal on cancel to break the migration thread out of
sendmsg?
Regards,
Anthony Liguori
---
include/migration/migration.h |4
migration-tcp.c | 23 ++-
2 files changed, 26 insertions(+), 1
Paolo Bonzini pbonz...@redhat.com writes:
Il 02/07/2013 16:47, Anthony Liguori ha scritto:
Jan Kiszka jan.kis...@siemens.com writes:
Objects can soon be referenced/dereference outside the BQL. So we need
to use atomics in object_ref/unref.
Based on patch by Liu Ping Fan.
Signed-off
Eric Blake ebl...@redhat.com writes:
On 07/02/2013 08:51 AM, Anthony Liguori wrote:
Amos Kong ak...@redhat.com writes:
Introduces new monitor command to query QMP schema information,
the return data is a nested dict/list, it contains the useful
metadata.
we can add events definations
.
Regards,
Anthony Liguori
I'm finding it hard to clearly see what the 2 different proposed
data formats look like against each other. Can someone give some
examples, showing the data that would need to be parsed in each
format, for a couple of examples.
My proposal (but not quite what
could simply post process it.
Heck, if you use json_parser to parse the file, you'd end up with a list
of QObjects that could be returned directly via QMP.
I don't understand what all this talk of post-processing is.
Regards,
Anthony Liguori
--
Eric Blake eblake redhat com+1-919-301-3266
Eric Blake ebl...@redhat.com writes:
On 07/02/2013 11:06 AM, Anthony Liguori wrote:
Because qapi-schema.json requires further parsing. For example, how is
a client supposed to know that '*foo':'int' means that there is an
argument named 'foo' but it is optional? The rule of thumb with QMP
this problem
of everyone introducing their own variants of pv drivers.
Regards,
Anthony Liguori
If not, would you be OK with a PCI device with the Xen vendor ID but a
configurable device ID?
Richard Henderson r...@twiddle.net writes:
Ping.
Peter, could you take a look and bring in through the arm tree?
Regards,
Anthony Liguori
On 06/26/2013 01:52 PM, Richard Henderson wrote:
This patch set includes both the remainder series and arm runtime
detection series that I've
Peter Maydell peter.mayd...@linaro.org writes:
On 2 July 2013 20:17, Anthony Liguori aligu...@us.ibm.com wrote:
Richard Henderson r...@twiddle.net writes:
Ping.
Peter, could you take a look and bring in through the arm tree?
I can test it and put together a pullrequest, sure, though
tcg
Paolo Bonzini pbonz...@redhat.com writes:
Il 02/07/2013 20:21, Anthony Liguori ha scritto:
Indeed, I wouldn't mind a one-time pass over qapi-schema.json to make it
follow a more rigid format if that made it easier to use it as-is with
less post-processing. It won't be very nice
a particular reason. Most likely an evolutionary
artifact.
Regards,
Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes:
Il 28/06/2013 22:41, Anthony Liguori ha scritto:
Tiny copy/paste error here: s/qemu memory/memory/g.
One thing I've been thinking about reviewing this code, what should we
be doing in virtio.c?
We have barriers but we're relying on st[u][wlb
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes:
Il 01/07/2013 15:00, Anthony Liguori ha scritto:
I
cannot find the commit exactly, but I think mst added specific code for
that.
Right, I'm not questioning whether these functions have strong enough
semantics in their implementation, but asking
On Sun, Jun 30, 2013 at 2:37 AM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 06/30/2013 12:28 AM, Anthony Liguori wrote:
Ah. Everybody ignored, I'll try asking again :)
kvm_irqchip_update_msi_route() - where should it go? What is it for?
virtio-pci and pci device assignment use it but vfio
On Sat, Jun 29, 2013 at 7:59 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 06/30/2013 12:28 AM, Anthony Liguori wrote:
Perhaps (2) can just be the default PCI bus implementation to simplify
things.
hw/pci/pci.c does not have any kvm code yet and I would like not to be the
first person
-intx_routing_notifier = notifier;
}
+void pci_bus_set_map_msi_fn(PCIBus *bus, pci_map_msi_fn map_msi_fn)
+{
+bus-map_msi = map_msi_fn;
+}
You don't need this function. You can do this overloading as part of
the PCI bus initialization in spapr_pci.c
Regards,
Anthony Liguori
+int pci_bus_map_msi
suspect Michael did git-format-patch to a
directory, deleted one of the files, and never bothered changing the N
of M.
Regards,
Anthony Liguori
is corrupted. Please send with git-send-email.
Regards,
Anthony Liguori
Signed-off-by: MRatnikov m.o.ratni...@gmail.com
---
Previous realization doesn't consider flags in the status register.
Add DS and INTR bits of HST_STS register set after transaction execution.
Update bits resetting
Paolo Bonzini pbonz...@redhat.com writes:
This is the first step towards converting as-current_map to
RCU-style updates, where the FlatView updates run concurrently
with uses of an old FlatView.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Anthony Liguori aligu
removing address spaces which
isn't that crazy of an idea I think.
Regards,
Anthony Liguori
memory_region_transaction_begin();
as-root = root;
as-current_map = g_new(FlatView, 1);
@@ -1652,9 +1712,8 @@ void address_space_destroy(AddressSpace
that variable.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
memory.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/memory.c b/memory.c
index 688c817..1f44cd1
diligent approach here should we introduce atomic variants that work on
guest phys addresses?
Otherwise:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
+ */
#define smp_wmb() barrier()
#define smp_rmb() barrier()
-#define smp_mb() asm volatile(mfence
Paolo Bonzini pbonz...@redhat.com writes:
The next patch will change qemu/tls.h to support more platforms, but at
some performance cost. Declare cpu_single_env directly instead of using
the tls.h abstractions.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Anthony Liguori
interfaces and the VESA BIOS
will use PCI bar mapping.
You could also trap accesses to where the BAR gets mapped on the PCI
device. Far better to just register a DisplayChangeListener though and
let QEMU do the heavy lifting.
Or use VNC as Richard mentioned elsewhere.
Regards,
Anthony Liguori
).
thanks
-- PMM
Thanks for you answer. I will wait his response.
Please resubmit as a top level patch rebased against latest git HEAD.
Regards,
Anthony Liguori
...@eu.citrix.com
Is the guest setting this or a management tool? I thought we were
moving to having the Xen management tools use QMP and the command line
instead of putting this stuff in XenStore...
Regards,
Anthony Liguori
diff --git a/hw/xen_disk.c b/hw/xen_disk.c
index f484404..092aa6b 100644
--- a/hw
Stefano Stabellini stefano.stabell...@eu.citrix.com writes:
On Wed, 26 Jun 2013, Anthony Liguori wrote:
Stefano Stabellini stefano.stabell...@eu.citrix.com writes:
Support a backend option cache that specifies the cache mode that
should be used to open the disk file or device.
See
just call fdt_build_generic_table() and then
customize from there, that's fine by me.
Regards,
Anthony Liguori
Note that spapr already contains a half-arsed implementation of this.
--
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au
arm-devs.for-upstream
No need to resubmit, but you'll want to use the tag name instead of the
branch name here in the future.
Regards,
Anthony Liguori
for you to fetch changes up to 7426aa72c36c908a7d0eae3e38568bb0a70de479:
nand: Don't inherit from Sysbus (2013-06-25 19:15:46 +0100
Peter Maydell peter.mayd...@linaro.org writes:
On 25 June 2013 20:07, Anthony Liguori aligu...@us.ibm.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
arm-devs pullreq; nothing particularly earthshattering.
As with the target-arm pullreq, I'm trying to create a signed
pullreq here
tip and resubmit.
Regards,
Anthony Liguori
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony
for you to fetch changes up to 55cb9714d8a54f2dd82fc9fd7091762408bda531:
pci: Fold host_buses list into PCIHostState functionality (2013
Kevin Wolf kw...@redhat.com writes:
Am 23.06.2013 um 23:39 hat Anthony Liguori geschrieben:
Kevin Wolf m...@kevin-wolf.de writes:
Kevin Wolf (3):
multiboot: Don't forget last mmap entry
multiboot: Calculate upper_mem in the ROM
multiboot: Updated ROM binary
Reviewed
Alex Williamson alex.william...@redhat.com writes:
On Sun, 2013-06-23 at 16:58 -0500, Anthony Liguori wrote:
Yeah, but none of this is Power specific... so we can do the same for x86,
no?
I'm still trying to wrap my head around why we need MSI knowledge at
all in the kernel for x86. I
Alex Williamson alex.william...@redhat.com writes:
On Sun, 2013-06-23 at 10:06 -0500, Anthony Liguori wrote:
On Thu, Jun 20, 2013 at 11:46 PM, Alex Williamson
alex.william...@redhat.com wrote:
On Fri, 2013-06-21 at 12:49 +1000, Alexey Kardashevskiy wrote:
On 06/21/2013 12:34 PM, Alex
Gleb Natapov g...@redhat.com writes:
On Sun, Jun 23, 2013 at 10:06:05AM -0500, Anthony Liguori wrote:
On Thu, Jun 20, 2013 at 11:46 PM, Alex Williamson
alex.william...@redhat.com wrote:
On Fri, 2013-06-21 at 12:49 +1000, Alexey Kardashevskiy wrote:
On 06/21/2013 12:34 PM, Alex Williamson
Gleb Natapov g...@redhat.com writes:
On Mon, Jun 24, 2013 at 07:32:32AM -0500, Anthony Liguori wrote:
Gleb Natapov g...@redhat.com writes:
This should be a per-device mapping, yes. But I'm not sure that VCPUs
should even see anything. I don't think a VCPU can generate an MSI
interrupt
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Jun 24, 2013 at 08:34:52AM -0500, Anthony Liguori wrote:
Gleb Natapov g...@redhat.com writes:
Isn't this more or less what Avi's previous proposal was around changing
the APIC interfaces to userspace?
Regards,
Anthony Liguori
While
will appreciate
erring on the side of being conservative.
Regards,
Anthony Liguori
- Michael
Reviewed-by: Chegu Vinod chegu_vi...@hp.com
Reviewed-by: Eric Blake ebl...@redhat.com
Tested-by: Chegu Vinod chegu_vi...@hp.com
Tested-by: Michael R. Hines mrhi...@us.ibm.com
Signed-off
Alexander Graf ag...@suse.de writes:
On 24.06.2013, at 16:31, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Mon, Jun 24, 2013 at 08:34:52AM -0500, Anthony Liguori wrote:
Gleb Natapov g...@redhat.com writes:
Isn't this more or less what Avi's previous proposal
+-
178 files changed, 23181 insertions(+), 2192 deletions(-)
There is no humanly way 23k LOC can be reviewed in a single series.
Has this been maintained out of tree for some time? Is it largely
copy/paste from linux-user?
Regards,
Anthony Liguori
create mode 100644 bsd-user/arm/syscall.h
Stacey Son s...@freebsd.org writes:
On Jun 24, 2013, at 12:55 PM, Anthony Liguori wrote:
There is no humanly way 23k LOC can be reviewed in a single series.
Yes, indeed, it is a lot of code.
Has this been maintained out of tree for some time?
Yes, it has been a large, ugly patch set
though the VM has freezed.
The qmp balloon commands interface with the virtual hardware. Whether
the guest is frozen or not does not prevent you from altering the
registers in the virtual hardware.
Regards,
Anthony Liguori
Regards
Power was designed to not require
MMIO trapping. It's much like Xen PV in that regard.
It doesn't make a lot of sense to have Power do MSI decoding in
userspace while x86 does it in the kernel. I assume the kernel
doesn't have enough information to do the translation on Power?
Regards,
Anthony
by some means other
than a MSI write?
This is exactly the same thing that happens on x86, no? Can you point
me to something in the SDM that says otherwise?
Regards,
Anthony Liguori
So to correctly model the hardware, vfio should do a
msi_notify() that does a stl_le_phys that terminates
Kevin Wolf m...@kevin-wolf.de writes:
Kevin Wolf (3):
multiboot: Don't forget last mmap entry
multiboot: Calculate upper_mem in the ROM
multiboot: Updated ROM binary
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Do you have a test case that triggered this that you can share?
I'll
On Sun, Jun 23, 2013 at 4:39 PM, Benjamin Herrenschmidt
b...@kernel.crashing.org wrote:
On Sun, 2013-06-23 at 10:02 -0500, Anthony Liguori wrote:
It doesn't make a lot of sense to have Power do MSI decoding in
userspace while x86 does it in the kernel. I assume the kernel
doesn't have enough
. Here we are emulating pHyp which
is not real hardware and never pretended to be. Our guests do not touch MSI
records in the config space and use RTAS MSI calls instead.
But RTAS is implemented as guest code. I suspect it's doing region
access to generate the actual MSI events.
Regards,
Anthony
Michael S. Tsirkin m...@redhat.com writes:
From: Michael S. Tsirkin m...@redhat.com
The following changes since commit 90a2541b763b31d2b551b07e24aae3de5266d31b:
target-i386: fix over 80 chars warnings (2013-06-15 17:50:38 +)
are available in the git repository at:
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
-18-x86_64-Live-Desktop.iso (raw,
read-only)
Removable device: not locked, tray closed
floppy0: [not inserted]
Removable device: not locked, tray closed
sd0: [not inserted]
Removable device: not locked, tray closed
Acked-by: Anthony Liguori aligu
401 - 500 of 9887 matches
Mail list logo
