Applied. Thanks.
Regards,
Anthony Liguori
Sage Weil s...@inktank.com writes:
Hi Anthony, Stefan, Paolo,
[Resurrecting an old thread, here!]
On Wed, 10 Apr 2013 Anthony Liguori wrote:
Has any progress been made toward a generic dynamic linking solution for
block drivers? It is a conceptually simple change, but non-trivial
understand why two devices are required here and the thread
doesn't really answer that either. Is there a spec for the Xen platform
devices? Take a look at docs/specs for some examples in the tree.
It certainly helps to have one for discussions like this.
Regards,
Anthony Liguori
Otherwise rebuilds can fail when libqos is modified.
Reported-by: Markus Armbruster arm...@redhat.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile b/tests/Makefile
index 9a3007d..0042cf4 100644
Andreas Färber afaer...@suse.de writes:
Am 19.06.2013 22:40, schrieb Anthony Liguori:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qtest.c | 29 +
tests/libqtest.c | 18 ++
tests/libqtest.h | 46
Andreas Färber afaer...@suse.de writes:
Am 19.06.2013 22:40, schrieb Anthony Liguori:
RTAS is a hypervisor provided binary blob that a guest loads and
calls into to execute certain functions. It's similar to the
vsyscall page in Linux or the short lived VMCI paravirt interface
from VMware
);
+if (vector-virq 0) {
+vector-virq = kvm_irqchip_add_msi_route(kvm_state, msg);
+}
I don't understand why you're adding a pci level hook verses just having
a kvmppc specific hook in the kvm_irqchip_add_msi_route function..
Regards,
Anthony Liguori
if (vector-virq 0
Andreas Färber afaer...@suse.de writes:
Am 19.06.2013 22:40, schrieb Anthony Liguori:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/libqtest.c | 16 +---
tests/libqtest.h | 14 +++---
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/tests
Alexander Graf ag...@suse.de writes:
Am 20.06.2013 um 17:42 schrieb Anthony Liguori aligu...@us.ibm.com:
Andreas Färber afaer...@suse.de writes:
Am 19.06.2013 22:40, schrieb Anthony Liguori:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qtest.c | 29
that tree still exist?
Would that be coming from Paolo or Gleb? Can one of ya'll ack these
changes please.
Regards,
Anthony Liguori
pvpanic: initialization cleanup
pvpanic: fix fwcfg for big endian hosts
MAINTAINERS | 2 +-
QMP/qmp-events.txt
Gleb Natapov g...@redhat.com writes:
On Thu, Jun 20, 2013 at 02:02:59PM -0500, Anthony Liguori wrote:
Michael S. Tsirkin m...@redhat.com writes:
From: Michael S. Tsirkin m...@redhat.com
The following changes since commit
90a2541b763b31d2b551b07e24aae3de5266d31b:
target-i386
Markus Armbruster arm...@redhat.com writes:
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
tests/libqtest.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/libqtest.c b/tests/libqtest.c
Markus Armbruster arm...@redhat.com writes:
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
tests/libqtest.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/libqtest.c b/tests/libqtest.c
Michael Tokarev m...@tls.msk.ru writes:
Signed-off-by: Michael Tokarev m...@tls.msk.ru
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
vl.c | 122
+-
1 file changed, 69 insertions(+), 53
Hi,
This series introduces qtest support for spapr and adds a test case
for spapr-vty. It then significantly refactors spapr-vty fixing among
other things a number of guest driven aborts due to improper use of
QOM cast macros.
A neat trick included in this series is a save_restore() qtest
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/libqtest.c | 16 +---
tests/libqtest.h | 14 +++---
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 81107cf..235ec62 100644
--- a/tests/libqtest.c
+++ b/tests
It is very useful to use the ringbuf chardev for writing test
cases and even more useful if the state of the ringbuf is migrated
with the guest. Otherwise it's hard to detect data loss in a test
case.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qapi-schema.json | 3 ++-
qemu-char.c
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c| 36 ++--
hw/ppc/spapr_rtas.c| 18 ++
include/hw/ppc/spapr_vio.h | 2 --
3 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/hw/char/spapr_vty.c
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index 2993848..ecc2bb5 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -1,3 +1,16 @@
+/*
+ * QEMU
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index aa56f10..6834fe2 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -65,7 +65,13
handling so we can more easily
invoke hypercalls just as guest code would.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/nvram/spapr_nvram.c | 4 ++--
hw/ppc/spapr_events.c | 2 +-
hw/ppc/spapr_hcall.c | 2 +-
hw/ppc/spapr_pci.c | 13 +++--
hw/ppc/spapr_rtas.c| 21
A few small changes folded into one cleanup:
- Fail gracefully when passed a reg of the wrong device type
- Don't cast uint8_t buf to uint64_t for argument marshalling
- Use spapr_vty prefix consistently.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c | 57
Today if an invalid hcall is made to an otherwise valid device we
abort due to QOM casting. This adds a parameter to find_by_reg()
to indicate which type of device we're looking for.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c| 14 --
hw/net
Pretty basic for the moment but the interface is pretty simple.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 3 ++
tests/spapr-vty-test.c | 89 ++
2 files changed, 92 insertions(+)
create mode 100644 tests/spapr
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qtest.c | 29 +
tests/libqtest.c | 18 ++
tests/libqtest.h | 46 ++
3 files changed, 93 insertions(+)
diff --git a/qtest.c b/qtest.c
index
about how devices are decoded.
This does not produce a change in behavior since reg=0 hcalls to
non-VTY devices will still fail as gloriously as they did before
just for a different reason (invalid device instead of invalid reg).
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char
and restoring state.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/libqtest.c | 65
tests/libqtest.h | 46 +++
2 files changed, 111 insertions(+)
diff --git a/tests/libqtest.c b/tests
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 22:40, Anthony Liguori wrote:
Pretty basic for the moment but the interface is pretty simple.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 3 ++
tests/spapr-vty-test.c | 89
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 22:40, Anthony Liguori wrote:
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/char/spapr_vty.c| 36 ++--
hw/ppc/spapr_rtas.c| 18 ++
include/hw/ppc/spapr_vio.h
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 22:40, Anthony Liguori wrote:
The creatively named reg field is a hypervisor assigned global
identifier for a virtual device. Despite the fact that no device
is assigned a reg of 0, guests still use it to refer to early
console
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 22:40, Anthony Liguori wrote:
Today if an invalid hcall is made to an otherwise valid device we
abort due to QOM casting. This adds a parameter to find_by_reg()
to indicate which type of device we're looking for.
This should also
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 23:49, Anthony Liguori wrote:
Alexander Graf ag...@suse.de writes:
On 19.06.2013, at 22:40, Anthony Liguori wrote:
The creatively named reg field is a hypervisor assigned global
identifier for a virtual device. Despite the fact
,
Anthony Liguori
o adding more types of modules, for example a new DISPLAY
type.
Below is a sample implementation of the loading part (without
configure checks, just POC).
Thanks,
/mjt
--- a/util/module.c
+++ b/util/module.c
@@ -17,6 +17,62 @@
#include qemu/queue.h
#include
Markus Armbruster arm...@redhat.com writes:
Anthony Liguori aligu...@us.ibm.com writes:
Markus Armbruster arm...@redhat.com writes:
Signed-off-by: Markus Armbruster arm...@redhat.com
---
tests/Makefile | 2 ++
tests/boot-order-test.c | 68
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com
Ping, looking to pull this in for 1.5.1
Anthony, Juan? Not sure if this is on your radar. Looking to get it
applied prior to stable freeze tomorrow.
I'll pick it up.
Regards,
Anthony Liguori
---
v2:
* Fixed s/except/accept/ typo
Little more context please.
Regards,
Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes:
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
include/ui/console.h |2 ++
ui/console.c | 15 +++
2 files changed, 17 insertions(+)
diff --git a/include/ui
(including whether they are cancelable), canceling cancelable jobs, and
then a single event notifying completion of jobs, would solve a lot of
problems in the current interface.
Regards,
Anthony Liguori
+static void qmp_screendump_bh(void *opaque)
+{
+Error *local_err;
+struct
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
it was important to get these on the
list even though they are old.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
);
+void ram_madvise_free(ram_addr_t size);
+
If you introduce new interfaces, please include documentation in the
header.
Regards,
Anthony Liguori
extern SaveVMHandlers savevm_ram_handlers;
uint64_t dup_mig_bytes_transferred(void);
--
1.7.7.6
'} }
I suspect we should just do this as a flag to the existing migration
command. Perhaps we could even just use a capability.
Regards,
Anthony Liguori
+
+##
# @MouseInfo:
#
# Information about a mouse device.
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 8cea5e5..bf6d042 100644
problem.
It would also be handy to flip large pages when THP is active but that's
future work.
Regards,
Anthony Liguori
|
V
Migration completes
As stopping VM first, we expect/resume the page flipping through vmspice
is fast enough to meet *live
);
+int qemu_save_device_state(QEMUFile *f);
int qemu_loadvm_state(QEMUFile *f);
Please add comments describing what this function does. I know they're
absent for the rest of the functions but we have to start somewhere.
Regards,
Anthony Liguori
/* SLIRP */
diff --git a/savevm.c b/savevm.c
,
+MIG_STATE_ACTIVE,
+MIG_STATE_COMPLETED,
+};
+
If these flags are being exported, it would be nice to provide comments
describing what each state corresponded to.
Regards,
Anthony Liguori
struct MigrationParams {
bool blk;
bool shared;
diff --git a/migration.c b/migration.c
index
Markus Armbruster arm...@redhat.com writes:
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
include/qemu/option.h | 2 --
util/qemu-option.c| 30 --
2 files changed, 32
Markus Armbruster arm...@redhat.com writes:
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
include/hw/hw.h | 4 ++--
vl.c| 16
2 files changed, 10 insertions(+), 10 deletions
option parsing is complete, and the machine is known. This is how the
other -boot options work already.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
vl.c | 59
-legacy syntax
got simply ignored.
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
vl.c | 84
++--
1 file changed, 22 insertions(+), 62
. Make it stick instead: set the bit according to
-no-fd-bootchk in pc_boot_set().
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
hw/i386/pc.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff
-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
qemu-options.hx | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index bf94862..8355f9b 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -1268,9 +1268,8 @@ DEF
tests such as the one of
-boot once I'm about to add. Drop it.
Signed-off-by: Markus Armbruster arm...@redhat.com
We could always add a reset qtest command. Probably makes more sense really.
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
qtest.c | 7
that the device model has been reset.
Regards,
Anthony Liguori
+test_pc_cmos(reboot1, reboot2);
+qtest_quit(global_qtest);
+g_free(args);
+}
+
+static void test_pc_boot_order(void)
+{
+test_pc_with_args(, 0x30, 0x12, 0x30, 0x12);
+test_pc_with_args(-no-fd-bootchk, 0x31
= powermac_fw_cfg_read16(newworld, FW_CFG_BOOT_DEVICE);
+g_assert_cmphex(actual, ==, expected_boot);
+qmp({ 'execute': 'system_reset' });
Same concern here but otherwise looks good.
Regards,
Anthony Liguori
+actual = powermac_fw_cfg_read16(newworld, FW_CFG_BOOT_DEVICE);
+g_assert_cmphex(actual
Markus Armbruster arm...@redhat.com writes:
Cc: Andreas Färber afaer...@suse.de
Cc: Alexander Graf ag...@suse.de
Cc: qemu-...@nongnu.org
Signed-off-by: Markus Armbruster arm...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
tests/boot-order
(port + 1);
}
It's worth looking at the rtc-test case and pulling out
cmos_read/write() into libqos I suspect.
Regards,
Anthony Liguori
-static void test_pc_cmos(uint8_t boot1, uint8_t boot2)
+static uint64_t read_boot_order_pc(void)
{
-test_pc_cmos_byte(0x38, boot1
(uint64_t cfg_addr, uint16_t cmd,
+static void read_fw_cfg(uint64_t cfg_addr, bool addr_is_io, uint16_t cmd,
void *buf, size_t len)
I missed it earlier, but you can use libqos/fw_cfg.h for this.
Regards,
Anthony Liguori
{
uint8_t *p = buf;
size_t i
that must persist
through a reboot or migration. A sample command line may look like
this:
This should be folded into the libtpms backend series.
There are no users for this so this would just be untestable code in the
tree subject to bitrot.
Regards,
Anthony Liguori
qemu-system-x86_64
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 10:01 AM, Anthony Liguori wrote:
Corey Bryant cor...@linux.vnet.ibm.com writes:
This patch series provides persistent storage support that a TPM
can use to store NVRAM data. It uses QEMU's block driver to store
data on a drive
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 11:38 AM, Anthony Liguori wrote:
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 10:01 AM, Anthony Liguori wrote:
Corey Bryant cor...@linux.vnet.ibm.com writes:
This patch series provides persistent storage support
it's already in the block tree, I'll
push it directly as it's blocking my queue.
Unless Kevin or Stefan are planning on sending a pull request today of
course.
Regards,
Anthony Liguori
thanks
-- PMM
to do a synchronous screendump?
Regards,
Anthony Liguori
---
hmp.c | 2 +-
hw/display/qxl-render.c | 1 +
hw/display/vga.c | 1 +
include/qapi/qmp/qerror.h | 6 +
include/ui/console.h | 10
qapi-schema.json | 13 ---
qmp
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 11:56 AM, Anthony Liguori wrote:
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 11:38 AM, Anthony Liguori wrote:
Corey Bryant cor...@linux.vnet.ibm.com writes:
On 06/14/2013 10:01 AM, Anthony Liguori wrote:
Corey
to
survive is a good idea, but it has been done.
Doesn't kexec do a warm reboot stashing the new kernel somewhere in
memory?
Regards,
Anthony Liguori
migration and spice.
Even with a non-seamless VNC reconnect, if it happens behind the scenes
the release would still be sent.
Regards,
Anthony Liguori
Paolo
Amos Kong ak...@redhat.com writes:
On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote:
On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote:
Amos Kong ak...@redhat.com writes:
Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE,
but ps2 backend doesn't
getting rid
of it first before making pseries the default.
I still think spapr would be a better name than pseries FWIW since
that's what it's referred to in the code.
Regards,
Anthony Liguori
Given the current state and amount of development on the pseries target, I
think it makes sense
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/06/2013 09:01, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/06/2013 06:19, Andreas Färber ha scritto:
Am 31.05.2013 14:31, schrieb Amos Kong:
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index cdb18e6..fdb9912
501 - 600 of 9887 matches
Mail list logo
