Paolo Bonzini pbonz...@redhat.com writes:
Il 11/05/2013 00:58, Anthony Liguori ha scritto:
Aurelien Jarno aurel...@aurel32.net writes:
On Fri, May 10, 2013 at 01:47:55PM -0500, Anthony Liguori wrote:
Most QOM types use type_register_static but we still strdup the
passed data. However
a
typeimpl and then use a function that returns a static similar to how
glib works.
If you've got a reproducible case where the overhead is high, it should
be easy to check.
Regards,
Anthony Liguori
At least patches 1-7 are for 1.5.
Paolo Bonzini (9):
qom: improve documentation of cast functions
Andreas Färber afaer...@suse.de writes:
Am 09.05.2013 08:23, schrieb Michael Tokarev:
08.05.2013 17:25, Anthony Liguori wrote:
Michael Tokarev m...@tls.msk.ru writes:
08.05.2013 13:46, Trival wrote:
Signed-off-by: Trival triv...@linux.vnet.ibm.com
Something went wrong in sending
bit as a feature.
Slow the VCPU down is not quite the same as setting priority of the VCPU
thread largely because of the QBL so I recognize the need to have
something for this in QEMU.
Regards,
Anthony Liguori
(qemu) info migrate
capabilities: xbzrle: off auto-converge: off
[.] type_is_ancestor
That's worrisome, but should be easy to fix... can you make a callgraph
profile?
So percentage of a profiling run doesn't imply a performance regression.
Are there real performance numbers here?
Regards,
Anthony Liguori
Paolo
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 15:01, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Cast debugging can have a substantial cost (20% or more, measured by
Aurelien on qemu-system-ppc64).
[Needs citation]
Sure: http://permalink.gmane.org
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 15:23, Andreas Färber ha scritto:
Am 10.05.2013 15:08, schrieb Paolo Bonzini:
Il 10/05/2013 15:01, Anthony Liguori ha scritto:
I'd prefer not to disable but instead focus on improving performance.
For 1.5? This is a regression in 1.5
this code, and
avoid a complicated mess of semantics that differ between 1.5,
1.5, and 1.5.
Conflicts:
hw/i386/pc_piix.c
hw/i386/pc_q35.c
include/hw/i386/pc.h
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Acked-by: Anthony Liguori aligu...@us.ibm.com
I was hestitant
.
static inline PowerPCCPU *ppc_env_get_cpu(CPUPPCState *env)
{
-return POWERPC_CPU(container_of(env, PowerPCCPU, env));
+return container_of(env, PowerPCCPU, env);
}
So if this is worthwhile shouldn't we be doing it for
all our CPUs?
Ack.
Regards,
Anthony Liguori
thanks
-- PMM
Andreas Färber afaer...@suse.de writes:
A transition from CPUPPCState to PowerPCCPU can be considered safe,
just like PowerPCCPU::env access in the opposite direction.
This should slightly improve interrupt performance.
Reported-by: Anthony Liguori aligu...@us.ibm.com
Signed-off
Daniel P. Berrange berra...@redhat.com writes:
On Fri, May 10, 2013 at 08:07:51AM -0500, Anthony Liguori wrote:
Chegu Vinod chegu_vi...@hp.com writes:
If a user chooses to turn on the auto-converge migration capability
these changes detect the lack of convergence and throttle down
Chegu Vinod chegu_vi...@hp.com writes:
On 5/10/2013 6:07 AM, Anthony Liguori wrote:
Chegu Vinod chegu_vi...@hp.com writes:
If a user chooses to turn on the auto-converge migration capability
these changes detect the lack of convergence and throttle down the
guest. i.e. force the VCPUs
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 16:39, Anthony Liguori ha scritto:
I just oppose the notion of disabling casts and *especially* only
disabling casts for official builds.
This actually happens all the time. Exactly this kind of type-safe cast
is disabled in releases
with
--{enable,disable}-qom-casts? My suspicion is that this is the primary
source of speed up.
If you can make an image available too, I can try this myself.
Regards,
Anthony Liguori
return class;
}
@@ -475,7 +473,7 @@ ObjectClass *object_class_dynamic_cast(ObjectClass
Bonzini pbonz...@redhat.com
Cc: Aurelien Jarno aurel...@aurel32.net
Cc: Andreas Färber afaer...@suse.de
Reported-by: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
Aurelien, could you please try this patch with your PPC test case?
---
qom/object.c | 16
% faster.
I just posted another patch which I believe will also reduce this
overhead without eliminating the checks.
We do a staggering number of casts... The patch I posted makes the
overwhelming majority of them nothing more than a single pointer
comparison and a couple derefs.
Regards,
Anthony
Aurelien Jarno aurel...@aurel32.net writes:
On Fri, May 10, 2013 at 12:41:07PM -0500, Anthony Liguori wrote:
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 16:39, Anthony Liguori ha scritto:
I just oppose the notion of disabling casts and *especially* only
disabling casts
Aurelien Jarno aurel...@aurel32.net writes:
On Fri, May 10, 2013 at 01:47:55PM -0500, Anthony Liguori wrote:
Most QOM types use type_register_static but we still strdup the
passed data. However, the original pointers are useful because
GCC is pretty good about collapsing strings so its very
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 19:41, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/05/2013 16:39, Anthony Liguori ha scritto:
I just oppose the notion of disabling casts and *especially* only
disabling casts for official builds
Michael Tokarev m...@tls.msk.ru writes:
08.05.2013 13:46, Trival wrote:
Signed-off-by: Trival triv...@linux.vnet.ibm.com
Something went wrong in sending this. This is not a valid SoB.
Regards,
Anthony Liguori
---
block/nbd.c | 2 +-
fsdev/virtfs-proxy-helper.c | 4
works is
one of them.
BTW, xgettext is stupid and very difficult to make not put this in
here. I still need to find some time to work that out. There's an
option that lets you say, copyrighted by so-and-so but that's not what
we need.
Regards,
Anthony Liguori
Paolo
the bus master is stopped (Kevin Wolf)
- de_DE.po: Add missing leading spaces (Kevin Wolf)
- ahci: Don't allow creating slave drives (Kevin Wolf)
Regards,
Anthony Liguori
, for compatibility reasons, stick with the 0666 file-mode in
case of files newly created by the guest-file-open QMP call. Do so
without changing the umask temporarily.
Signed-off-by: Laszlo Ersek ler...@redhat.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qga/commands-posix.c | 123
A little delayed as we had some last minute pull requests but we are now
bug fixes only from this point on. We'll have the first -rc1 on
Wednesday. I'll post an -rc0 tarball shortly.
Regards,
Anthony Liguori
://wiki.qemu.org/ChangeLog/Next
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Anthony Liguori aligu...@us.ibm.com writes:
Applied. Thanks.
Hi,
This was an automated response so it doesn't acknowledge the fact that
since this was a CVE, I applied the original patch regardless of review
feedback to avoid any confusion about whether the CVE has been addressed
-based QContext and be done with it. Hopefully
that is the case...
Why even bother with QContext then?
Regards,
Anthony Liguori
Paolo
than 5pm US/Eastern.
Regards,
Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes:
Il 06/05/2013 16:42, Anthony Liguori ha scritto:
Hi,
I believe I have processed all of the outstanding pull requests and
patches tagged for 1.5. If there are any other patches or pull requests
you would like to be considered, please respond
Jordan Justen jljus...@gmail.com writes:
On Mon, May 6, 2013 at 7:42 AM, Anthony Liguori aligu...@us.ibm.com wrote:
I believe I have processed all of the outstanding pull requests and
patches tagged for 1.5. If there are any other patches or pull requests
you would like to be considered
: ‘VirtIODevice’
has no member named ‘guest_notifier_mask’
CChw/virtio/dataplane/hostmem.o
make: *** [hw/virtio/virtio-pci.o] Error 1
Regards,
Anthony Liguori
---
hw/virtio/virtio-pci.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index
Daniel P. Berrange berra...@redhat.com writes:
On Thu, May 02, 2013 at 10:40:06AM -0500, Anthony Liguori wrote:
Kevin Wolf kw...@redhat.com writes:
+
+if (strcmp(type, ide-cd) == 0) {
+disk_type = DT_CDROM;
+} else if (strcmp(type, isa-fdc) == 0
,
Anthony Liguori
For changing n270 CPUID flags we'll still need to resort to Eduardo's proposed
helper functions for now.
Regards,
Andreas
Cc: Eduardo Habkost ehabk...@redhat.com
Cc: Igor Mammedov imamm...@redhat.com
Cc: H. Peter Anvin h...@zytor.com
Cc: Borislav Petkov b...@suse.de
Cc
was already merged.
commit b48df71c916478ff658d143d0742e85c78348fad
Merge: 459 9adea5f
Author: Anthony Liguori aligu...@us.ibm.com
Date: Mon Apr 29 08:26:47 2013 -0500
Merge remote-tracking branch 'bonzini/migration-writev' into staging
# By Paolo Bonzini
# Via Paolo Bonzini
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Andreas Färber afaer...@suse.de writes:
Am 26.04.2013 21:43, schrieb Anthony Liguori:
This returns a string similar to what the guest would display in
something like Linux's /dev/disk/by-id/ path.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ide/qdev.c | 15
Kevin Wolf kw...@redhat.com writes:
Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben:
To generate this menu, we first walk the composition tree to
find any device with a 'drive' property. We then record these
devices and the BlockDriverState that they are associated with.
Then we
Kevin Wolf kw...@redhat.com writes:
Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben:
Kevin Wolf kw...@redhat.com writes:
Ugh. Comparing the device name to an incomplete set of strings here and
then figuring out for each what the specific way for this device is to
create a nice
Kevin Wolf kw...@redhat.com writes:
Am 02.05.2013 um 15:41 hat Anthony Liguori geschrieben:
Kevin Wolf kw...@redhat.com writes:
Am 26.04.2013 um 21:43 hat Anthony Liguori geschrieben:
+static void gd_block_device_menu_update(BlockDeviceMenu *bdm, BlockInfo
*info)
+{
+bool value
\(.*\)].*/Subject: [PULL\1]
'$BRANCHPFX' queue/;/^$/q' $COVERLETTER
You can also just do git format-patch --subject-prefix=PULL and avoid
any fixups...
Regards,
Anthony Liguori
(I really must put my random scripts into git.)
-- PMM
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
don't think it's very
likely that you'll get 100% consistency out of everybody
though.
Ack.
Regards,
Anthony Liguori
-- PMM
Paolo Bonzini pbonz...@redhat.com writes:
Il 02/05/2013 18:06, Michael S. Tsirkin ha scritto:
On Thu, May 02, 2013 at 10:52:47AM -0500, Anthony Liguori wrote:
Peter Maydell peter.mayd...@linaro.org writes:
On 2 May 2013 16:30, Paolo Bonzini pbonz...@redhat.com wrote:
/me changes his scripts
on the trivial-patches queue, see:
http://qemu-project.org/Contribute/TrivialPatches
(This page will be updated when mjt chooses a public repo for his pull
requests.)
Thank you Michael!
Thanks for maintaining trivial for so long Stefan!
Regards,
Anthony Liguori
Stefan
fork() in QEMU (it doesn't exist on Windows so it can't be
used without protection). None of those places use the error reporting
infrastructure.
This code is also extremely naive. It doesn't take into account leap
seconds and makes bad assumptions about leap years.
Regards,
Anthony Liguori
Aurelien Jarno aurel...@aurel32.net writes:
On Mon, Apr 29, 2013 at 01:05:03PM -0500, Anthony Liguori wrote:
7) Checkout the latest master branch, apply the diff from (6)
- There were a lot of comment rejects, confirmed this was only comments
and then used an emacs macro to rewrite
.
Regards,
Anthony Liguori
---
hw/i386/pc_piix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index c1113e0..2bda79e 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -88,6 +88,7 @@ static void pc_init1(MemoryRegion *system_memory,
void
the
previous RFC version committed accidentally instead of this one?
Your Reviewed-by is missing because I applied the series before you sent
the Reviewed-by.
Regards,
Anthony Liguori
No, the RFC only had 6 patches and patches 6-7-8 were completely
different (and broken).
Paolo
Jesse Larrew jlar...@linux.vnet.ibm.com writes:
libqtest.c can segfault when calling fclose() if the pidfile wasn't
opened successfully. This patch fixes the issue.
Signed-off-by: Jesse Larrew jlar...@linux.vnet.ibm.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony
split out a refactoring patch of the
existing TLS code but it looks okay as-is.
I'm not a TLS expert but:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
I'll give folks a couple more days to review and then I'll apply. Thanks.
Regards,
Anthony Liguori
---
Changes v2
* a peek buffer of 4
Michael S. Tsirkin m...@redhat.com writes:
On Tue, Feb 05, 2013 at 09:08:20PM -0600, Anthony Liguori wrote:
Michael Roth mdr...@linux.vnet.ibm.com writes:
Migration from 1.3 currently fails due to a mismatch between the expected
size
of 256KB and the received size of 128KB for seabios
|-
| 2013-05-15
| Tag v1.5.0-rc2
|-
| 2013-05-17
| Tag v1.5.0
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
and (b) QEMU's softfloat
is based on 2b, not 2 (as the kernel's is.)
The kernel code is quite different than the QEMU code too. Looks like
it would be quite a lot of work to switch to the kernel implementation.
That said, I think it's our best long term option...
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes:
Use correct unref function, cursors are not gobjects (at least in gtk2).
Fixes crash, reproducer: qemu -vga qxl -display gtk.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
certainly do. QEMU 1.4 had virtio-rng and therefore had this bug
so we need to allocate a CVE.
Regards,
Anthony Liguori
--
MST
to not be tried on
certain networks.
Regards,
Anthony Liguori
diff --git a/vl.c b/vl.c
index 6caa5f4..84d7031 100644
--- a/vl.c
+++ b/vl.c
@@ -248,7 +248,7 @@ struct FWBootEntry {
char *suffix;
};
-static QTAILQ_HEAD(, FWBootEntry) fw_boot_order =
+static QTAILQ_HEAD(FWBootOrder
Dominik Dingel din...@linux.vnet.ibm.com writes:
Instead of manually parsing the boot_list as character stream,
we can access the nth boot device, specified by the position in the
boot order.
Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com
Reviewed-by: Anthony Liguori aligu
.
It's not what users expect when they compile code inside of pc-bios. Please
stick to whatever behavior other blobs that we compile on demand have.
Ack.
Regards,
Anthony Liguori
Alex
fine with
pulling that in.
So I don't see a problem with the no-fallback behavior (nor with it
changing down the road), but the bootindex change would cause a
regression on x86.
Regards,
Anthony Liguori
Alex
Dominik Dingel din...@linux.vnet.ibm.com writes:
On Fri, 26 Apr 2013 11:36:11 -0500
Anthony Liguori anth...@codemonkey.ws wrote:
Dominik Dingel din...@linux.vnet.ibm.com writes:
Currently only devices with a positive boot index will be pushed in the
fw_boot_order queue, so if no boot
This small series adds a devices menu to the GTK UI allowing
a user to change or eject a removable block device from the menus.
This lets us register for events internally within QEMU.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
include/qapi/qmp/qevents.h | 21 +
monitor.c | 15 +++
2 files changed, 36 insertions(+)
create mode 100644 include/qapi/qmp/qevents.h
hot-plug yet but it should deal nicely
with someone using the human monitor.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
ui/gtk.c | 302 +++
1 file changed, 302 insertions(+)
diff --git a/ui/gtk.c b/ui/gtk.c
index e12f228
This returns a string similar to what the guest would display in
something like Linux's /dev/disk/by-id/ path.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ide/qdev.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 8a9a891
/acpi.c
Ping... When may I expect reviews for this?
I'll take a look this afternoon.
It helps to CC folks who could potentially review it. When it doubt,
never hurts to CC me.
Regards,
Anthony Liguori
Laszlo Ersek ler...@redhat.com writes:
Currently some places use pointer-to-void even though they mean
pointer-to-FWCfgState. Clean them up.
Signed-off-by: Laszlo Ersek ler...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards
asl_compiler_id[4]; /* ASL compiler vendor ID */
+uint32_t asl_compiler_revision; /* ASL compiler revision number */
+} QEMU_PACKED AcpiTableStdHdr;
Since you're giving it a CamelCaseName why don't you do the same for the
struct. After that:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards
Laszlo Ersek ler...@redhat.com writes:
Signed-off-by: Laszlo Ersek ler...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
hw/acpi/core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
as a pointer later on or something like that?
Can we make a function that does that?
Regards,
Anthony Liguori
#endif /* !QEMU_HW_ACPI_H */
diff --git a/hw/acpi/core.c b/hw/acpi/core.c
index d348f81..36a4d03 100644
--- a/hw/acpi/core.c
+++ b/hw/acpi/core.c
@@ -37,11 +37,20 @@ struct acpi_table_header
Laszlo Ersek ler...@redhat.com writes:
Again, this enables reuse when preparing per-table fw_cfg blobs later.
Signed-off-by: Laszlo Ersek ler...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
include
Laszlo Ersek ler...@redhat.com writes:
From: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Laszlo Ersek ler...@redhat.com
Acked-by: Michael S. Tsirkin m...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony
, the PCI interrupt assignments,
the APIC ids, the number of available CPUs, etc.
The commit message also doesn't provide any reason about why we would
want this. The cover letter provides a reference at least but cover
letters don't end up in git history.
Regards,
Anthony Liguori
:
http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg04773.html
Pleae let me know if there is anything else need be improved.
Thanks!
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
I'll give people some time to take a look before applying but it looks good to
me.
Regards,
Anthony
Michael R. Hines mrhi...@linux.vnet.ibm.com writes:
On 04/25/2013 03:45 PM, Anthony Liguori wrote:
mrhi...@linux.vnet.ibm.com writes:
From: Michael R. Hines mrhi...@us.ibm.com
Code that does need to be visible is kept
well contained inside this file and this is the only
new additional
.
Regards,
Anthony Liguori
Signed-off-by: Jason Wang jasow...@redhat.com
---
hw/virtio/virtio.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 1c2282c..a6fa667 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio
Eduardo Habkost ehabk...@redhat.com writes:
On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote:
Laszlo Ersek ler...@redhat.com writes:
--- /dev/null
+++ b/hw/i386/acpi.h
+
+#include stddef.h
QEMU style would normally be to use qemu-common.h here but honestly I
prefer
Pulled. Thanks.
Regards,
Anthony Liguori
801 - 900 of 9887 matches
Mail list logo
