Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Luiz Capitulino lcapitul...@redhat.com writes:
On Thu, 25 Apr 2013 20:55:40 -
Anthony Liguori aligu...@us.ibm.com wrote:
Applied. Thanks.
Really? This contains the screendump extension we agreed on not doing.
Nope, just a bug in my notify script.
Somehow was triggered by merging
Eric Blake ebl...@redhat.com writes:
On 04/25/2013 03:17 PM, Luiz Capitulino wrote:
On Thu, 25 Apr 2013 20:55:40 -
Anthony Liguori aligu...@us.ibm.com wrote:
Applied. Thanks.
Really? This contains the screendump extension we agreed on not doing.
I tend to agree that we should
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Apr 25, 2013 at 03:20:20PM -0500, Anthony Liguori wrote:
Jason Wang jasow...@redhat.com writes:
In fact we don't support zero length config length for virtio device.
virtio-rng?
It has config_len == 0? In that case guest using virtio
this.
Regards,
Anthony Liguori
Andreas
+# Ozan Çağlayan ozan...@gmail.com, 2013.
+#
+msgid
+msgstr
+Project-Id-Version: QEMU 1.4.50\n
+Report-Msgid-Bugs-To: qemu-devel@nongnu.org\n
+POT-Creation-Date: 2013-04-22 18:33+0300\n
+PO-Revision-Date: 2013-04-22 18:35+0300\n
+Last
to probe for the former feature, it will result in
a false positive.
That's why a more direct feature negotiation mechanism is better IMHO.
Regards,
Anthony Liguori
if we change a command, how we change the interface without
changing the c-api?
c-api is not yet a strong consideration
. The following does not:
qemu-system-x86_64 -nodefaults -vnc :0
Regards,
Anthony Liguori
[...]
Program received signal SIGSEGV, Segmentation fault.
0x006428b9 in surface_height (s=0x0)
at /home/armbru/work/qemu/include/ui/console.h:253
253 return pixman_image_get_height(s-image
that no HMP counterpart is needed. However, I don't think we
have quite the right interface yet.
Signed-off-by: Amos Kong ak...@redhat.com
CC: Osier Yang jy...@redhat.com
CC: Anthony Liguori aligu...@us.ibm.com
---
qapi-schema.json | 29 +
qmp-commands.hx
/aliguori/git/qemu/hw/display/xenfb.c:990:5: error: too few arguments to
function ‘graphic_console_init’
In file included from /home/aliguori/git/qemu/hw/display/xenfb.c:39:0:
/home/aliguori/git/qemu/include/ui/console.h:280:14: note: declared here
Regards,
Anthony Liguori
please pull,
Gerd
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
.
Sacrificing VCPU performance to encourage convergence is a management
decision. In some cases, VCPU performance is far more important than
migration convergence.
Regards,
Anthony Liguori
Verified the convergence using the following:
- SpecJbb2005 workload running on a 20VCPU/128G guest(~80% busy
to suggestion if people think this
is low risk. I don't like the idea of adding a new protocol this close
to the end of a cycle.
Regards,
Anthony Liguori
Changes since v4:
- Re-ran checkpatch.pl
- Added new QEMUFileOps function: qemu_get_max_size()
- Renamed capability to x-pin-all, disabled
Michael R. Hines mrhi...@linux.vnet.ibm.com writes:
On 04/23/2013 01:50 PM, Anthony Liguori wrote:
mrhi...@linux.vnet.ibm.com writes:
From: Michael R. Hines mrhi...@us.ibm.com
Juan, Please pull.
I assume this is actually v6, not v5?
I don't see collected Reviewed-bys...
That said
by QEMU, why not just
make it part of the tree?
Regards,
Anthony Liguori
Anyway, the qemu-palcode submodule is hosted on repo.or.cz.
Could we have a copy on git.qemu.org like the other roms, to
avoid 'git submodule init/update' being flaky due to repo.or.cz
flakiness, please?
(One of our
Michael R. Hines mrhi...@linux.vnet.ibm.com writes:
On 04/23/2013 02:26 PM, Anthony Liguori wrote:
Michael R. Hines mrhi...@linux.vnet.ibm.com writes:
On 04/23/2013 01:50 PM, Anthony Liguori wrote:
mrhi...@linux.vnet.ibm.com writes:
From: Michael R. Hines mrhi...@us.ibm.com
Juan, Please
be greatly appreciated!
Regards,
Anthony Liguori
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
. This is a dramatically
different semantic behavior.
What's the use-case here?
Regards,
Anthony Liguori
Paolo
stef...@linux.vnet.ibm.com
This doesn't apply. Looks like it's pre-QOM?
Regards,
Anthony Liguori
---
tpm/tpm.c |8
tpm/tpm_int.h |8
tpm/tpm_passthrough.c | 16
vl.c | 16 +---
4 files
. So let's take the opportunity to fix
the command.
We can also introduce a format parameter to allow specifying formats
othe than PPM.
Regards,
Anthony Liguori
Paolo
Paolo Bonzini pbonz...@redhat.com writes:
Il 22/04/2013 18:49, Anthony Liguori ha scritto:
We've been adding fields to types since 0.15, sometimes in the middle of
a struct (since 1.2).
You can safely add fields to the end of a struct.
For QEMU-user structs it is. For user-QEMU structs
...@redhat.com
I was looking for a Reviewed-by, not just an Acked-by.
Regards,
Anthony Liguori
Pls pick this up for 1.5.
---
hw/pc.h | 4 +++
hw/virtio-net.c | 97
-
hw/virtio-net.h | 13
3 files changed, 99 insertions
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Hi Ozan,
Please include a Signed-off-by in your commit message. Otherwise:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
Ozan Çağlayan ozan...@gmail.com writes:
---
po/tr.po | 62 ++
1 file changed
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
protocol.
Anyone tried to bug vmware to open the specs for the existing
extension?
I have in the past but that was many years ago at this point.
Regards,
Anthony Liguori
cheers,
Gerd
);
+vnc_framebuffer_update(vs, 0, 0,
+ surface_width(vs-vd-ds),
+ surface_height(vs-vd-ds),
This can just be 1, 1. You don't have to send the actual width/height.
Otherwise, looks pretty good.
Regards,
Anthony Liguori
respectively and that '1' indicates that the LED should be on
and '0' should be off.
You should also list the psuedo-encoding number somewhere in this document.
Regards,
Anthony Liguori
--
1.7.7.6
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
, pci_dev.qdev);
}
Is that what you want?
Nack. Faster non-QOM casts is FUD.
Regards,
Anthony Liguori
@@ -629,7 +626,7 @@ static int virtio_net_can_receive(NetClientState *nc)
}
if (!virtio_queue_ready(q-rx_vq) ||
-!(n-vdev.status VIRTIO_CONFIG_S_DRIVER_OK
was supposed to use the faster non-QOM casts.
No, we're not. I don't know where you got that idea from.
Unless you have actual performance numbers to show that it matters, then
you're just speculating.
Regards,
Anthony Liguori
.
Michael, please ping me on SameTime and we'll discuss how to license
this code.
FYI, for the other folks on CC, we have very clear rules at IBM about
how we do this and none of what's been posted so far follows it :-)
Regards,
Anthony Liguori
the copyrights in this series as they are bogus for all
intents and purposes.
Regards,
Anthony Liguori
Paolo
-encoding data and just send the current
led state once after set_encodings and then whenever the state changes
again.
Regards,
Anthony Liguori
+
static void set_encodings(VncState *vs, int32_t *encodings, size_t
n_encodings)
{
int i;
@@ -1897,6 +1943,10 @@ static void set_encodings
scripts.
Regards,
Anthony Liguori
Michael R. Hines (11):
rdma: export yield_until_fd_readable()
rdma: introduce qemu_ram_foreach_block()
rdma: introduce qemu_file_mode_is_not_valid()
rdma: export
This is libqos support for qtest. A few things are omitted from
the RFC review in order to help get this merged quickly. Notably,
there's still no way to tear down a device (pci_iounmap is hard to
implement well). I haven't attempted to refactor i2c support and
I have not introduced convenience
fw_cfg is needed to get the top of memory which is necessary for
doing PCI allocation and allocating RAM for DMA.
Add a PC version of fw_cfg and enough abstraction to support other
platforms.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 4 ++--
tests/libqos
This includes basic PCI support for the PC platform. Enough
abstraction should be present to support non-PC platforms too.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
v1 - v2
- fixup size calculation (Kevin Wolf)
---
configure | 2 +-
tests/Makefile| 5
Currently we waitpid on the child process we spawn off that does
nothing more than system() another process. While this does not
appear to be incorrect, it's wasteful and confusing so get rid of
it.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/libqtest.c | 11 ---
1 file
not a simple fix if we really care to fix it. For now, just
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 2 +
tests/i440fx-test.c | 148
2 files changed, 150 insertions(+)
create mode 100644 tests/i440fx-test.c
This tests PAM settings for the i440fx. This test does a lot of
byte MMIO which is fairly slow with qtest today. But the test
does complete in under 2 seconds.
We don't fully emulate PAM largely because of limitations with
KVM so we #if 0 that part of the test case.
Signed-off-by: Anthony
, 3307 insertions(+), 21 deletions(-)
create mode 100644 docs/rdma.txt
create mode 100644 migration-rdma.c
NACK,
I am not planning on pulling/applying these patches directly. I'd
expect them to be applied to Juan's tree and collecting Reviewed-bys on
the list.
Regards,
Anthony Liguori
This validates some basic characteristics of fw_cfg.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 2 +
tests/fw_cfg-test.c | 141
2 files changed, 143 insertions(+)
create mode 100644 tests/fw_cfg-test.c
This is a very simple allocator for the PC platform. It should
be possible to add backends for other platforms.
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
tests/Makefile | 1 +
tests/libqos/malloc-pc.c | 71
tests/libqos
owass...@redhat.com
Per Paolo, I will process this through my queue.
Regards,
Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 16:32, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 16/04/2013 04:44, mrhi...@linux.vnet.ibm.com ha scritto:
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit
Eric Blake ebl...@redhat.com writes:
On 04/16/2013 09:56 AM, Eric Blake wrote:
On 04/16/2013 08:45 AM, Anthony Liguori wrote:
This test compares all of the default register values against the
spec. It turns out we deviate in quite a few places. These
places are really only visible
-send-patch, git am --3way
would have figured it out. Please use git-send-patch in the future.
Regards,
Anthony Liguori
---
tpm/tpm_passthrough.c | 74
+++---
1 file changed, 17 insertions(+), 57 deletions(-)
Index: qemu-git.pt/tpm
I know there are a few different trees out there. Not sure if anyone is
currently working on rebasing the earlier patch series. I had thought
we were aiming for 1.5 but we're getting pretty late for that.
Regards,
Anthony Liguori
in QEMU. It's only visible to
firmware (at least on the PC) so there's little benefit to modeling.
Regards,
Anthony Liguori
Paolo
Regards,
Anthony Liguori
---
savevm.c | 100
---
1 file changed, 89 insertions(+), 11 deletions(-)
diff --git a/savevm.c b/savevm.c
index 0415830..8eb5aab 100644
--- a/savevm.c
+++ b/savevm.c
@@ -356,9 +356,93 @@ static const
Nicholas A. Bellinger n...@linux-iscsi.org writes:
On Tue, 2013-04-16 at 13:45 -0500, Anthony Liguori wrote:
I know there are a few different trees out there. Not sure if anyone is
currently working on rebasing the earlier patch series. I had thought
we were aiming for 1.5 but we're getting
the migration coroutine cleans itself so there's no
obvious way to propagate the error. A nicer cleanup would be to switch
the fprintf to error_report() too but this is certainly better than what
we have now.
Maybe we need an error_report_fatal()...
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
post patches along
with pull requests.
I noticed that the last patch does not include a copyright/license so
you'll need to respin anyway.
Regards,
Anthony Liguori
Michael S. Tsirkin (4):
kvm: remove unused APIs
kvm
.
Peter, can you confirm?
Regards,
Anthony Liguori
---
main-loop.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/main-loop.c b/main-loop.c
index f46aece..93d2917 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -200,10 +200,13 @@ static int
Paolo Bonzini pbonz...@redhat.com writes:
Il 15/04/2013 15:08, Anthony Liguori ha scritto:
Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com
I'm going through patches for 1.5 candidates.
I believe the paste performance issue has been resolved now and this
patch is no longer
.
If the guest changes LED state, we want to the client to update the
physical keyboard LED state.
Think thin client without an X server.
Regards,
Anthony Liguori
cheers,
Gerd
Gerd Hoffmann kra...@redhat.com writes:
On 04/15/13 16:41, Anthony Liguori wrote:
Gerd Hoffmann kra...@redhat.com writes:
Hi,
When access a guest by console through VNC, there might be
mismatch between the lock keys notification LED on the computer
running the VNC client session
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
titi:~/build/qemu$ echo -e 'cont\nscreendump
abc.ppm' | x86_64-softmmu/qemu-system-x86_64 -monitor stdio -vga std -S
-vnc :0 -enable-kvm -nodefaults
Which appears to be all of the obvious options in your command line that
would be relevant here. I notice that you're on
Regards,
Anthony Liguori
I had considered.
Regards,
Anthony Liguori
Thanks,
Edgar
commit 947414a56e256139a510a034c02ac277ad577272
Author: Edgar E. Iglesias edgar.igles...@gmail.com
Date: Wed Apr 10 20:32:17 2013 +0200
Allow qtest to be used together with a virtual CPU
Signed-off-by: Edgar E
. Berrange berra...@redhat.com
[Use errx, not err. - Paolo]
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
qemu-nbd.c| 20 ++--
qemu-nbd.texi | 2 ++
2 files changed, 20 insertions(+), 2 deletions(-)
diff --git a/qemu-nbd.c
Anthony Liguori aligu...@us.ibm.com writes:
From: Daniel P. Berrange berra...@redhat.com
Currently the qemu-nbd program will auto-detect the format of
any disk it is given. This behaviour is known to be insecure.
For example, if qemu-nbd initially exposes a 'raw' file to an
unprivileged app
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
901 - 1000 of 9887 matches
Mail list logo
