Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-06-12 Thread Cord Amfmgm
On Wed, Jun 12, 2024 at 2:36 PM Alex Bennée wrote: > Cord Amfmgm writes: > > > On Wed, Jun 12, 2024 at 9:21 AM Alex Bennée > wrote: > > > > David Hubbard writes: > > > > > From: Cord Amfmgm > > > > > > This chan

Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-06-12 Thread Cord Amfmgm
On Wed, Jun 12, 2024 at 9:21 AM Alex Bennée wrote: > David Hubbard writes: > > > From: Cord Amfmgm > > > > This changes the way the ohci emulation handles a Transfer Descriptor > with > > "Current Buffer Pointer" set to "Buffer End" + 1.

Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-06-08 Thread Cord Amfmgm
On Fri, Jun 7, 2024 at 8:23 AM Peter Maydell wrote: > On Fri, 31 May 2024 at 19:16, Cord Amfmgm wrote: > > On Fri, May 31, 2024 at 9:03 AM Peter Maydell > wrote: > >> What I would like to see is what we could classify under > >> "rationale", w

Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-05-31 Thread Cord Amfmgm
On Fri, May 31, 2024 at 9:03 AM Peter Maydell wrote: > On Tue, 21 May 2024 at 00:26, David Hubbard wrote: > > > > From: Cord Amfmgm > > > > This changes the way the ohci emulation handles a Transfer Descriptor > with > > "Current Buffer Pointer"

Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-05-30 Thread Cord Amfmgm
On Thu, May 30, 2024 at 2:14 PM Alex Bennée wrote: > David Hubbard writes: > > > From: Cord Amfmgm > > > > This changes the way the ohci emulation handles a Transfer Descriptor > with > > "Current Buffer Pointer" set to "Buffer End" + 1.

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Cord Amfmgm
On Thu, May 30, 2024 at 2:12 PM Alex Bennée wrote: > Cord Amfmgm writes: > > > On Thu, May 30, 2024 at 3:33 AM Alex Bennée > wrote: > > > > Cord Amfmgm writes: > > > > > On Tue, May 28, 2024 at 11:32 AM Peter Maydell < > peter.mayd...@linar

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-30 Thread Cord Amfmgm
On Thu, May 30, 2024 at 3:33 AM Alex Bennée wrote: > Cord Amfmgm writes: > > > On Tue, May 28, 2024 at 11:32 AM Peter Maydell > wrote: > > > > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > On Tue, May 28, 2024 at 9:03 AM Pete

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-29 Thread Cord Amfmgm
On Tue, May 28, 2024 at 11:32 AM Peter Maydell wrote: > On Tue, 28 May 2024 at 16:37, Cord Amfmgm wrote: > > > > > > > > On Tue, May 28, 2024 at 9:03 AM Peter Maydell > wrote: > >> > >> On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: >

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-28 Thread Cord Amfmgm
On Tue, May 28, 2024 at 9:03 AM Peter Maydell wrote: > On Mon, 20 May 2024 at 23:24, Cord Amfmgm wrote: > > On Mon, May 20, 2024 at 12:05 PM Peter Maydell > wrote: > >> For the "zero length buffer" case, do you have a more detailed > >> pointer to

Re: [PATCH] hw/usb/hcd-ohci: Fix ohci_service_td: accept valid TDs

2024-05-20 Thread Cord Amfmgm
On Mon, May 20, 2024 at 6:24 PM David Hubbard wrote: > From: Cord Amfmgm > > This changes the way the ohci emulation handles a Transfer Descriptor with > "Current Buffer Pointer" set to "Buffer End" + 1. > Please disregard, this patch is no different from t

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Cord Amfmgm
On Mon, May 20, 2024 at 12:05 PM Peter Maydell wrote: > On Tue, 6 Feb 2024 at 13:25, Cord Amfmgm wrote: > > > > This changes the ohci validation to not assert if invalid > > data is fed to the ohci controller. The poc suggested in > > https://bugs.laun

Re: [PATCH 1/2] hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-20 Thread Cord Amfmgm
On Mon, May 20, 2024 at 11:55 AM Peter Maydell wrote: > On Thu, 9 May 2024 at 01:30, David Hubbard wrote: > > > > From: Cord Amfmgm > > > > This changes the ohci validation to not assert if invalid data is fed to > the > > ohci controller. The poc in

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-12 Thread Cord Amfmgm
On Sat, May 11, 2024 at 5:25 AM Peter Maydell wrote: > On Thu, 9 May 2024 at 19:17, Cord Amfmgm wrote: > > > > > > > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell > wrote: > >> > >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > >

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-10 Thread Cord Amfmgm
On Thu, May 9, 2024 at 3:37 PM BALATON Zoltan wrote: > On Thu, 9 May 2024, Cord Amfmgm wrote: > > On Thu, May 9, 2024 at 12:48 PM Peter Maydell > > wrote: > > > >> On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > >>> On Wed, May 8, 2024 at 3:45 AM Tho

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-09 Thread Cord Amfmgm
On Thu, May 9, 2024 at 12:48 PM Peter Maydell wrote: > On Wed, 8 May 2024 at 16:29, Cord Amfmgm wrote: > > On Wed, May 8, 2024 at 3:45 AM Thomas Huth wrote: > >> > >> Your Signed-off-by line does not match the From: line ... could you > please > >> fix

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-08 Thread Cord Amfmgm
On Wed, May 8, 2024 at 4:53 AM Philippe Mathieu-Daudé wrote: > On 7/5/24 22:20, Cord Amfmgm wrote: > > > > > > On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm > <mailto:dmamf...@gmail.com>> wrote: > > > > On Thu, Apr 18, 2024 at 10:43 AM Michael T

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-05-07 Thread Cord Amfmgm
On Wed, Apr 24, 2024 at 3:43 PM Cord Amfmgm wrote: > On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > >> 06.02.2024 10:13, Cord Amfmgm wrote: >> > This changes the ohci validation to not assert if invalid >> > data is fed to the ohci controller. T

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-04-24 Thread Cord Amfmgm
On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > 06.02.2024 10:13, Cord Amfmgm wrote: > > This changes the ohci validation to not assert if invalid > > data is fed to the ohci controller. The poc suggested in > > https://bugs.launchpad.net/qemu/+bug/1907042 > &g

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-04-19 Thread Cord Amfmgm
Hi Michael, This just got lost somehow. It is still an issue (see https://gitlab.com/qemu-project/qemu/-/issues/1510 ). I believe this change fixes the issue. On Thu, Apr 18, 2024 at 10:43 AM Michael Tokarev wrote: > 06.02.2024 10:13, Cord Amfmgm wrote: > > This changes the ohci v

Re: hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
Attempting to resend with both files in the patch this time: This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 migrated to #303 does the following to feed it a SETUP pid and EndPt of 1:

hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 and then migrated to bug #303 does the following to feed it a SETUP pid and EndPt of 1: uint32_t MaxPacket = 64; uint32_t

hw/usb/hcd-ohci: Fix #1510, #303: pid not IN or OUT

2024-02-06 Thread Cord Amfmgm
This changes the ohci validation to not assert if invalid data is fed to the ohci controller. The poc suggested in https://bugs.launchpad.net/qemu/+bug/1907042 migrated to #303 does the following to feed it a SETUP pid and EndPt of 1: uint32_t MaxPacket = 64; uint32_t TDFormat =