Re: [PATCH v2 3/6] hppa: Add support for an emulated TOC/NMI button.

2024-05-29 Thread Helge Deller
On 5/29/24 17:11, Philippe Mathieu-Daudé wrote: Hi Helge & Richard, Hi Philippe, Nevermind the missed review comments, I'm revisiting this patch while looking at building libtcg-hppa.so. Ok. On 1/2/22 00:56, Philippe Mathieu-Daudé wrote: On 31/1/22 22:35, Helge Deller wrote: Almost

Re: [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default

2024-05-28 Thread Helge Deller
On 5/28/24 12:35, Thomas Huth wrote: On 28/05/2024 11.54, Gerd Hoffmann wrote: The xhci host adapter is the much better choice. Signed-off-by: Gerd Hoffmann ---   hw/usb/hcd-ohci-pci.c | 1 +   hw/usb/Kconfig    | 1 -   2 files changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 41/45] target/hppa: Implement CF_PCREL

2024-05-14 Thread Helge Deller
dresses to install. > > As expected, this reduces the runtime overhead of compilation when > running a Linux kernel with address space randomization enabled. Ah! I was wondering why you tried to convert to CF_PCREL at all. So, that's the overall reason. > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 40/45] target/hppa: Adjust priv for B,GATE at runtime

2024-05-14 Thread Helge Deller
* Richard Henderson : > Do not compile in the priv change based on the first > translation; look up the PTE at execution time. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 39/45] target/hppa: Drop tlb_entry return from hppa_get_physical_address

2024-05-14 Thread Helge Deller
* Richard Henderson : > The return-by-reference is never used. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 38/45] target/hppa: Implement PSW_X

2024-05-14 Thread Helge Deller
* Richard Henderson : > Use PAGE_WRITE_INV to temporarily enable write permission > on for a given page, driven by PSW_X being set. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 37/45] target/hppa: Implement PSW_B

2024-05-14 Thread Helge Deller
* Richard Henderson : > PSW_B causes B,GATE to trap as an illegal instruction, removing > the sequential execution test that was merely an approximation. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 36/45] target/hppa: Manage PSW_X and PSW_B in translator

2024-05-14 Thread Helge Deller
t most once per TB. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 35/45] target/hppa: Split PSW X and B into their own field

2024-05-14 Thread Helge Deller
* Richard Henderson : > Generally, both of these bits are cleared at the end of each > instruction. By separating these, we will be able to clear > both with a single insn, instead of 2 or 3. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 34/45] target/hppa: Improve hppa_cpu_dump_state

2024-05-14 Thread Helge Deller
* Richard Henderson : > Print both raw IAQ_Front and IAQ_Back as well as the GVAs. > Print control registers in system mode. > Print floating point register if CPU_DUMP_FPU. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 33/45] target/hppa: Do not mask in copy_iaoq_entry

2024-05-14 Thread Helge Deller
* Richard Henderson : > As with loads and stores, code offsets are kept intact until the > full gva is formed. In qemu, this is in cpu_get_tb_cpu_state. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 32/45] target/hppa: Store full iaoq_f and page offset of iaoq_b in TB

2024-05-14 Thread Helge Deller
ds wrong, or missing commas, but maybe I'm just wrong...? Other than that...: Reviewed-by: Helge Deller > Signed-off-by: Richard Henderson

Re: [PATCH v2 31/45] linux-user/hppa: Force all code addresses to PRIV_USER

2024-05-14 Thread Helge Deller
* Richard Henderson : > The kernel does this along the return path to user mode. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > linux-user/hppa/target_cpu.h | 4 ++-- > target/hppa/cpu.h| 3 +++ > linux-user/elfload.c | 4 ++--

Re: [PATCH v2 30/45] target/hppa: Use delay_excp for conditional trap on overflow

2024-05-14 Thread Helge Deller
eletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 29/45] target/hppa: Use delay_excp for conditional traps

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > target/hppa/helper.h | 1 - > target/hppa/int_helper.c | 2 +- > target/hppa/op_helper.c | 7 --- > target/hppa/translate.c | 41 ++-- > 4

Re: [PATCH v2 28/45] target/hppa: Introduce DisasDelayException

2024-05-14 Thread Helge Deller
rget/hppa/translate.c | 60 + > 1 file changed, 55 insertions(+), 5 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 27/45] target/hppa: Remove cond_free

2024-05-14 Thread Helge Deller
tions do the right thing with c or cf == 0, > so there's no need for a special case anymore. > > Signed-off-by: Richard Henderson > --- > target/hppa/translate.c | 102 +++- > 1 file changed, 27 insertions(+), 75 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 26/45] target/hppa: Use TCG_COND_TST* in trans_ftest

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson > --- > target/hppa/translate.c | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) Reviewed-by: Helge Deller

Re: [PATCH v2 25/45] target/hppa: Use registerfields.h for FPSR

2024-05-14 Thread Helge Deller
* Richard Henderson : > Define all of the context dependent field definitions. > Use FIELD_EX32 and FIELD_DP32 with named fields instead > of extract32 and deposit32 with raw constants. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/h

Re: [PATCH v2 24/45] target/hppa: Use TCG_COND_TST* in trans_bb_imm

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 12 +++- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/target/hppa/translate.c b/target/hppa/translate.c > index 47f4b23d

Re: [PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 22/45] target/hppa: Use TCG_COND_TST* in do_unit_zero_cond

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 21/45] target/hppa: Use TCG_COND_TST* in do_log_cond

2024-05-14 Thread Helge Deller
* Richard Henderson : > We can directly test bits of a 32-bit comparison without > zero or sign-extending an intermediate result. > We can directly test bit 0 for odd/even. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 20/45] target/hppa: Use TCG_COND_TST* in do_cond

2024-05-14 Thread Helge Deller
* Richard Henderson : > We can directly test bits of a 32-bit comparison without > zero or sign-extending an intermediate result. > We can directly test bit 0 for odd/even. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 19/45] target/hppa: Rename cond_make_* helpers

2024-05-14 Thread Helge Deller
make_ti >cond_make_0 -> cond_make_vi >cond_make -> cond_make_vv > > Pass 0 explictly, rather than implicitly in the function name. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 18/45] target/hppa: Use displacements in DisasIAQE

2024-05-14 Thread Helge Deller
* Richard Henderson : > This is a first step in enabling CF_PCREL, but for now > we regenerate the absolute address before writeback. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 17/45] target/hppa: Introduce and use DisasIAQE for branch management

2024-05-14 Thread Helge Deller
* Richard Henderson : > Wrap offset and space together in one structure, ensuring > that they're copied together as required. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 08/45] target/hppa: Add install_link

2024-05-14 Thread Helge Deller
On 5/14/24 16:37, Helge Deller wrote: * Richard Henderson : Add a common routine for writing the return address. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- target/hppa/translate.c | 54 +++-- 1 file changed, 31 insertions(+), 23

Re: [PATCH v2 14/45] target/hppa: Add space argument to do_ibranch

2024-05-14 Thread Helge Deller
* Richard Henderson : > This allows unification of BE, BLR, BV, BVE with a common helper. > Since we can now track space with IAQ_Next, we can now let the > TranslationBlock continue across the delay slot with BE, BVE. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 13/45] target/hppa: Add space arguments to install_iaq_entries

2024-05-14 Thread Helge Deller
* Richard Henderson : > Move space assighments to a central location. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 58 +++-- > 1 file changed, 27 insertions(+), 31 deletions(-) >

Re: [PATCH v2 12/45] target/hppa: Add IASQ entries to DisasContext

2024-05-14 Thread Helge Deller
* Richard Henderson : > Add variable to track space changes to IAQ. So far, no such changes > are introduced, but the new checks vs ctx->iasq_b may eliminate an > unnecessary copy to cpu_iasq_f with e.g. BLR. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller

Re: [PATCH v2 11/45] target/hppa: Simplify TB end

2024-05-14 Thread Helge Deller
* Richard Henderson : > Minimize the amount of code in hppa_tr_translate_insn advancing the > insn queue for the next insn. Move the goto_tb path to hppa_tr_tb_stop. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa

Re: [PATCH v2 10/45] target/hppa: Skip nullified insns in unconditional dbranch path

2024-05-14 Thread Helge Deller
* Richard Henderson : > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/target/hppa/translate.c b/target/hppa/translate.c > index a9196050

Re: [PATCH v2 09/45] target/hppa: Delay computation of IAQ_Next

2024-05-14 Thread Helge Deller
* Richard Henderson : > We no longer have to allocate a temp and perform an > addition before translation of the rest of the insn. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 26 ++ > 1 file c

Re: [PATCH v2 08/45] target/hppa: Add install_link

2024-05-14 Thread Helge Deller
* Richard Henderson : > Add a common routine for writing the return address. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 54 +++-- > 1 file changed, 31 insertions(+), 23 deletions(

Re: [PATCH v2 07/45] target/hppa: Add install_iaq_entries

2024-05-14 Thread Helge Deller
* Richard Henderson : > Instead of two separate cpu_iaoq_entry calls, use one call to update > both IAQ_Front and IAQ_Back. Simplify with an argument combination > that automatically handles a simple increment from Front to Back. > > Signed-off-by: Richard Henderson Reviewed-b

Re: [PATCH v2 06/45] target/hppa: Use CF_BP_PAGE instead of cpu_breakpoint_test

2024-05-14 Thread Helge Deller
* Richard Henderson : > The generic tcg driver will have already checked for breakpoints. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/t

Re: [PATCH v2 05/45] target/hppa: Allow prior nullification in do_ibranch

2024-05-14 Thread Helge Deller
* Richard Henderson : > Simplify the function by not attempting a conditional move > on the branch destination -- just use nullify_over normally. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 73 +++-

Re: [PATCH v2 04/45] target/hppa: Pass displacement to do_dbranch

2024-05-14 Thread Helge Deller
means that > we will *not* use a goto_tb. Use a plain indirect branch instead, > which is what we got out of the attempted direct branch anyway. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 33 +---

Re: [PATCH v2 03/45] target/hppa: Move constant destination check into use_goto_tb

2024-05-14 Thread Helge Deller
* Richard Henderson : > Share this check between gen_goto_tb and hppa_tr_translate_insn. > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller > --- > target/hppa/translate.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > >

Re: [PATCH v2 02/45] target/hppa: Use hppa_form_gva_psw in hppa_cpu_get_pc

2024-05-14 Thread Helge Deller
* Richard Henderson : > This function is for log_pc(), which needs to produce a > similar result to cpu_get_tb_cpu_state(). > > Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- > --- > target/hppa/cpu.c | 8 > 1 file changed, 4 insertions(+), 4 d

Re: [PATCH v2 00/45] target/hppa: Misc improvements

2024-05-14 Thread Helge Deller
On 5/13/24 09:46, Richard Henderson wrote: Most of the patches lead up to implementing CF_PCREL. Along the way there is a grab bag of code updates (TCG_COND_TST*), bug fixes (space changes during branch-in-branch-delay-slot), and implementation of features (PSW bits B, X, T, H, L). Sven

Re: [PATCH v2 01/45] target/hppa: Move cpu_get_tb_cpu_state out of line

2024-05-14 Thread Helge Deller
On 5/13/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- target/hppa/cpu.h | 43 ++- target/hppa/cpu.c | 42 ++ 2 files changed, 44 insertions(+), 41

Re: [PATCH 00/45] target/hppa: Misc improvements

2024-05-13 Thread Helge Deller
target/hexagon/gen_idef_parser_funcs.py HPPA (PA-RISC) TCG CPUs M: Richard Henderson +R: Helge Deller +R: Sven Schnelle S: Maintained F: target/hppa/ F: disas/hppa.c @@ -1214,6 +1216,7 @@ HP-PARISC Machines HP B160L, HP C3700 M: Richard Henderson R: Helge Deller +R: Sven Schnelle

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Helge Deller
On 4/23/24 17:10, Daniel P. Berrangé wrote: On Tue, Apr 23, 2024 at 05:07:17PM +0200, Helge Deller wrote: On 4/23/24 16:58, Cole Robinson wrote: On 4/23/24 10:11 AM, Cole Robinson wrote: Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Helge Deller
On 4/23/24 16:58, Cole Robinson wrote: On 4/23/24 10:11 AM, Cole Robinson wrote: Hi, hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF build-id annotations. rpm builds on Fedora will error if an ELF binary doesn't have build-id: RPM build errors: Missing build-id in

Re: [PATCH] target/hppa: Fix IIAOQ, IIASQ for pa2.0

2024-04-03 Thread Helge Deller
y: Richard Henderson Tested-by: Helge Deller Helge --- Sven, I looked again through IIAOQ documentation and it does seem like some of the bits are wrong, both on interrupt delivery and RFI. r~ --- target/hppa/int_helper.c | 20 +++- target/hppa/sys_helper.c | 18

Re: [PATCH 2/3] target/hppa: mask offset bits in gva

2024-04-02 Thread Helge Deller
On 4/2/24 08:29, Sven Schnelle wrote: Richard Henderson writes: On 4/1/24 20:01, Sven Schnelle wrote: Implement dr2 and the mfdiag/mtdiag instructions. dr2 contains a bit which enables/disables space id hashing. Seabios would then set this bit when booting. Linux would disable it again

Re: [PATCH v2 3/3] target/hppa: Fix diag instructions to set/restore shadow registers

2024-03-26 Thread Helge Deller
diag instructions to save or restore the CPU registers to/from the shadow registers. Implement those per-CPU architecture diag instructions to fix those parts of the HP ODE testcases (L2DIAG and WDIAG, section 1) which test the shadow registers. Signed-off-by: Helge Deller [rth: Use decodetree

Re: [PATCH v2 1/3] target/hppa: Generate getshadowregs inline

2024-03-26 Thread Helge Deller
On 3/26/24 19:10, Richard Henderson wrote: This operation is trivial and does not require a helper. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/helper.h | 1 - target/hppa/sys_helper.c | 4 ++-- target/hppa/translate.c | 17

Re: [PATCH v2 2/3] target/hppa: Move diag argument handling to decodetree

2024-03-26 Thread Helge Deller
On 3/26/24 19:10, Richard Henderson wrote: Split trans_diag into per-operation functions. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/insns.decode | 8 +++- target/hppa/translate.c | 34 +- 2 files changed, 28

Re: [PATCH for-9.0 0/3] target/hppa: Fix overflow computation for shladd

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: These ??? notes have been there since day one. This fixes l2diag test 59. Your patches fix the 64-bit wdiag test 66 (shladd) too. I tested 32/64-bit Linux & 32-bit HP-UX. No regressions. Helge Richard Henderson (3): target/hppa: Squash d for

Re: [PATCH 3/3] target/hppa: Fix overflow computation for shladd

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: Overflow indicator should include the effect of the shift step. We had previously left ??? comments about the issue. Signed-off-by: Richard Henderson Tested-by: Helge Deller Helge --- target/hppa/translate.c | 85

Re: [PATCH 2/3] target/hppa: Replace c with uv in do_cond

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: Prepare for proper indication of shladd unsigned overflow. The UV indicator will be zero/not-zero instead of a single bit. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Helge --- target/hppa/translate.c

Re: [PATCH 1/3] target/hppa: Squash d for pa1.x during decode

2024-03-26 Thread Helge Deller
On 3/26/24 07:44, Richard Henderson wrote: The cond_need_ext predicate was created while we still had a 32-bit compilation mode. It now makes more sense to treat D as an absolute indicator of a 64-bit operation. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge

[PATCH] target/hppa: Fix diag instructions to set/restore shadow registers

2024-03-25 Thread Helge Deller
the shadow registers. Signed-off-by: Helge Deller diff --git a/target/hppa/helper.h b/target/hppa/helper.h index 8fd7ba65d8..2c5d58bec9 100644 --- a/target/hppa/helper.h +++ b/target/hppa/helper.h @@ -86,6 +86,7 @@ DEF_HELPER_FLAGS_0(read_interval_timer, TCG_CALL_NO_RWG, tl) #ifndef CONFIG_USER_ONLY

Re: [PATCH v2] target/hppa: Fix unit carry conditions

2024-03-25 Thread Helge Deller
bits for add and subtract, mirroring the code in do_add and do_sub. Signed-off-by: Richard Henderson this patch does not break test #55 (uaddcm) any longer, and with the other two patches test #58 (uaddcm & dcor) is OK as well. So, for the whole series: Reviewed-by: Helge Deller Tested-by: H

Re: [PATCH 3/3] target/hppa: Fix unit carry conditions

2024-03-25 Thread Helge Deller
On 3/25/24 04:04, Richard Henderson wrote: Split do_unit_cond to do_unit_zero_cond to only handle conditions versus zero. These are the only ones that are legal for UXOR. Simplify trans_uxor accordingly. Rename do_unit to do_unit_addsub, since xor has been split. Properly compute carry-out

Re: [PATCH 2/3] target/hppa: Optimize UADDCM with no condition

2024-03-25 Thread Helge Deller
-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Helge --- target/hppa/translate.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index a3f425d861..3fc3e7754c 100644

Re: [PATCH 1/3] targt/hppa: Fix DCOR reconstruction of carry bits

2024-03-25 Thread Helge Deller
shift-right to reassemble into a single word and place them all at bit 0 of their respective nibbles. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Helge --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH][RFC] target/hppa: Avoid nullification for uaddcmt instruction

2024-03-24 Thread Helge Deller
On 3/24/24 18:13, Richard Henderson wrote: On 3/23/24 11:15, Helge Deller wrote: The uaddcmt (UNIT ADD COMPLEMENT AND TRAP ON CONDITION) instruction triggers a trap if the condition is true, and stores the result of the addition in the target register otherwise. It does not use the condition

Re: [PATCH 3/3] target/hppa: fix building gva for wide mode

2024-03-24 Thread Helge Deller
-by: Sven Schnelle Reviewed-by: Helge Deller Tested-by: Helge Deller Helge --- target/hppa/mem_helper.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index 84785b5a5c..6f895fced7 100644 --- a/target/hppa

Re: [PATCH 2/3] target/hppa: mask offset bits in gva

2024-03-24 Thread Helge Deller
existing 32- and 64-bit Linux installations, so: Tested-by: Helge Deller Thanks! Helge --- target/hppa/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index a072d0bb63..9bc4d208fa 100644 --- a/target/hppa/cpu.h +++ b/target/hppa

Re: [PATCH 1/3] target/hppa: use gva_offset_mask() everywhere

2024-03-24 Thread Helge Deller
On 3/24/24 09:09, Sven Schnelle wrote: move it to cpu.h, so it can also be used in hppa_form_gva_psw() Signed-off-by: Sven Schnelle Reviewed-by: Helge Deller Helge --- target/hppa/cpu.h | 10 -- target/hppa/translate.c | 12 +++- 2 files changed, 11 insertions

[PATCH][RFC] target/hppa: Avoid nullification for uaddcmt instruction

2024-03-23 Thread Helge Deller
not install it as null_cond. This patch is not tested and as such sent as RFC. I just stumbled over the apparently wrong behaviour while debugging the uaddcm instruction. Signed-off-by: Helge Deller diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 46b2d6508d..6088e9bbf3 100644

Re: [PATCH v2 7/7] target/hppa: Fix EIRR, EIEM versus icount

2024-03-23 Thread Helge Deller
On 3/23/24 18:29, Richard Henderson wrote: Call translator_io_start before write to EIRR. Move evaluation of EIRR vs EIEM to hppa_cpu_exec_interrupt. Exit TB after write to EIEM, but otherwise use a straight store. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge

Re: [PATCH v2 5/7] target/hppa: Mark interval timer write as io

2024-03-23 Thread Helge Deller
On 3/23/24 18:29, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Thanks! Helge --- target/hppa/translate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

Re: [PATCH v2 6/7] target/hppa: Tidy read of interval timer

2024-03-23 Thread Helge Deller
On 3/23/24 18:29, Richard Henderson wrote: The call to gen_helper_read_interval_timer is identical on both sides of the IF. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Tested-by: Helge Deller Thanks! Helge --- target/hppa/translate.c | 4 +--- 1 file changed, 1

Re: [PATCH v2 1/7] target/hppa: Fix BE,L set of sr0

2024-03-23 Thread Helge Deller
On 3/23/24 18:29, Richard Henderson wrote: The return address comes from IA*Q_Next, and IASQ_Next is always equal to IASQ_Back, not IASQ_Front. Signed-off-by: Richard Henderson Tested-by: Helge Deller --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 2/2] target/hppa: Fix B,GATE for wide mode

2024-03-22 Thread Helge Deller
On 3/21/24 20:28, Richard Henderson wrote: Do not clobber the high bits of the address by using a 32-bit deposit. Signed-off-by: Richard Henderson Reviewed-by: Helge Deller Helge --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target

Re: [PULL 0/9] target/hppa fixes for 9.0

2024-03-21 Thread Helge Deller
On 3/21/24 19:25, Sven Schnelle wrote: Michael Tokarev writes: 20.03.2024 03:32, Richard Henderson : Richard Henderson (3): target/hppa: Fix assemble_16 insns for wide mode target/hppa: Fix assemble_11a insns for wide mode target/hppa: Fix assemble_12a insns for wide

Re: [PATCH 6/7] target/hppa: mask privilege bits in mfia

2024-03-18 Thread Helge Deller
On 3/17/24 23:14, Sven Schnelle wrote: mfia should return only the iaoq bits without privilege bits. Signed-off-by: Sven Schnelle Reviewed-by: Helge Deller Helge --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b

Re: [PATCH 4/7] target/hppa: exit tb on flush cache instructions

2024-03-18 Thread Helge Deller
AQ_N_STALE; I wonder if it makes sense to rename trans_nop() and trans_nop_addrx() to something like trans_cache_flush() and trans_cache_flush_addrx() ? Other than that: Reviewed-by: Helge Deller Helge

Re: [PATCH 3/7] target/hppa: fix access_id check

2024-03-18 Thread Helge Deller
On 3/17/24 23:14, Sven Schnelle wrote: PA2.0 provides 8 instead of 4 PID registers. Signed-off-by: Sven Schnelle Reviewed-by: Helge Deller with a few comments below... Helge --- roms/SLOF| 2 +- target/hppa/mem_helper.c | 67

Re: [PATCH 2/7] target/hppa: fix shrp for wide mode

2024-03-18 Thread Helge Deller
On 3/17/24 23:14, Sven Schnelle wrote: Signed-off-by: Sven Schnelle Reviewed-by: Helge Deller Helge --- target/hppa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6a513d7d5c..8ba31567e8 100644

Re: [PATCH v2 1/3] target/hppa: Fix assemble_16 insns for wide mode

2024-03-18 Thread Helge Deller
On 3/13/24 23:51, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson Reviewed-by: Helge Deller --- target/hppa/insns.decode | 15 +-- target/hppa/translate.c | 22 ++ 2 files changed, 31 insertions(+), 6 deletions

Re: [PATCH v3] hw/scsi/lsi53c895a: add timer to scripts processing

2024-03-10 Thread Helge Deller
On 3/10/24 16:35, Michael Tokarev wrote: 04.03.2024 19:37, Sven Schnelle : HP-UX 10.20 seems to make the lsi53c895a spinning on a memory location under certain circumstances. As the SCSI controller and CPU are not running at the same time this loop will never finish. After some time, the check

Re: [PATCH 1/4] disas: introduce no_raw_bytes

2024-03-04 Thread Helge Deller
On 3/4/24 20:13, Alex Bennée wrote: For plugins we don't expect the raw bytes in the disassembly. We already deal with this by hand crafting our capstone call but for other diassemblers we need a flag. Signed-off-by: Alex Bennée --- include/disas/dis-asm.h | 7 +++ disas/disas.c

Re: [PATCH 3/3] target/hppa: Fix assemble_12a insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson Tested-by: Helge Deller --- target/hppa/insns.decode | 27 --- target/hppa/translate.c | 17 + 2 files changed, 33 insertions(+), 11 deletions

Re: [PATCH 2/3] target/hppa: Fix assemble_11a insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 07:52, Helge Deller wrote: On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson ---   target/hppa/insns.decode |  7 ---   target/hppa/translate.c  | 23 +--   2 files changed, 21 insertions(+), 9 deletions

Re: [PATCH 2/3] target/hppa: Fix assemble_11a insns for wide mode

2024-03-02 Thread Helge Deller
static int expand_shl11(DisasContext *ctx, int val) { @@ -144,6 +138,23 @@ static int assemble_6(DisasContext *ctx, int val) return (val ^ 31) + 1; } +/* Expander for assemble_16a(s,cat(im10a,0),i). */ Typo above, should be assemble_11a(). Otherwise: Tested-by: Helge Deller Reviewed-by:

Re: [PATCH 1/3] target/hppa: Fix assemble_16 insns for wide mode

2024-03-02 Thread Helge Deller
On 3/3/24 03:19, Richard Henderson wrote: Reported-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 15 +-- target/hppa/translate.c | 21 + 2 files changed, 30 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 1/5] target/hppa: Fix unaligned double word accesses for hppa64

2024-03-02 Thread Helge Deller
("target/hppa: Update cpu_hppa_get/put_psw for hppa64") Cc: Richard Henderson Cc: Charlie Jenkins Cc: Helge Deller Signed-off-by: Guenter Roeck Reviewed-by: Richard Henderson ---   target/hppa/helper.c | 7 ++-   1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/hpp

Re: [PATCH] hw/scsi/lsi53c895a: stop script on phase mismatch

2024-03-02 Thread Helge Deller
lsi_bad_phase() didn't trigger a host interrupt. Signed-off-by: Sven Schnelle Tested-by: Helge Deller Helge --- hw/scsi/lsi53c895a.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 4ff9470381..59b88aff3f 100644

Re: [RFC PATCH] disas/hppa: drop raw opcode dump

2024-02-29 Thread Helge Deller
. For the sake of consistently just present the instruction assembly code. Signed-off-by: Alex Bennée This effectively reverts commit 2f926bfd5b79e6219ae65a1e530b38f37d62b384 ("disas/hppa: Show hexcode of instruction along with disassembly"). Sad, but Ok. Acked-by: Helge Deller -

Re: [PATCH] target: hppa: Fix unaligned double word accesses for hppa64

2024-02-15 Thread Helge Deller
("target/hppa: Update cpu_hppa_get/put_psw for hppa64") Cc: Richard Henderson Cc: Charlie Jenkins Cc: Helge Deller Signed-off-by: Guenter Roeck --- target/hppa/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/hppa/helper.c b/target/hppa/help

Re: [PULL 00/12] Hppa64 patches

2024-02-14 Thread Helge Deller
On 2/14/24 10:07, Michael Tokarev wrote: 13.02.2024 22:16, Helge Deller: On 2/13/24 19:09, Michael Tokarev wrote: 13.02.2024 02:47, del...@kernel.org: Helge Deller (11):    disas/hppa: Add disassembly for qemu specific instructions    target/hppa: Add "diag 0x101" for console outp

Re: [PULL 00/12] Hppa64 patches

2024-02-13 Thread Helge Deller
On 2/13/24 19:09, Michael Tokarev wrote: 13.02.2024 02:47, del...@kernel.org пишет: From: Helge Deller The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:    Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +

Re: [PULL 00/12] Hppa64 patches

2024-02-13 Thread Helge Deller
On 2/13/24 10:10, Peter Maydell wrote: On Mon, 12 Feb 2024 at 23:04, Helge Deller wrote: On 2/12/24 22:16, Peter Maydell wrote: This fails "make check", eg: https://gitlab.com/qemu-project/qemu/-/jobs/6154451100 because when the qom-test etc tests run qemu-system-hppa, it barfs

Re: [PULL 11/12] target/hppa: Update SeaBIOS-hppa to version 16

2024-02-12 Thread Helge Deller
On 2/11/24 19:49, Michael Tokarev wrote: 11.02.2024 15:29, del...@kernel.org From: Helge Deller SeaBIOS-hppa version 16 news & enhancements:   pc-bios/hppa-firmware.img   | Bin 163324 -> 167820 bytes   pc-bios/hppa-firmware64.img | Bin 0 -> 206024 bytes   roms/seabios-hppa  

Re: [PULL 00/12] Hppa64 patches

2024-02-12 Thread Helge Deller
On 2/12/24 22:16, Peter Maydell wrote: On Sun, 11 Feb 2024 at 12:30, wrote: From: Helge Deller The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440: Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +

Re: [PATCH] hw/hppa/Kconfig: Fix building with "configure --without-default-devices"

2024-02-09 Thread Helge Deller
NO select LASI -select SERIAL +select SERIAL_PCI I think the "SERIAL" is needed too for the B160L machine. Other than that, Acked-by: Helge Deller Thank you! Helge select ISA_BUS select I8259 select IDE_CMD646 @@ -16,3 +16,4 @@ config HPPA_B160L

Re: [PATCH] hw/net/tulip: add chip status register values

2024-02-09 Thread Helge Deller
On 2/6/24 23:33, Helge Deller wrote: On 2/5/24 20:47, Sven Schnelle wrote: Netbsd isn't able to detect a link on the emulated tulip card. That's because netbsd reads the Chip Status Register of the Phy (address 0x14). The default phy data in the qemu tulip driver is all zero, which means

Re: [PATCH 03/13] target/hppa: Fix PSW_W and PSW_E bits in rsm, ssm and mtsm

2024-02-09 Thread Helge Deller
On 2/8/24 21:43, Richard Henderson wrote: On 2/7/24 08:20, del...@kernel.org wrote:   #define PSW_E    0x0400 +#define PSW_E_BIT    37 /* PA2.0 only */   #define PSW_W    0x0800 /* PA2.0 only */ +#define PSW_W_BIT    36 /* PA2.0 only */ ...

Re: [PATCH] hw/net/tulip: add chip status register values

2024-02-06 Thread Helge Deller
isn't complete. Therefore set the register to 0x3b40, which means: Link is up, Autonegotation complete, Full Duplex, 100MBit/s Link speed. Also clear the mask because this register is read only. Signed-off-by: Sven Schnelle Reviewed-by: Helge Deller Tested-by: Helge Deller Can be easily

Re: [PULL 02/10] hw/hppa/machine: Disable default devices with --nodefaults option

2024-02-02 Thread Helge Deller
On 2/2/24 19:04, Guenter Roeck wrote: On Fri, Feb 02, 2024 at 10:54:20AM +0100, Helge Deller wrote: Hi Guenter, On 2/2/24 05:22, Guenter Roeck wrote: On Sat, Jan 13, 2024 at 06:57:20AM +0100, del...@kernel.org wrote: From: Helge Deller Recognize the qemu --nodefaults option, which

Re: [PULL 02/10] hw/hppa/machine: Disable default devices with --nodefaults option

2024-02-02 Thread Helge Deller
Hi Guenter, On 2/2/24 05:22, Guenter Roeck wrote: On Sat, Jan 13, 2024 at 06:57:20AM +0100, del...@kernel.org wrote: From: Helge Deller Recognize the qemu --nodefaults option, which will disable the following default devices on hppa: - lsi53c895a SCSI controller, - artist graphics card

Re: [PATCH] linux-user: Make TARGET_NR_setgroups affect only the current thread

2024-01-30 Thread Helge Deller
On 1/31/24 01:18, Ilya Leoshkevich wrote: Like TARGET_NR_setuid, TARGET_NR_setgroups should affect only the calling thread, and not the entire process. Therefore, implement it using a syscall, and not a libc call. Cc: qemu-sta...@nongnu.org Fixes: 19b84f3c35d7 ("added setgroups and getgroups

Re: [PATCH] hw/scsi/lsi53c895a: add missing decrement of reentrancy counter

2024-01-30 Thread Helge Deller
the limit. This bug was seen on HP-UX 10.20 which seems to trigger SCRIPTS loops. Fixes: b987718bbb ("hw/scsi/lsi53c895a: Fix reentrancy issues in the LSI controller (CVE-2023-0330)") Signed-off-by: Sven Schnelle Tested-by: Helge Deller Thanks! Helge --- hw/scsi/lsi53c895a.c

Re: [PATCH 09/33] target/hppa: Populate CPUClass.mmu_index

2024-01-29 Thread Helge Deller
On 1/30/24 00:30, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/cpu.h | 7 ++- target/hppa/cpu.c | 12 2 files changed, 14 insertions(+), 5 deletions(-) Reviewed-by: Helge Deller diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index

  1   2   3   4   5   6   7   8   9   >