Re: [PATCH v6 3/5] Update subprojects/libvfio-user

2024-01-09 Thread Jag Raman
> On Nov 1, 2023, at 9:16 AM, Mattias Nissler wrote: > > Brings in assorted bug fixes. The following are of particular interest > with respect to message-based DMA support: > > * bb308a2 "Fix address calculation for message-based DMA" > Corrects a bug in DMA address calculation. > > *

Re: [PATCH v6 5/5] vfio-user: Fix config space access byte order

2023-11-28 Thread Jag Raman
> On Nov 1, 2023, at 9:16 AM, Mattias Nissler wrote: > > PCI config space is little-endian, so on a big-endian host we need to > perform byte swaps for values as they are passed to and received from > the generic PCI config space access machinery. > > Signed-off-by: Mattias Nissler

Re: [PATCH v6 4/5] vfio-user: Message-based DMA support

2023-11-28 Thread Jag Raman
> On Nov 1, 2023, at 9:16 AM, Mattias Nissler wrote: > > Wire up support for DMA for the case where the vfio-user client does not > provide mmap()-able file descriptors, but DMA requests must be performed > via the VFIO-user protocol. This installs an indirect memory region, > which already

Re: [PATCH v5 5/5] vfio-user: Fix config space access byte order

2023-10-05 Thread Jag Raman
> On Sep 20, 2023, at 4:06 AM, Mattias Nissler wrote: > > PCI config space is little-endian, so on a big-endian host we need to > perform byte swaps for values as they are passed to and received from > the generic PCI config space access machinery. > > Signed-off-by: Mattias Nissler > --- >

Re: [PATCH v5 4/5] vfio-user: Message-based DMA support

2023-10-04 Thread Jag Raman
> On Sep 20, 2023, at 4:06 AM, Mattias Nissler wrote: > > Wire up support for DMA for the case where the vfio-user client does not > provide mmap()-able file descriptors, but DMA requests must be performed > via the VFIO-user protocol. This installs an indirect memory region, > which already

Re: [PATCH 0/1] update maintainers list for vfio-user & multi-process QEMU

2023-06-07 Thread Jag Raman
> On Jun 7, 2023, at 12:44 PM, Stefan Hajnoczi wrote: > > On Wed, 7 Jun 2023 at 11:58, Jagannathan Raman wrote: >> >> John Johnson doesn't work at Oracle anymore. I tried to contact him to >> get his updated email address, but I haven't heard anything from him. >> >> Jagannathan Raman (1):

Re: Machine x-remote property auto-shutdown

2023-05-08 Thread Jag Raman
Hi Markus, Please see the comments inline below. > On May 5, 2023, at 10:58 AM, Markus Armbruster wrote: > > I stumbled over this property, looked closer, and now I'm confused. > > Like most QOM properties, x-remote.auto-shutdown is virtually > undocumented. All we have is this comment in

Re: [PATCH] hw/remote: Fix vfu_cfg trace offset format

2023-04-26 Thread Jag Raman
Thank you! > On Apr 26, 2023, at 5:35 AM, Mattias Nissler wrote: > > The printed offset value is prefixed with 0x, but was actually printed > in decimal. To spare others the confusion, adjust the format specifier > to hexadecimal. > > Signed-off-by: Mattias Nissler Reviewed-by: Jagannathan

Re: [PATCH 0/1] Update vfio-user module to the latest

2022-09-29 Thread Jag Raman
> On Sep 29, 2022, at 2:27 AM, Thomas Huth wrote: > > On 29/09/2022 03.52, Jag Raman wrote: >>> On Aug 29, 2022, at 8:40 AM, Thomas Huth wrote: >>> >>> On 07/08/2022 12.39, John Levon wrote: >>>> On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel

Re: [PATCH 0/1] Update vfio-user module to the latest

2022-09-28 Thread Jag Raman
> On Aug 29, 2022, at 8:40 AM, Thomas Huth wrote: > > On 07/08/2022 12.39, John Levon wrote: >> On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel P. Berrangé wrote: > [...] >>> If we do add something as a submodule for some reason, I'd like us to >>> say upfront that this is for a fixed time

Re: [PATCH 0/1] Update vfio-user module to the latest

2022-08-26 Thread Jag Raman
On Aug 7, 2022, at 6:39 AM, John Levon mailto:le...@movementarian.org>> wrote: On Fri, Aug 05, 2022 at 09:24:56AM +0100, Daniel P. Berrangé wrote: For the RFC QEMU user space eBPF support, https://lore.kernel.org/all/20220617073630.535914-6-chen.zh...@intel.com/T/ Maybe introduce the

Re: libvfio-user test-client-server test hanging in the CI

2022-08-25 Thread Jag Raman
On Aug 25, 2022, at 3:54 PM, Thomas Huth mailto:th...@redhat.com>> wrote: Hi Elena, Jagannathan & John! I noticed that the libvfio-user test-client-server test is recently hanging in the check-system-centos jobs in QEMU's gitlab-CI. Normally the test finishes within 20 minutes, see e.g.

Re: [PULL 06/18] vfio-user: build library

2022-07-25 Thread Jag Raman
> On Jul 25, 2022, at 10:50 AM, Daniel P. Berrangé wrote: > > On Mon, Jul 25, 2022 at 02:45:09PM +0000, Jag Raman wrote: >> Hi Daniel, >> >> We’ve created the following issue to update QEMU’s libvfio-user mirror >> to the latest: >> https://gitlab.c

Re: [PULL 06/18] vfio-user: build library

2022-07-25 Thread Jag Raman
Hi Daniel, We’ve created the following issue to update QEMU’s libvfio-user mirror to the latest: https://gitlab.com/qemu-project/libvfio-user/-/issues/1 Will update QEMU’s submodule once this mirror is updated. Thank you! -- Jag On Jul 21, 2022, at 6:25 AM, Daniel P. Berrangé

Re: [PULL 06/18] vfio-user: build library

2022-07-12 Thread Jag Raman
> On Jul 12, 2022, at 11:44 AM, Daniel P. Berrangé wrote: > > On Tue, Jul 12, 2022 at 03:27:09PM +0000, Jag Raman wrote: >> >> >> On Jul 12, 2022, at 4:39 AM, Daniel P. Berrangé >> mailto:berra...@redhat.com>> wrote: >> >> On Wed, Jun

Re: [PULL 06/18] vfio-user: build library

2022-07-12 Thread Jag Raman
On Jul 12, 2022, at 4:39 AM, Daniel P. Berrangé mailto:berra...@redhat.com>> wrote: On Wed, Jun 15, 2022 at 04:51:17PM +0100, Stefan Hajnoczi wrote: From: Jagannathan Raman mailto:jag.ra...@oracle.com>> add the libvfio-user library as a submodule. build it as a meson subproject. libvfio-user

Re: [PATCH v12 00/14] vfio-user server in QEMU

2022-06-14 Thread Jag Raman
> On Jun 14, 2022, at 3:06 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 13, 2022 at 04:26:20PM -0400, Jagannathan Raman wrote: >> This is v12 of the server side changes to enable vfio-user in QEMU. >> >> Thanks so much for reviewing this series and sharing your feedback. >> >> We made the

Re: [PATCH v10 13/14] vfio-user: handle device interrupts

2022-06-06 Thread Jag Raman
> On Jun 6, 2022, at 2:32 PM, Alexander Duyck wrote: > > On Tue, May 24, 2022 at 9:11 AM Jagannathan Raman > wrote: >> >> Forward remote device's interrupts to the guest >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >>

Re: about the current status of Multi-process QEMU / out-of-process emulation

2022-06-03 Thread Jag Raman
On Jun 3, 2022, at 11:34 AM, Yu Zhang mailto:yu.zh...@ionos.com>> wrote: Hello Dongli, Elena, John, and Jagannathan, I'm interested in the "multi-process QEMU" feature and got the kind reply by Mr. Vivier that I may contact you for this. On one of the QEMU docs [1] I saw the command line: +

Re: [PATCH v10 13/14] vfio-user: handle device interrupts

2022-06-01 Thread Jag Raman
On Jun 1, 2022, at 2:30 PM, Alex Williamson mailto:alex.william...@redhat.com>> wrote: On Wed, 1 Jun 2022 18:01:39 +0000 Jag Raman mailto:jag.ra...@oracle.com>> wrote: On Jun 1, 2022, at 1:26 PM, Alex Williamson mailto:alex.william...@redhat.com>> wrote: On Wed, 1 Jun 2

Re: [PATCH v10 13/14] vfio-user: handle device interrupts

2022-06-01 Thread Jag Raman
> On Jun 1, 2022, at 1:26 PM, Alex Williamson > wrote: > > On Wed, 1 Jun 2022 17:00:54 + > Jag Raman wrote: >> >> Hi Alex, >> >> Just to add some more detail, the emulated PCI device in QEMU presently >> maintains a MSIx table

Re: [PATCH v10 13/14] vfio-user: handle device interrupts

2022-06-01 Thread Jag Raman
May 2022 15:01:57 + Jag Raman mailto:jag.ra...@oracle.com>> wrote: On May 25, 2022, at 10:53 AM, Stefan Hajnoczi mailto:stefa...@redhat.com>> wrote: On Tue, May 24, 2022 at 11:30:32AM -0400, Jagannathan Raman wrote: Forward remote device's interrupts to the guest

Re: [PATCH v10 13/14] vfio-user: handle device interrupts

2022-05-31 Thread Jag Raman
> On May 25, 2022, at 10:53 AM, Stefan Hajnoczi wrote: > > On Tue, May 24, 2022 at 11:30:32AM -0400, Jagannathan Raman wrote: >> Forward remote device's interrupts to the guest >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> ---

Re: [RFC PATCH] mpqemu: Remove unlock/lock of iothread in mpqemu-link send and recv functions

2022-05-23 Thread Jag Raman
> On May 23, 2022, at 11:09 AM, Alexander Duyck > wrote: > > From: Alexander Duyck > > When I run Multi-process QEMU with an e1000 as the remote device and SMP > enabled I see the combination lock up and become unresponsive. The QEMU build > is a fairly standard x86_64-softmmu setup. After

Re: [PATCH v9 06/17] vfio-user: build library

2022-05-10 Thread Jag Raman
> On May 10, 2022, at 9:22 AM, Daniel P. Berrangé wrote: > > On Thu, May 05, 2022 at 05:17:01PM +0100, Peter Maydell wrote: >> On Thu, 5 May 2022 at 16:44, Stefan Hajnoczi wrote: >>> >>> On Tue, May 03, 2022 at 10:16:47AM -0400, Jagannathan Raman wrote: >>> Ubuntu 20.04LTS has CMake 3.16.3:

Re: [PATCH v9 10/17] vfio-user: run vfio-user context

2022-05-07 Thread Jag Raman
> On May 6, 2022, at 1:44 AM, Markus Armbruster wrote: > > Jag Raman writes: > >>> On May 5, 2022, at 10:42 AM, Markus Armbruster wrote: >>> >>> Jag Raman writes: >>> >>>>> On May 5, 2022, at 3:44 AM, Markus Armbruster wrote

Re: [PATCH v9 17/17] vfio-user: avocado tests for vfio-user

2022-05-05 Thread Jag Raman
> On May 5, 2022, at 12:04 PM, Stefan Hajnoczi wrote: > > On Tue, May 03, 2022 at 10:16:58AM -0400, Jagannathan Raman wrote: >> +def launch_client(self, kernel_path, initrd_path, kernel_command_line, >> + machine_type, socket, *opts): >> +client_vm =

Re: [PATCH v9 10/17] vfio-user: run vfio-user context

2022-05-05 Thread Jag Raman
> On May 5, 2022, at 10:42 AM, Markus Armbruster wrote: > > Jag Raman writes: > >>> On May 5, 2022, at 3:44 AM, Markus Armbruster wrote: >>> >>> Jag Raman writes: >>> >>>>> On May 4, 2022, at 7:42 AM, Markus Armbruster wro

Re: [PATCH v9 07/17] vfio-user: define vfio-user-server object

2022-05-05 Thread Jag Raman
> On May 5, 2022, at 11:22 AM, Markus Armbruster wrote: > > Stefan Hajnoczi writes: > >> On Wed, May 04, 2022 at 01:45:07PM +0200, Markus Armbruster wrote: >>> Jagannathan Raman writes: >>> Define vfio-user object which is remote process server for QEMU. Setup object

Re: [PATCH v9 10/17] vfio-user: run vfio-user context

2022-05-05 Thread Jag Raman
> On May 5, 2022, at 3:44 AM, Markus Armbruster wrote: > > Jag Raman writes: > >>> On May 4, 2022, at 7:42 AM, Markus Armbruster wrote: >>> >>> Jagannathan Raman writes: >>> >>>> Setup a handler to run vfio-user context. T

Re: [PATCH v9 10/17] vfio-user: run vfio-user context

2022-05-04 Thread Jag Raman
> On May 4, 2022, at 7:42 AM, Markus Armbruster wrote: > > Jagannathan Raman writes: > >> Setup a handler to run vfio-user context. The context is driven by >> messages to the file descriptor associated with it - get the fd for >> the context and hook up the handler with it >> >>

Re: [PATCH v9 07/17] vfio-user: define vfio-user-server object

2022-05-04 Thread Jag Raman
> On May 4, 2022, at 7:45 AM, Markus Armbruster wrote: > > Jagannathan Raman writes: > >> Define vfio-user object which is remote process server for QEMU. Setup >> object initialization functions and properties necessary to instantiate >> the object >> >> Signed-off-by: Elena Ufimtseva >>

Re: [PATCH v9 00/17] vfio-user server in QEMU

2022-05-04 Thread Jag Raman
> On May 4, 2022, at 7:37 AM, Markus Armbruster wrote: > > Does not apply for me. What's your base? The base I used is f5643914a9e8f79c606a76e6a9d7ea82a3fc3e65. The patchew tool says it was able to apply the patches: https://patchew.org/QEMU/cover.1651586203.git.jag.ra...@oracle.com/ The

Re: [PATCH v9 02/17] qdev: unplug blocker for devices

2022-05-04 Thread Jag Raman
> On May 4, 2022, at 7:13 AM, Markus Armbruster wrote: > > Jagannathan Raman writes: > >> Add blocker to prevent hot-unplug of devices >> >> TYPE_VFIO_USER_SERVER, which is introduced shortly, attaches itself to a >> PCIDevice on which it depends. If the attached PCIDevice gets removed >>

Re: [PATCH v8 13/17] vfio-user: handle DMA mappings

2022-04-26 Thread Jag Raman
> On Apr 25, 2022, at 1:34 PM, Jag Raman wrote: > > > >> On Apr 25, 2022, at 5:56 AM, Stefan Hajnoczi wrote: >> >> On Tue, Apr 19, 2022 at 04:44:18PM -0400, Jagannathan Raman wrote: >>> +static void dma_unregister(vfu_ctx_t *vfu_ctx, vfu_dma_

Re: [PATCH v8 00/17] vfio-user server in QEMU

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 6:32 AM, Stefan Hajnoczi wrote: > > On Tue, Apr 19, 2022 at 04:44:05PM -0400, Jagannathan Raman wrote: >> This is v8 of the server side changes to enable vfio-user in QEMU. >> >> Thank you very much for reviewing the last revision of this series! > > I posted some

Re: [PATCH v8 15/17] vfio-user: handle device interrupts

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 6:27 AM, Stefan Hajnoczi wrote: > > On Tue, Apr 19, 2022 at 04:44:20PM -0400, Jagannathan Raman wrote: >> +static MSIMessage vfu_object_msi_prepare_msg(PCIDevice *pci_dev, >> + unsigned int vector) >> +{ >> +MSIMessage msg;

Re: [PATCH v8 14/17] vfio-user: handle PCI BAR accesses

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 6:05 AM, Stefan Hajnoczi wrote: > > On Tue, Apr 19, 2022 at 04:44:19PM -0400, Jagannathan Raman wrote: >> +static size_t vfu_object_bar_rw(PCIDevice *pci_dev, int pci_bar, >> +hwaddr bar_offset, char * const buf, >> +

Re: [PATCH v8 13/17] vfio-user: handle DMA mappings

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 5:56 AM, Stefan Hajnoczi wrote: > > On Tue, Apr 19, 2022 at 04:44:18PM -0400, Jagannathan Raman wrote: >> +static void dma_unregister(vfu_ctx_t *vfu_ctx, vfu_dma_info_t *info) >> +{ >> +VfuObject *o = vfu_get_private(vfu_ctx); >> +AddressSpace *dma_as = NULL; >>

Re: [PATCH v8 12/17] vfio-user: IOMMU support for remote device

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 5:38 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 20, 2022 at 11:15:16AM +0000, Jag Raman wrote: >> >> >>> On Apr 19, 2022, at 4:45 PM, Jag Raman wrote: >>> >>> Assign separate address space for each device in the

Re: [PATCH v8 12/17] vfio-user: IOMMU support for remote device

2022-04-25 Thread Jag Raman
> On Apr 25, 2022, at 5:31 AM, Stefan Hajnoczi wrote: > > On Tue, Apr 19, 2022 at 04:44:17PM -0400, Jagannathan Raman wrote: >> +static AddressSpace *remote_iommu_find_add_as(PCIBus *pci_bus, >> + void *opaque, int devfn) >> +{ >> +RemoteIommu

Re: [PATCH v8 02/17] qdev: unplug blocker for devices

2022-04-22 Thread Jag Raman
> On Apr 22, 2022, at 1:18 AM, Markus Armbruster wrote: > > Jag Raman writes: > >>> On Apr 21, 2022, at 10:55 AM, Markus Armbruster wrote: >>> >>> Jagannathan Raman writes: >>> >>>> Add blocker to prevent hot-unplug of device

Re: [PATCH v8 10/17] vfio-user: run vfio-user context

2022-04-22 Thread Jag Raman
> On Apr 22, 2022, at 1:14 AM, Markus Armbruster wrote: > > Jag Raman writes: > >>> On Apr 21, 2022, at 10:59 AM, Markus Armbruster wrote: >>> >>> Jagannathan Raman writes: >>> >>>> Setup a handler to run vfio-user context. T

Re: [PATCH v8 10/17] vfio-user: run vfio-user context

2022-04-21 Thread Jag Raman
> On Apr 21, 2022, at 10:59 AM, Markus Armbruster wrote: > > Jagannathan Raman writes: > >> Setup a handler to run vfio-user context. The context is driven by >> messages to the file descriptor associated with it - get the fd for >> the context and hook up the handler with it >> >>

Re: [PATCH v8 02/17] qdev: unplug blocker for devices

2022-04-21 Thread Jag Raman
> On Apr 21, 2022, at 10:55 AM, Markus Armbruster wrote: > > Jagannathan Raman writes: > >> Add blocker to prevent hot-unplug of devices > > Why do you need this? I'm not doubting you do, I just want to read your > reasons here :) Hi Markus, :) The x-vfio-user-server depends on an

Re: [PATCH v8 12/17] vfio-user: IOMMU support for remote device

2022-04-20 Thread Jag Raman
> On Apr 19, 2022, at 4:45 PM, Jag Raman wrote: > > Assign separate address space for each device in the remote processes. > > Signed-off-by: Elena Ufimtseva > Signed-off-by: John G Johnson > Signed-off-by: Jagannathan Raman > --- > include/hw/remote/iommu.h | 4

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Jag Raman
> On Apr 13, 2022, at 2:24 PM, Jag Raman wrote: > > > >> On Apr 13, 2022, at 10:25 AM, Igor Mammedov wrote: >> >> On Fri, 25 Mar 2022 15:19:41 -0400 >> Jagannathan Raman wrote: >> >>> Assign separate address space for each device in

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-04-13 Thread Jag Raman
> On Apr 13, 2022, at 10:25 AM, Igor Mammedov wrote: > > On Fri, 25 Mar 2022 15:19:41 -0400 > Jagannathan Raman wrote: > >> Assign separate address space for each device in the remote processes. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by:

Re: [PATCH v7 14/17] vfio-user: handle PCI BAR accesses

2022-03-30 Thread Jag Raman
> On Mar 30, 2022, at 6:05 AM, Stefan Hajnoczi wrote: > > On Tue, Mar 29, 2022 at 03:51:17PM +0000, Jag Raman wrote: >> >> >>> On Mar 29, 2022, at 8:50 AM, Stefan Hajnoczi wrote: >>> >>> On Fri, Mar 25, 2022 at 03:19:43PM -0400, Jagannatha

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 10:48 AM, Stefan Hajnoczi wrote: > > On Tue, Mar 29, 2022 at 02:12:40PM +0000, Jag Raman wrote: >>> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: >>> On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: >>>>

Re: [PATCH v6 15/19] vfio-user: handle device interrupts

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 10:24 AM, Stefan Hajnoczi wrote: > > On Sat, Mar 26, 2022 at 11:47:36PM +0000, Jag Raman wrote: >> >> >>> On Mar 7, 2022, at 5:24 AM, Stefan Hajnoczi wrote: >>> >>> On Thu, Feb 17, 2022 at 02:49:02AM -0500, Jagan

Re: [PATCH v7 14/17] vfio-user: handle PCI BAR accesses

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 8:50 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:43PM -0400, Jagannathan Raman wrote: >> @@ -324,6 +325,170 @@ static void dma_unregister(vfu_ctx_t *vfu_ctx, >> vfu_dma_info_t *info) >> trace_vfu_dma_unregister((uint64_t)info->iova.iov_base); >> }

Re: [PATCH v7 12/17] vfio-user: IOMMU support for remote device

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 8:35 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:41PM -0400, Jagannathan Raman wrote: >> Assign separate address space for each device in the remote processes. >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by:

Re: [PATCH v7 07/17] vfio-user: define vfio-user-server object

2022-03-29 Thread Jag Raman
> On Mar 29, 2022, at 6:21 AM, Stefan Hajnoczi wrote: > > On Fri, Mar 25, 2022 at 03:19:36PM -0400, Jagannathan Raman wrote: > ## >> diff --git a/include/hw/remote/machine.h b/include/hw/remote/machine.h >> index 8d0fa98d33..2fcb9dada5 100644 >> --- a/include/hw/remote/machine.h >> +++

Re: [PATCH v6 15/19] vfio-user: handle device interrupts

2022-03-26 Thread Jag Raman
> On Mar 7, 2022, at 5:24 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:49:02AM -0500, Jagannathan Raman wrote: >> Forward remote device's interrupts to the guest >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >>

Re: [PATCH v6 18/19] vfio-user: handle reset of remote device

2022-03-07 Thread Jag Raman
> On Mar 7, 2022, at 6:36 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:49:05AM -0500, Jagannathan Raman wrote: >> Adds handler to reset a remote device >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >>

Re: [PATCH v6 16/19] softmmu/vl: defer backend init

2022-03-07 Thread Jag Raman
> On Mar 7, 2022, at 5:48 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:49:03AM -0500, Jagannathan Raman wrote: >> Allow deferred initialization of backends. TYPE_REMOTE_MACHINE is >> agnostic to QEMU's RUN_STATE. It's state is driven by the QEMU client > > s/It's/Its/ > >> via

Re: [PATCH v6 15/19] vfio-user: handle device interrupts

2022-03-07 Thread Jag Raman
> On Mar 7, 2022, at 5:24 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:49:02AM -0500, Jagannathan Raman wrote: >> Forward remote device's interrupts to the guest >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >>

Re: [PATCH v6 12/19] vfio-user: IOMMU support for remote device

2022-03-07 Thread Jag Raman
> On Mar 7, 2022, at 4:45 AM, Stefan Hajnoczi wrote: > > On Thu, Mar 03, 2022 at 02:49:53PM +0000, Jag Raman wrote: >> >> >>> On Mar 2, 2022, at 11:49 AM, Stefan Hajnoczi wrote: >>> >>> On Mon, Feb 28, 2022 at 07:54:38PM +, Jag Raman wrot

Re: [PATCH v6 12/19] vfio-user: IOMMU support for remote device

2022-03-03 Thread Jag Raman
> On Mar 2, 2022, at 11:49 AM, Stefan Hajnoczi wrote: > > On Mon, Feb 28, 2022 at 07:54:38PM +0000, Jag Raman wrote: >> >> >>> On Feb 22, 2022, at 5:40 AM, Stefan Hajnoczi wrote: >>> >>> On Thu, Feb 17, 2022 at 02:48:59AM -0500, Jagan

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-28 Thread Jag Raman
> On Feb 28, 2022, at 1:12 PM, Paolo Bonzini wrote: > > On 2/25/22 05:03, Jag Raman wrote: >>> On Feb 24, 2022, at 12:52 PM, Paolo Bonzini wrote: >>> >>> On 2/22/22 20:05, Jag Raman wrote: >>>>> -defaults[prefix + 'COMPILER

Re: [PATCH v6 12/19] vfio-user: IOMMU support for remote device

2022-02-28 Thread Jag Raman
> On Feb 22, 2022, at 5:40 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:59AM -0500, Jagannathan Raman wrote: >> +struct RemoteIommuElem { >> +AddressSpace as; >> +MemoryRegion mr; >> +}; >> + >> +GHashTable *remote_iommu_elem_by_bdf; > > A mutable global hash table

Re: [PATCH v6 11/19] vfio-user: handle PCI config space accesses

2022-02-28 Thread Jag Raman
> On Feb 22, 2022, at 6:09 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:58AM -0500, Jagannathan Raman wrote: >> Define and register handlers for PCI config space accesses >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan

Re: [PATCH v6 10/19] vfio-user: run vfio-user context

2022-02-28 Thread Jag Raman
> On Feb 25, 2022, at 11:06 AM, Eric Blake wrote: > > On Thu, Feb 17, 2022 at 02:48:57AM -0500, Jagannathan Raman wrote: >> Setup a handler to run vfio-user context. The context is driven by >> messages to the file descriptor associated with it - get the fd for >> the context and hook up the

Re: [PATCH v6 09/19] vfio-user: find and init PCI device

2022-02-28 Thread Jag Raman
> On Feb 21, 2022, at 10:57 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:56AM -0500, Jagannathan Raman wrote: >> @@ -221,6 +272,14 @@ static void vfu_object_finalize(Object *obj) >> >> o->device = NULL; >> >> +if (o->unplug_blocker && o->pci_dev) { >> +

Re: [PATCH v6 08/19] vfio-user: instantiate vfio-user context

2022-02-28 Thread Jag Raman
> On Feb 21, 2022, at 10:42 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:55AM -0500, Jagannathan Raman wrote: >> @@ -124,6 +190,11 @@ static void vfu_object_init(Object *obj) >> >> k->nr_devs++; >> >> +if (!phase_check(PHASE_MACHINE_READY)) { >> +

Re: [PATCH v6 07/19] vfio-user: define vfio-user-server object

2022-02-28 Thread Jag Raman
> On Feb 21, 2022, at 10:37 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:54AM -0500, Jagannathan Raman wrote: >> +struct VfuObjectClass { >> +ObjectClass parent_class; >> + >> +unsigned int nr_devs; >> + >> +/* >> + * Can be set to shutdown automatically when

Re: [PATCH v6 03/19] qdev: unplug blocker for devices

2022-02-28 Thread Jag Raman
> On Feb 21, 2022, at 10:30 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:50AM -0500, Jagannathan Raman wrote: >> diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c >> index 01f3834db5..69d9cf3f25 100644 >> --- a/softmmu/qdev-monitor.c >> +++ b/softmmu/qdev-monitor.c

Re: [PATCH v6 03/19] qdev: unplug blocker for devices

2022-02-28 Thread Jag Raman
> On Feb 21, 2022, at 10:27 AM, Stefan Hajnoczi wrote: > > On Thu, Feb 17, 2022 at 02:48:50AM -0500, Jagannathan Raman wrote: >> Add blocker to prevent hot-unplug of devices >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >>

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-24 Thread Jag Raman
> On Feb 24, 2022, at 12:52 PM, Paolo Bonzini wrote: > > On 2/22/22 20:05, Jag Raman wrote: >>> -defaults[prefix + 'COMPILER'] = exe_list >>> +defaults[f'{prefix}COMPILER'] = [exe_list[0]] >>> +for i in range(1, len(exe_l

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-22 Thread Jag Raman
> On Feb 20, 2022, at 3:27 AM, Paolo Bonzini wrote: > > On 2/18/22 15:49, Jag Raman wrote: >> Concerning the generated files, I see the following in >> CMakeMesonToolchainFile.cmake: >> Without patch: set(CMAKE_C_COMPILER "/opt/rh/devtoolset-9/roo

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 9:49 AM, Jag Raman wrote: > > > >> On Feb 18, 2022, at 7:13 AM, Paolo Bonzini wrote: >> >> On 2/18/22 04:40, Jag Raman wrote: >>>> On Feb 17, 2022, at 7:09 AM, Peter Maydell >>>> wrote: >>>>

Re: [PATCH v6 17/19] vfio-user: register handlers to facilitate migration

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 7:20 AM, Paolo Bonzini wrote: > > On 2/17/22 08:49, Jagannathan Raman wrote: >> Store and load the device's state during migration. use libvfio-user's >> handlers for this purpose >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by:

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-18 Thread Jag Raman
> On Feb 18, 2022, at 7:13 AM, Paolo Bonzini wrote: > > On 2/18/22 04:40, Jag Raman wrote: >>> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: >>> >>> On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman >>> wrote: >>>> >&

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-17 Thread Jag Raman
> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: > > On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman wrote: >> >> The compiler path that cmake gets from meson is corrupted. It results in >> the following error: >> | -- The C compiler identification is unknown >> | CMake Error at

Re: [PATCH v6 01/19] configure, meson: override C compiler for cmake

2022-02-17 Thread Jag Raman
> On Feb 17, 2022, at 7:09 AM, Peter Maydell wrote: > > On Thu, 17 Feb 2022 at 07:56, Jagannathan Raman wrote: >> >> The compiler path that cmake gets from meson is corrupted. It results in >> the following error: >> | -- The C compiler identification is unknown >> | CMake Error at

Re: [PATCH v5 01/18] configure, meson: override C compiler for cmake

2022-02-16 Thread Jag Raman
> On Jan 20, 2022, at 8:27 AM, Paolo Bonzini wrote: > > On 1/19/22 22:41, Jagannathan Raman wrote: >> The compiler path that cmake gets from meson is corrupted. It results in >> the following error: >> | -- The C compiler identification is unknown >> | CMake Error at CMakeLists.txt:35

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-10 Thread Jag Raman
lex Williamson wrote: >>>> On Thu, 10 Feb 2022 22:23:01 + >>>> Jag Raman wrote: >>>> >>>>>> On Feb 10, 2022, at 3:02 AM, Michael S. Tsirkin wrote: >>>>>> >>>>>> On Thu, Feb 10, 2022 at 12:0

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-10 Thread Jag Raman
> On Feb 10, 2022, at 6:17 PM, Alex Williamson > wrote: > > On Thu, 10 Feb 2022 22:23:01 + > Jag Raman wrote: > >>> On Feb 10, 2022, at 3:02 AM, Michael S. Tsirkin wrote: >>> >>> On Thu, Feb 10, 2022 at 12:08:27AM +, Jag Raman wrote:

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-10 Thread Jag Raman
> On Feb 10, 2022, at 5:53 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 10, 2022 at 10:23:01PM +0000, Jag Raman wrote: >> >> >>> On Feb 10, 2022, at 3:02 AM, Michael S. Tsirkin wrote: >>> >>> On Thu, Feb 10, 2022 at 12:08:27AM +, J

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-10 Thread Jag Raman
> On Feb 10, 2022, at 3:02 AM, Michael S. Tsirkin wrote: > > On Thu, Feb 10, 2022 at 12:08:27AM +0000, Jag Raman wrote: >> >> >>> On Feb 2, 2022, at 12:34 AM, Alex Williamson >>> wrote: >>> >>> On Wed, 2 Feb 2022 01:13:22 + &g

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-09 Thread Jag Raman
> On Feb 2, 2022, at 12:34 AM, Alex Williamson > wrote: > > On Wed, 2 Feb 2022 01:13:22 + > Jag Raman wrote: > >>> On Feb 1, 2022, at 5:47 PM, Alex Williamson >>> wrote: >>> >>> On Tue, 1 Feb 2022 21:24:08 + >>>

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-01 Thread Jag Raman
> On Feb 1, 2022, at 5:47 PM, Alex Williamson > wrote: > > On Tue, 1 Feb 2022 21:24:08 + > Jag Raman wrote: > >>> On Feb 1, 2022, at 10:24 AM, Alex Williamson >>> wrote: >>> >>> On Tue, 1 Feb 2022 09:30:35 + >>> Stefa

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-02-01 Thread Jag Raman
> On Feb 1, 2022, at 10:24 AM, Alex Williamson > wrote: > > On Tue, 1 Feb 2022 09:30:35 + > Stefan Hajnoczi wrote: > >> On Mon, Jan 31, 2022 at 09:16:23AM -0700, Alex Williamson wrote: >>> On Fri, 28 Jan 2022 09:18:08 + >>> Stefan Hajnoczi wrote: >>> On Thu, Jan 27, 2022 at

Re: [PATCH v5 17/18] vfio-user: register handlers to facilitate migration

2022-01-31 Thread Jag Raman
> On Jan 28, 2022, at 3:29 AM, Stefan Hajnoczi wrote: > > On Thu, Jan 27, 2022 at 05:04:26PM +0000, Jag Raman wrote: >> >> >>> On Jan 25, 2022, at 10:48 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Jan 19, 2022 at 04:42:06PM -0500, Jagannathan

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-27 Thread Jag Raman
> On Jan 26, 2022, at 1:13 PM, Dr. David Alan Gilbert > wrote: > > * Jag Raman (jag.ra...@oracle.com) wrote: >> >> >>> On Jan 25, 2022, at 1:38 PM, Dr. David Alan Gilbert >>> wrote: >>> >>> * Jag Raman (jag.ra...@oracle.com) wro

Re: [PATCH v5 17/18] vfio-user: register handlers to facilitate migration

2022-01-27 Thread Jag Raman
> On Jan 25, 2022, at 10:48 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:42:06PM -0500, Jagannathan Raman wrote: >> + * The client subsequetly asks the remote server for any data that > > subsequently > >> +static void vfu_mig_state_running(vfu_ctx_t *vfu_ctx) >> +{ >> +

Re: [PATCH v5 07/18] vfio-user: set qdev bus callbacks for remote machine

2022-01-26 Thread Jag Raman
> On Jan 26, 2022, at 4:37 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 09:12:28PM +0000, Jag Raman wrote: >> >> >>> On Jan 25, 2022, at 5:44 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Jan 19, 2022 at 04:41:56PM -0500, Jagannathan

Re: [PATCH v5 06/18] vfio-user: add HotplugHandler for remote machine

2022-01-26 Thread Jag Raman
> On Jan 26, 2022, at 4:35 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 06:12:48PM +0000, Jag Raman wrote: >> >> >>> On Jan 25, 2022, at 5:32 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Jan 19, 2022 at 04:41:55PM -0500, Jagannat

Re: [PATCH v5 05/18] qdev: unplug blocker for devices

2022-01-26 Thread Jag Raman
> On Jan 26, 2022, at 4:32 AM, Stefan Hajnoczi wrote: > > On Tue, Jan 25, 2022 at 02:43:33PM +0000, Jag Raman wrote: >> >> >>> On Jan 25, 2022, at 5:27 AM, Stefan Hajnoczi wrote: >>> >>> On Wed, Jan 19, 2022 at 04:41:54PM -0500, Jagannathan

Re: [PATCH v5 18/18] vfio-user: avocado tests for vfio-user

2022-01-26 Thread Jag Raman
> On Jan 25, 2022, at 11:25 PM, Philippe Mathieu-Daudé wrote: > > Hi Jagannathan, > > On 19/1/22 22:42, Jagannathan Raman wrote: >> Avocado tests for libvfio-user in QEMU - tests startup, >> hotplug and migration of the server object >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 1:38 PM, Dr. David Alan Gilbert > wrote: > > * Jag Raman (jag.ra...@oracle.com) wrote: >> >> >>> On Jan 19, 2022, at 7:12 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, Jan 19, 2022 at 04:41:52PM -0500, Jagan

Re: [PATCH v5 00/18] vfio-user server in QEMU

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 11:00 AM, Stefan Hajnoczi wrote: > > Hi Jag, > Thanks for this latest revision. The biggest outstanding question I have > is about the isolated address spaces design. Thank you for taking the time to review the patches, Stefan! > > This patch series needs a PCIBus with

Re: [PATCH v5 12/18] vfio-user: run vfio-user context

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 10:10 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:42:01PM -0500, Jagannathan Raman wrote: >> Setup a handler to run vfio-user context. The context is driven by >> messages to the file descriptor associated with it - get the fd for >> the context and hook up

Re: [PATCH v5 11/18] vfio-user: find and init PCI device

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 9:48 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:42:00PM -0500, Jagannathan Raman wrote: >> Find the PCI device with specified id. Initialize the device context >> with the QEMU PCI device >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G

Re: [PATCH v5 07/18] vfio-user: set qdev bus callbacks for remote machine

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:44 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:56PM -0500, Jagannathan Raman wrote: >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >> hw/remote/machine.c | 57

Re: [PATCH v5 06/18] vfio-user: add HotplugHandler for remote machine

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:32 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:55PM -0500, Jagannathan Raman wrote: >> Allow hotplugging of PCI(e) devices to remote machine >> >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >>

Re: [PATCH v5 05/18] qdev: unplug blocker for devices

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:27 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:54PM -0500, Jagannathan Raman wrote: >> Signed-off-by: Elena Ufimtseva >> Signed-off-by: John G Johnson >> Signed-off-by: Jagannathan Raman >> --- >> include/hw/qdev-core.h | 5 + >>

Re: [PATCH v5 04/18] pci: create and free isolated PCI buses

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 5:25 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:53PM -0500, Jagannathan Raman wrote: >> Adds pci_isol_bus_new() and pci_isol_bus_free() functions to manage >> creation and destruction of isolated PCI buses. Also adds qdev_get_bus >> and qdev_put_bus

Re: [PATCH v5 03/18] pci: isolated address space for PCI bus

2022-01-25 Thread Jag Raman
> On Jan 25, 2022, at 4:56 AM, Stefan Hajnoczi wrote: > > On Wed, Jan 19, 2022 at 04:41:52PM -0500, Jagannathan Raman wrote: >> Allow PCI buses to be part of isolated CPU address spaces. This has a >> niche usage. >> >> TYPE_REMOTE_MACHINE allows multiple VMs to house their PCI devices in >>

  1   2   3   >