Re: [RFC PATCH v2 0/2] ui/gtk: Introduce new param - Connectors

Hi Marc-André, On 6/5/2024 12:26 AM, Marc-André Lureau wrote: Hi On Tue, Jun 4, 2024 at 9:59 PM Kim, Dongwon <mailto:dongwon@intel.com>> wrote: Hi Marc-André, On 6/4/2024 3:37 AM, Marc-André Lureau wrote: > Hi > > On Fri, May 31, 2024 at 11:00

Re: [RFC PATCH v2 0/2] ui/gtk: Introduce new param - Connectors

Hi Marc-André, On 6/4/2024 3:37 AM, Marc-André Lureau wrote: Hi On Fri, May 31, 2024 at 11:00 PM > wrote: From: Dongwon Kim mailto:dongwon@intel.com>> This patch series is a replacement of

Re: [PATCH] ui/gtk: Wait until the current guest frame is rendered before switching to RUN_STATE_SAVE_VM

On 6/4/2024 4:12 AM, Marc-André Lureau wrote: Hi On Thu, May 30, 2024 at 2:44 AM > wrote: From: Dongwon mailto:dongwon@intel.com>> Make sure rendering of the current frame is finished before switching the run state to RUN_STATE_SAVE_VM by waiting

RE: [PULL 1/5] ui/console: Only declare variable fence_fd when CONFIG_GBM is defined

Thanks and sorry for missing this in the original commit. Acked-by: Dongwon Kim > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Friday, May 17, 2024 8:02 AM > To: qemu-devel@nongnu.org > Cc: Cédric Le Goater ; Kim, Dongwon > ; Marc-André Lureau > ; P

RE: [PULL 00/11] Ui patches

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Wednesday, May 15, 2024 3:44 AM > To: Michael Tokarev > Cc: qemu-devel@nongnu.org; qemu-stable ; > hikalium ; Kim, Dongwon > Subject: Re: [PULL 00/11] Ui patches > > Hi > > On Wed

RE: [PATCH v2] vhost-user-gpu: fix import of DMABUF

arcandre.lur...@redhat.com > Sent: Monday, May 13, 2024 4:13 AM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon ; Marc-André Lureau > ; Gerd Hoffmann ; > Michael S. Tsirkin > Subject: [PATCH v2] vhost-user-gpu: fix import of DMABUF > > From: Marc-André Lureau > > When

RE: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying

ssage- > From: qemu-devel-bounces+dongwon.kim=intel@nongnu.org devel-bounces+dongwon.kim=intel@nongnu.org> On Behalf Of Kim, > Dongwon > Sent: Tuesday, May 7, 2024 9:06 AM > To: Marc-André Lureau > Cc: qemu-devel@nongnu.org; kra...@redhat.com > Subject: RE:

RE: [PATCH] ui/gtk: Explicitly set the default size of new window when untabifying

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, May 7, 2024 8:10 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; kra...@redhat.com > Subject: Re: [PATCH] ui/gtk: Explicitly set the default size of new window > when > untabif

RE: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Tuesday, April 23, 2024 7:07 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.com; > phi...@linaro.org > Subject: Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmab

RE: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Tuesday, April 23, 2024 7:07 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.com; > phi...@linaro.org > Subject: Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmab

RE: [PATCH v6 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, April 17, 2024 4:05 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.com > Subject: Re: [PATCH v6 1/3] ui/console: Introduce > dpy_gl_qemu_dmabuf_get_..() helper

RE: [PATCH] vhost-user-gpu: fix import of DMABUF

Hi Marc-André, > -Original Message- > From: marcandre.lur...@redhat.com > Sent: Monday, April 15, 2024 4:16 AM > To: qemu-devel@nongnu.org > Cc: Kim, Dongwon ; dbas...@redhat.com; Marc- > André Lureau ; Michael S. Tsirkin > ; Gerd Hoffmann > Subject: [PATCH] vh

RE: [PATCH v4 1/3] ui/console: Introduce dpy_gl_dmabuf_get_height/width() helpers

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Friday, March 22, 2024 2:06 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; phi...@linaro.org > Subject: Re: [PATCH v4 1/3] ui/console: Introduce > dpy_gl_dmabuf_get_height/width() helpers &g

RE: [PATCH v4 3/3] ui/console: Introduce dpy_gl_create_dmabuf() helper

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Friday, March 22, 2024 2:06 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; phi...@linaro.org > Subject: Re: [PATCH v4 3/3] ui/console: Introduce dpy_gl_create_dmabuf() > helper > > H

RE: [INCOMPLETE PATCH v3 3/3] ui/console: Introduce dpy_gl_create_dmabuf() helper

age- > From: Philippe Mathieu-Daudé > Sent: Thursday, March 21, 2024 3:07 AM > To: Kim, Dongwon ; qemu-devel@nongnu.org > Cc: Alex Williamson ; Cédric Le Goater > ; Marc-André Lureau ; > Kasireddy, Vivek ; Michael S. Tsirkin > ; Gerd Hoffmann ; Philippe Mathieu- > Daudé &

RE: [PATCH 0/3] ui/console: initialize QemuDmaBuf in ui/console

Hi Phlippe, > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Wednesday, March 20, 2024 11:57 PM > To: Kim, Dongwon ; qemu-devel@nongnu.org > Cc: marcandre.lur...@redhat.com > Subject: Re: [PATCH 0/3] ui/console: initialize QemuDmaBuf in ui/console > >

RE: [PATCH v3] ui/gtk: flush display pipeline before saving vmstate when blob=true

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, March 12, 2024 4:27 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH v3] ui/gtk: flush display pipeline before saving vmstate > when > blob=true > > Hi

RE: [PATCH v2] virtio-gpu: first surface update with blob scanout after resumed

Hi Marc-André, Ok, seems like your commit would fix the problem I was trying to solve. I will test it and let you know the results. > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, March 12, 2024 4:35 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.or

RE: [PATCH 0/3] ui/gtk: introducing vc->visible

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, March 5, 2024 4:18 AM > To: Kim, Dongwon ; P. Berrange, Daniel > > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 0/3] ui/gtk: introducing vc->visible > > Hi Kim > >

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 10:01 AM > To: Kim, Dongwon > Cc: Marc-André Lureau ; qemu- > de...@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invis

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 1:46 AM > To: Kim, Dongwon > Cc: Marc-André Lureau ; qemu- > de...@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invis

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

Hi Daniel, > -Original Message- > From: Daniel P. Berrangé > Sent: Thursday, March 7, 2024 1:41 AM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invisible > > On Tue, Jan 3

RE: [PATCH v3 1/2] ui/gtk: flush display pipeline before saving vmstate when blob=true

Hi Marc-André, Can you take a look at this new version and also https://lists.gnu.org/archive/html/qemu-devel/2023-12/msg01828.html? Thanks! DW > -Original Message- > From: qemu-devel-bounces+dongwon.kim=intel@nongnu.org devel-bounces+dongwon.kim=intel@nongnu.org> On Behalf Of

RE: [PATCH 0/3] ui/gtk: introducing vc->visible

Hi Marc-André Lureau, Just a reminder.. I need your help reviewing this patch series. Please take a look at my messages at https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg06636.html and https://lists.gnu.org/archive/html/qemu-devel/2024-01/msg06637.html Thanks!! DW > -Original

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

display hot plug in patches) Thanks! > Subject: Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated > VC is invisible > > Hi > > On Wed, Jan 31, 2024 at 10:56 PM Kim, Dongwon > wrote: > > > > Hi Marc-André, > > > > > https:/

RE: [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Tuesday, January 30, 2024 11:13 PM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org > Subject: Re: [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible > > Hi > > On Wed,

RE: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

Hi Marc-André, > https://docs.gtk.org/gtk3/method.Widget.is_visible.html This is what we had tried first but it didn't seem to work for the case of window minimization. I see the visible flag for the GTK widget didn't seem to be toggled for some reason. And when closing window, vc->window

RE: [PATCH 1/3] ui/gtk: flush display pipeline before saving vmstate when blob=true

Hi, > Subject: RE: [PATCH 1/3] ui/gtk: flush display pipeline before saving vmstate > when blob=true > > Hi, > > > > > On Thu, Dec 14, 2023 at 8:26 AM Dongwon Kim > > wrote: > > > > > > If the guest state is paused before it gets a response for the > > > current scanout frame submission

RE: [PATCH 2/3] ui/gtk: unblock pipeline only if fence hasn't been signaled yet

Hi Marc-André, I reviewed and realized these conditions won't be met in normal situations in given upstream code. But we've initially added those conditions in our internal code base for dev because we often had to call gd_hw_gl_flushed to forcefully unblock from HPD code (i.e. 'connectors'

RE: [PATCH] ui/gtk: flush display pipeline before saving vmstate when blob=true

Hi Marc-André, > -Original Message- > From: Marc-André Lureau > Sent: Monday, December 4, 2023 11:15 PM > To: Kim, Dongwon > Cc: qemu-devel@nongnu.org; Kasireddy, Vivek > Subject: Re: [PATCH] ui/gtk: flush display pipeline before saving vmstate when > blob=true >

RE: [PATCH] ui/gtk: full-screening all detached windows

Hi Marc-André, > Hi > > On Fri, Oct 13, 2023 at 2:51 AM Dongwon Kim > wrote: > > > > When turning on or off full-screen menu, all detached windows should > > be full-screened or un-full-screened altogether. > > I am not convinced this is desirable. Not only having multiple fullscreen >

Re: [PATCH for-8.1] vfio/display: Fix missing update to set backing fields

Ok, this regression happened not just because of renaming. Originally width and height were representing the size of whole surface that guest shares while scanout width and height are for the each scanout. We realized backing_width/height are more commonly used to specify the size of the whole

Re: [PATCH 2/2] virtio-gpu: reset gfx resources in main thread

Looking good. By the way, what does 'BH' stand for? Acked-by: Dongwon Kim From: Marc-André Lureau Calling OpenGL from different threads can have bad consequences if not carefully reviewed. It's not generally supported. In my case, I was debugging a crash in glDeleteTextures from

Re: [PATCH 1/2] virtio-gpu: free BHs, by implementing unrealize

Acked-by: Dongwon Kim From: Marc-André Lureau Signed-off-by: Marc-André Lureau ---  include/hw/virtio/virtio-gpu.h |  1 +  hw/display/virtio-gpu-base.c   |  2 +-  hw/display/virtio-gpu.c    | 10 ++  3 files changed, 12 insertions(+), 1 deletion(-) diff --git

Re: [PULL 06/19] ui/gtk: set scanout-mode right before scheduling draw

Hi there, I guess removing this line would have been causing the problem. Can you add this line back and test it? diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index eee821d73a..98b3a116bf 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -242,7 +242,6 @@ void

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

On 7/11/2023 10:52 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/10/2023 11:36 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/9/2023 11:05 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/7/2023 7:07 AM, Markus Armbruste

Re: [PATCH] virtio-gpu-udmabuf: replacing scanout_width/height with backing_width/height

On 7/10/2023 4:57 AM, Marc-André Lureau wrote: Hi On Thu, Jul 6, 2023 at 3:10 AM Dongwon Kim wrote: 'backing_width' and 'backing_height' are commonly used to indicate the size of the whole backing region so it makes sense to use those terms for VGAUDMABuf as well in place of

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

On 7/10/2023 11:36 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/9/2023 11:05 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/7/2023 7:07 AM, Markus Armbruster wrote: [...] Ignorant questions: 1. How would I plug / unplug display cables?

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

On 7/9/2023 11:05 PM, Markus Armbruster wrote: "Kim, Dongwon" writes: On 7/7/2023 7:07 AM, Markus Armbruster wrote: "Kim, Dongwon" writes: Hi Markus, So I've worked on the description of this param. Can you check if this new version looks ok? # @connectors:  List

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

On 7/7/2023 7:07 AM, Markus Armbruster wrote: "Kim, Dongwon" writes: Hi Markus, So I've worked on the description of this param. Can you check if this new version looks ok? # @connectors:  List of physical monitor/connector names where the GTK #           windows containing the

Re: [PATCH] virtio-gpu: do not replace surface when scanout is disabled

On 7/4/2023 8:12 AM, Marc-André Lureau wrote: Hi On Wed, Jun 28, 2023 at 12:32 AM Dongwon Kim wrote: Surface is replaced with a place holder whenever the surface res is unreferenced by the guest message. With this logic, there is very frequent switching between guest display and

Re: [PATCH] ui/gtk: set the area of the scanout texture correctly

On 7/4/2023 9:07 AM, Marc-André Lureau wrote: Hi On Mon, Jun 26, 2023 at 9:49 PM Kim, Dongwon wrote: Hi Marc-André Lureau, On 6/26/2023 4:56 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 21, 2023 at 11:53 PM Dongwon Kim > wrote: >

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

On 6/21/2023 4:14 AM, Robert Beckett wrote: On 21/06/2023 09:39, Gerd Hoffmann wrote: On Tue, Jun 20, 2023 at 01:26:15PM +0100, Robert Beckett wrote: On 20/06/2023 10:41, Gerd Hoffmann wrote:     Hi, The guest driver should be able to restore resources after resume. Thank you for your

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

This method - letting QEMU not remove resources would work on S3 case but with S4, the QEMU would lose all the resources anyway as the process will be terminated. So objects restoring was only option for us as in [RFC PATCH 2/2] drm/virtio: restore virtio_gpu_objects upon suspend and resume

Re: [RFC PATCH 6/9] ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

Hi Markus, So I've worked on the description of this param. Can you check if this new version looks ok? # @connectors:  List of physical monitor/connector names where the GTK #           windows containing the respective graphics virtual consoles (VCs) #   are to be placed. Index of

Re: [PATCH] ui/gtk: set the area of the scanout texture correctly

Hi Marc-André Lureau, On 6/26/2023 4:56 AM, Marc-André Lureau wrote: Hi On Wed, Jun 21, 2023 at 11:53 PM Dongwon Kim wrote: x and y offsets and width and height of the scanout texture is not correctly configured in case guest scanout frame is dmabuf. Cc: Gerd Hoffmann

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

Hello, I just came across this discussion regarding s3/s4 support in virtio-gpu driver and QEMU. We saw similar problem a while ago (QEMU deletes all objects upon suspension) and came up with an experimental solution that is basically making virtio-gpu driver to do object creation for

Re: [PATCH v1 0/3] ui/gtk: Add a new parameter to assign connectors/monitors to Guests' windows

Hi Markus, Vivek and I have discussed this already. I am fine with replacing my old series with this. Thanks, DW On 9/20/2022 11:06 PM, Markus Armbruster wrote: "Kasireddy, Vivek" writes: Hi Markus, Any overlap with Dongwon Kim's "[PATCH v5 0/2] handling guest multiple displays"?