g_assert_cmphex(curval, ==, 0x0);
curval = aspeed_fsi_readl(s, ASPEED_FSI_OPB1_READ_DATA);
-g_assert_cmpuint(curval, ==, 0x152d02c0);
+g_assert_cmphex(curval, ==, 0x152d02c0);
}
aspeed-fsi-test changes looks good. Thanks
Reviewed-by: Ninad Palsule
Hello Cedric,
Sure, Let me check.
On 1/26/24 10:48, Cédric Le Goater wrote:
On 1/26/24 16:56, Peter Maydell wrote:
On Fri, 26 Jan 2024 at 13:33, Cédric Le Goater wrote:
The following changes since commit
e029fe22caad9b75c7ab69bd4e84853c11fb71e0:
Merge tag 'pull-qapi-2024-01-26' of
object and fsi_opb_realize()
- simplified OPBus ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Removed unused parameters from function.
- Used qdev_realize() instead of qdev_realize_and_undef
- Given a name to the opb memory region
igned-off-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/arm/aspeed_soc.h | 4
hw/arm/aspeed_ast2600.c | 19 +++
2 files changed, 23 insertions(+)
diff --git a/include/hw/arm/aspeed_s
()
- dropped FSIBus definition ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Initialized registers.
- Fixed the address check.
v11:
- Replaced for loop with memset.
- Removed Joel's review tag as per Cedric.
---
include/hw/fsi/fsi
- reworked fsi_cfam_realize() ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Added more registers to scratchpad
- Removed unnecessary address space
- Removed unnecessary header file
- Defined macros for config values.
- Cleaned up cfam c
definition
- dropped hw/fsi/trace-events changes ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v11:
- Split the patch.
---
include/hw/fsi/fsi.h | 19 +++
hw/fsi/fsi.c | 22 ++
hw/fsi/meson.build
- removed lbus_create_device() bc used only once
- removed "address" property
- updated meson.build to build fsi dir
- included an empty hw/fsi/trace-events ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsu
Added maintainer for IBM FSI model
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v11:
- Added Cedric as reviewer.
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dfaca8323e..39deb8ee1f 100644
--- a/MAINTAINERS
+++ b
. The scratch pad is managed under FSI CFAM state.
Signed-off-by: Andrew Jeffery
[ clg: - moved object FSIScratchPad under FSICFAMState
- moved FSIScratchPad code under cfam.c ]
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi
Added basic qtests for FSI model.
Acked-by: Thomas Huth
Signed-off-by: Ninad Palsule
---
v11:
- Removed Cedric's signoff
---
tests/qtest/aspeed-fsi-test.c | 205 ++
tests/qtest/meson.build | 1 +
2 files changed, 206 insertions(+)
create mode 100644
Documentation for IBM FSI model.
Signed-off-by: Ninad Palsule
---
v11:
- Removed Cedric's signoff.
---
docs/specs/fsi.rst | 126 +++
docs/specs/index.rst | 1 +
2 files changed, 127 insertions(+)
create mode 100644 docs/specs/fsi.rst
diff --git
Hello,
Please review the patch-set version 12.
I have incorporated review comments from Cedric.
v12:
- Minor changes.
- Added reviewed by tags.
Ninad Palsule (11):
hw/fsi: Introduce IBM's Local bus
hw/fsi: Introduce IBM's scratchpad device
hw/fsi: Introduce IBM's FSI Bus
hw/fsi
to which it is attached.
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi/fsi.h | 18 ++
hw/fsi/fsi.c | 84 ++--
hw/fsi/trace-events | 2 ++
3 files
Hello Cedric,
On 1/26/24 02:57, Cédric Le Goater wrote:
On 1/26/24 04:40, Ninad Palsule wrote:
Added maintainer for IBM FSI model
Signed-off-by: Ninad Palsule
---
v11:
- Added Cedric as reviewer.
Reviewed-by: Cédric Le Goater
Added the tag. Thanks for the review.
Regards,
Ninad
Hello Cedric,
I did some minor comments. v12 should be queued for upstream. I will
reorder the Signed-off (mine) trailers.
Thanks a lot for detailed review.
Regards,
Ninad
Hello Cedric,
+QEMU files related to FSI interface:
+ - ``hw/fsi/aspeed-apb2opb.c``
+ - ``include/hw/fsi/aspeed-apb2opb.h``
+ - ``hw/fsi/opb.c``
+ - ``include/hw/fsi/opb.h``
+ - ``hw/fsi/fsi.c``
+ - ``include/hw/fsi/fsi.h``
+ - ``hw/fsi/fsi-master.c``
+ - ``include/hw/fsi/fsi-master.h``
+ -
Hello Cedric,
+
+static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp)
+{
+ SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
+ AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev);
+ int i;
+
Please add a comment regarding the OPBus model here, something like :
/*
* TODO: The
Hello Cedric,
v9:
- Initialized registers.
- Fixed the address check.
v11:
- Replaced for loop with memset.
- Removed Joel's review tag as per Cedric.
Reviewed-by: Cédric Le Goater
Added tag. Thanks for the review.
Regards,
Ninad
Hello Cedric,
+#include "hw/fsi/fsi.h"
+
+#include "hw/qdev-properties.h"
+
+#define ENGINE_CONFIG_NEXT BE_BIT(0)
BE_BIT is not used much. I wonder if we should keep it.
Agree. It is only used at couple of places. Removed BE_BIT()
Anyhow,
Reviewed-by: Cédric Le Goater
Hello Cedric,
+
+static void fsi_slave_reset(DeviceState *dev)
+{
+ FSISlaveState *s = FSI_SLAVE(dev);
+ int i;
+
+ /* Initialize registers */
+ for (i = 0; i < FSI_SLAVE_CONTROL_NR_REGS; i++) {
+ s->regs[i] = 0;
+ }
memset would be better.
Replaced for loop with
Hello Cedric,
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
Reviewed-by: Cédric Le Goater
Added tag. Thanks for the review.
Regards,
Ninad
Hello Cedric,
+static uint64_t fsi_scratchpad_read(void *opaque, hwaddr addr,
unsigned size)
+{
+ FSIScratchPad *s = SCRATCHPAD(opaque);
+ int reg = TO_REG(addr);
+
+ trace_fsi_scratchpad_read(addr, size);
+
+ if (reg >= FSI_SCRATCHPAD_NR_REGS) {
usually, the model logs a
Hello Cedric,
- included an empty hw/fsi/trace-events ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
Reviewed-by: Cédric Le Goater
Added tag. Thank you for the review.
Regards,
Ninad
to which it is attached.
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi/fsi.h | 19 ++
hw/fsi/fsi.c | 87 +++-
hw/fsi/trace-events | 2 +
3 files changed, 106 insertions(+), 2
Documentation for IBM FSI model.
Signed-off-by: Ninad Palsule
---
v11:
- Removed Cedri's signoff.
---
docs/specs/fsi.rst | 138 +++
docs/specs/index.rst | 1 +
2 files changed, 139 insertions(+)
create mode 100644 docs/specs/fsi.rst
diff --git
Added basic qtests for FSI model.
Acked-by: Thomas Huth
Signed-off-by: Ninad Palsule
---
v11:
- Removed Cedric's signoff
---
tests/qtest/aspeed-fsi-test.c | 205 ++
tests/qtest/meson.build | 1 +
2 files changed, 206 insertions(+)
create mode 100644
fsi_master_realize()
- dropped FSIBus definition ]
Signed-off-by: Ninad Palsule
---
v9:
- Initialized registers.
- Fixed the address check.
v11:
- Replaced for loop with memset.
- Removed Joel's review tag as per Cedric.
---
include/hw/fsi/fsi-master.h | 32 +++
hw/fsi/fsi
- removed lbus_create_device() bc used only once
- removed "address" property
- updated meson.build to build fsi dir
- included an empty hw/fsi/trace-events ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Changed LBUS memory reg
- reworked fsi_cfam_realize() ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Added more registers to scratchpad
- Removed unnecessary address space
- Removed unnecessary header file
- Defined macros for config values.
- Cleaned up cfam config read.
---
include/hw/fsi/cf
Added maintainer for IBM FSI model
Signed-off-by: Ninad Palsule
---
v11:
- Added Cedric as reviewer.
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dfaca8323e..39deb8ee1f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3585,6
. The scratch pad is managed under FSI CFAM state.
Signed-off-by: Andrew Jeffery
[ clg: - moved object FSIScratchPad under FSICFAMState
- moved FSIScratchPad code under cfam.c ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi/lbus.h | 11 +++
hw/fsi
igned-off-by: Cédric Le Goater
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/arm/aspeed_soc.h | 4
hw/arm/aspeed_ast2600.c | 19 +++
2 files changed, 23 insertions(+)
diff --git a/include/hw/arm/aspeed_s
definition
- dropped hw/fsi/trace-events changes ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v11:
- Split the patch.
---
include/hw/fsi/fsi.h | 19 +++
hw/fsi/fsi.c | 22 ++
hw/fsi/meson.build | 2 +-
3 files changed, 42
Unexpected Pass:0
Skipped:9
Timeout:0
Ninad Palsule (11):
hw/fsi: Introduce IBM's Local bus
hw/fsi: Introduce IBM's scratchpad device
hw/fsi: Introduce IBM's FSI Bus
hw/fsi: Introduce IBM's fsi-slave model
hw/fsi: Introduce IBM's cfam
hw/fsi
object and fsi_opb_realize()
- simplified OPBus ]
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Removed unused parameters from function.
- Used qdev_realize() instead of qdev_realize_and_undef
- Given a name to the opb memory region.
v10:
- Combine Aspeed
Hello Cedric,
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
Reviewed-by: Joel Stanley
Nah. Joel you should re-review next respin :)
Removed Joel's review tag.
---
include/hw/misc/aspeed-apb2opb.h | 50 +
hw/misc/aspeed-apb2opb.c
Hello Cedric,
[ clg: - moved object FSIScratchPad under FSICFAMState
- moved FSIScratchPad code under cfam.c
- introduced fsi_cfam_instance_init()
- reworked fsi_cfam_realize() ]
Move the list down before my S-o-b.
Done.
+
+/* Valid, slots, version, type, crc */
Hello Cedric,
The FSI slave: The slave is the terminal point of the FSI bus for
FSI symbols addressed to it. Slaves can be cascaded off of one
another. The slave's configuration registers appear in address space
of the CFAM to which it is attached.
Please add another patch.
Added new patch
Hello Cedric,
[ clg: - removed lbus_add_device() bc unused
- removed lbus_create_device() bc used only once
- removed "address" property
- updated meson.build to build fsi dir
- included an empty hw/fsi/trace-events ]
this list of modifications should be
Hello Cedric,
[ clg: - move FSICFAMState object under FSIMasterState
- introduced fsi_master_init()
- reworked fsi_master_realize()
- dropped FSIBus definition ]
Move the list down before my S-o-b.
Done.
Signed-off-by: Andrew Jeffery
Reviewed-by: Joel Stanley
Hi Cedric,
On 1/12/24 10:02, Cédric Le Goater wrote:
On 1/11/24 00:15, Ninad Palsule wrote:
Added basic qtests for FSI model.
Acked-by: Thomas Huth
Signed-off-by: Cédric Le Goater
Please remove mu S-o-b.
Removed.
Thanks for the review.
Regards,
Ninad
Hello Cedric,
On 1/12/24 10:02, Cédric Le Goater wrote:
On 1/11/24 00:15, Ninad Palsule wrote:
Documentation for IBM FSI model.
Signed-off-by: Cédric Le Goater
Please remove mu S-o-b.
Removed.
Thanks for the review.
Regards,
Ninad
Hello Cedric,
On 1/12/24 10:03, Cédric Le Goater wrote:
On 1/11/24 00:15, Ninad Palsule wrote:
Added maintainer for IBM FSI model
Signed-off-by: Cédric Le Goater
Please remove my S-o-b.
Removed.
F: tests/qtest/isl_pmbus_vr-test.c
+FSI
+M: Ninad Palsule
and add me as Reviewer
Documentation for IBM FSI model.
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
docs/specs/fsi.rst | 138 +++
docs/specs/index.rst | 1 +
2 files changed, 139 insertions(+)
create mode 100644 docs/specs/fsi.rst
diff --git a/docs
Hello Cedric,
include/hw/fsi/aspeed-apb2opb.h | 34
aspeed-apb2opb is a HW logic bridging the FSI world and Aspeed. It
doesn't belong to the FSI susbsytem. Since we don't have a directory
for platform specific devices, I think the model shoud go under hw/misc/.
Moved it to hw/misc
Added maintainer for IBM FSI model
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 00ec1f7eca..79f97a3fb9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3569,6 +3569,14 @@ F
by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Added more registers to scratchpad
- Removed unnecessary address space
- Removed unnecessary header file
- Defined macros for config values.
- Cleaned up cfam config read.
---
include/hw/fsi/cf
- removed "address" property
- updated meson.build to build fsi dir
- included an empty hw/fsi/trace-events ]
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Changed LBUS memory region to 1MB.
---
meson.build
()
- simplified OPBus ]
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
Reviewed-by: Joel Stanley
---
v9:
- Removed unused parameters from function.
- Used qdev_realize() instead of qdev_realize_and_undef
- Given a name to the opb memory region
Added basic qtests for FSI model.
Acked-by: Thomas Huth
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
tests/qtest/aspeed-fsi-test.c | 205 ++
tests/qtest/meson.build | 1 +
2 files changed, 206 insertions(+)
create mode 100644 tests
]
Signed-off-by: Andrew Jeffery
Reviewed-by: Joel Stanley
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Initialized registers.
- Fixed the address check.
---
include/hw/fsi/fsi-master.h | 32 +++
hw/fsi/fsi-master.c | 173
option to 2
Ninad Palsule (9):
hw/fsi: Introduce IBM's Local bus and scratchpad
hw/fsi: Introduce IBM's FSI Bus and FSI slave
hw/fsi: Introduce IBM's cfam
hw/fsi: Introduce IBM's FSI master
hw/fsi: Aspeed APB2OPB interface, Onchip perif bus
hw/arm: Hook up FSI module in AST2600
hw/fsi
-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi/fsi.h | 38 +++
hw/fsi/fsi.c | 111 +++
hw/fsi/meson.build | 2 +-
hw/fsi/trace-events | 2 +
4 files changed, 152 insertions(+), 1 deletion(-)
create mode
es of GPIO IRQs into FSI symbols, and
calling the associated symbol method on the slave to map the access onto
the CFAM.
Testing:
Tested by reading cfam config address 0 on rainier machine type.
root@p10bmc:~# pdbg -a getcfam 0x0
p0: 0x0 = 0xc0022d15
Signed-off-by: Andrew Jeffery
/fsi/trace-events changes ]
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
include/hw/fsi/fsi.h | 19 +++
hw/fsi/fsi.c | 22 ++
hw/fsi/Kconfig | 3 +++
hw/fsi/meson.build | 1 +
4 files changed
lbus_create_device() bc used only once
- removed "address" property
- updated meson.build to build fsi dir
- included an empty hw/fsi/trace-events ]
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Changed LBUS memory reg
Hello,
Please review the patch-set version 9.
I have incorporated review comments from Cedric.
Ninad Palsule (10):
hw/fsi: Introduce IBM's Local bus
hw/fsi: Introduce IBM's FSI Bus
hw/fsi: Introduce IBM's cfam,fsi-slave,scratchpad
hw/fsi: IBM's On-chip Peripheral Bus
hw/fsi: Introduce
te.
[ clg: - moved object FSIScratchPad under FSICFAMState
- moved FSIScratchPad code under cfam.c
- introduced fsi_cfam_instance_init()
- reworked fsi_cfam_realize() ]
Signed-off-by: Andrew Jeffery
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
-
Documentation for IBM FSI model.
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
docs/specs/fsi.rst | 138 +++
docs/specs/index.rst | 1 +
2 files changed, 139 insertions(+)
create mode 100644 docs/specs/fsi.rst
diff --git a/docs
]
Signed-off-by: Andrew Jeffery
Reviewed-by: Joel Stanley
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
v9:
- Initialized registers.
- Fixed the address check.
---
include/hw/fsi/fsi-master.h | 32 +++
hw/fsi/fsi-master.c | 173
Added maintainer for IBM FSI model
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 00ec1f7eca..79f97a3fb9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3569,6 +3569,14 @@ F
Added basic qtests for FSI model.
Acked-by: Thomas Huth
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad Palsule
---
tests/qtest/aspeed-fsi-test.c | 205 ++
tests/qtest/meson.build | 1 +
2 files changed, 206 insertions(+)
create mode 100644 tests
of an MMIO-mapping of the CFAM address straight onto a
sub-region of the OPB address space.
[ clg: - removed FSIMasterState object and fsi_opb_realize()
- simplified OPBus ]
Signed-off-by: Andrew Jeffery
Reviewed-by: Joel Stanley
Signed-off-by: Cédric Le Goater
Signed-off-by: Ninad
-off-by: Ninad Palsule
---
v9:
- Removed unused parameters from function.
- Used qdev_realize() instead of qdev_realize_and_undef
---
include/hw/fsi/aspeed-apb2opb.h | 34
hw/fsi/aspeed-apb2opb.c | 314
hw/arm/Kconfig | 1 +
hw
es of GPIO IRQs into FSI symbols, and
calling the associated symbol method on the slave to map the access onto
the CFAM.
Testing:
Tested by reading cfam config address 0 on rainier machine type.
root@p10bmc:~# pdbg -a getcfam 0x0
p0: 0x0 = 0xc0022d15
Signed-off-by: Andrew Jeffery
Hello Cedric,
+
+#define TYPE_FSI_SCRATCHPAD "fsi.scratchpad"
+#define SCRATCHPAD(obj) OBJECT_CHECK(FSIScratchPad, (obj),
TYPE_FSI_SCRATCHPAD)
+
+typedef struct FSIScratchPad {
+ FSILBusDevice parent;
+
+ uint32_t reg;
+} FSIScratchPad;
We could extend to 4 regs possibly.
Hello Cedric,
+ for (i = 0; i < ASPEED_FSI_NUM; i++) {
+ if (!qdev_realize_and_unref(DEVICE(>fsi[i]),
BUS(>opb[i]),
s->fsi[i] is not allocated. We should use qdev_realize instead.
I am not sure I understood this. FSIMasterState fsi[ASPEED_FSI_NUM];
is inside structure
Hello Cedric,
+static uint64_t fsi_master_read(void *opaque, hwaddr addr, unsigned
size)
+{
+ FSIMasterState *s = FSI_MASTER(opaque);
+
+ trace_fsi_master_read(addr, size);
+
+ if (addr + size > sizeof(s->regs)) {
See comment on patch 3
I fixed it.
+
Hello Cedric,
On 12/12/23 08:46, Cédric Le Goater wrote:
On 11/29/23 00:56, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The LBUS is modelled to maintain mapped memory for the devices. The
memory is mapped after CFAM config, peek table
Hello Cedric,
On 12/12/23 08:48, Cédric Le Goater wrote:
On 11/29/23 00:56, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The On-Chip Peripheral Bus (OPB): A low-speed bus typically found in
POWER processors. This now makes
Hello Cedric,
On 12/12/23 08:49, Cédric Le Goater wrote:
On 11/29/23 00:56, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
An APB-to-OPB bridge enabling access to the OPB from the ARM core in
the AST2600. Hardware limitations prevent
Hello Cedric,
On 11/29/23 15:29, Cédric Le Goater wrote:
On 11/29/23 15:56, Ninad Palsule wrote:
Hello Cedric,
On 11/27/23 10:31, Cédric Le Goater wrote:
Hello Ninad,
On 10/26/23 18:47, Ninad Palsule wrote:
Hello,
Please review the patch-set version 7.
I have incorporated review comments
Hello Cedric,
On 11/27/23 10:31, Cédric Le Goater wrote:
Hello Ninad,
On 10/26/23 18:47, Ninad Palsule wrote:
Hello,
Please review the patch-set version 7.
I have incorporated review comments from Cedric, Philippe and Thomas.
I reworked v7 with the suggestions I made in patches 1-6
Added maintainer for IBM FSI model
Signed-off-by: Ninad Palsule
Signed-off-by: Cédric Le Goater
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 695e0bd34f..0536b585fc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3558,6 +3558,14 @@ F
es of GPIO IRQs into FSI symbols, and
calling the associated symbol method on the slave to map the access onto
the CFAM.
Testing:
Tested by reading cfam config address 0 on rainier machine type.
root@p10bmc:~# pdbg -a getcfam 0x0
p0: 0x0 = 0xc0022d15
Signed-off-by: Andrew Jeffery
Si
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The LBUS is modelled to maintain mapped memory for the devices. The
memory is mapped after CFAM config, peek table and FSI slave registers.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
[ clg
of an MMIO-mapping of the CFAM address straight onto a
sub-region of the OPB address space.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
Reviewed-by: Joel Stanley
[ clg: - removed FSIMasterState object and fsi_opb_realize()
- simplified OPBus ]
Signed-off-by: Cédric Le Goater
-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
[ clg: - moved FSIMasterState under AspeedAPB2OPBState
- modified fsi_opb_fsi_master_address() and
fsi_opb_opb2fsi_address()
- instroduced fsi_aspeed_apb2opb_init()
- reworked fsi_aspeed_apb2opb_realize() ]
Signed-off
Hello,
Please review the patch-set version 8.
I have incorporated review comments from Cedric.
- Fixed checkpatch failures.
- Fixed commit messages.
- Fixed LBUS memory map size.
Ninad Palsule (10):
hw/fsi: Introduce IBM's Local bus
hw/fsi: Introduce IBM's FSI Bus
hw/fsi: Introduce
Added basic qtests for FSI model.
Signed-off-by: Ninad Palsule
Acked-by: Thomas Huth
Signed-off-by: Cédric Le Goater
---
tests/qtest/aspeed-fsi-test.c | 205 ++
tests/qtest/meson.build | 1 +
2 files changed, 206 insertions(+)
create mode 100644 tests
This is a part of patchset where FSI bus is introduced.
The FSI bus is a simple bus where FSI master is attached.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
[ clg: - removed include/hw/fsi/engine-scratchpad.h and
hw/fsi/engine-scratchpad.c
- dropped
e.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
[ clg: - moved object FSIScratchPad under FSICFAMState
- moved FSIScratchPad code under cfam.c
- introduced fsi_cfam_instance_init()
- reworked fsi_cfam_realize() ]
Signed-off-by: Cédric Le Goater
---
include/hw/
chip. At the
hardware level FSI is a bit-based protocol supporting synchronous and
DMA-driven accesses of engines in a CFAM.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
Reviewed-by: Joel Stanley
[ clg: - move FSICFAMState object under FSIMasterState
- introduced
Documentation for IBM FSI model.
Signed-off-by: Ninad Palsule
Signed-off-by: Cédric Le Goater
---
docs/specs/fsi.rst | 138 +++
docs/specs/index.rst | 1 +
2 files changed, 139 insertions(+)
create mode 100644 docs/specs/fsi.rst
diff --git a/docs
Hello Cedric,
On 11/27/23 10:31, Cédric Le Goater wrote:
Hello Ninad,
On 10/26/23 18:47, Ninad Palsule wrote:
Hello,
Please review the patch-set version 7.
I have incorporated review comments from Cedric, Philippe and Thomas.
I reworked v7 with the suggestions I made in patches 1-6
Hello Cedric,
On 11/27/23 10:25, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
An APB-to-OPB bridge enabling access to the OPB from the ARM core in
the AST2600. Hardware limitations prevent
Hello Cedric,
On 11/27/23 10:23, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The On-Chip Peripheral Bus (OPB): A low-speed bus typically found in
POWER processors. This now makes an appearance
Hello Cedric,
On 11/27/23 10:19, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
This commit models the FSI bus. CFAM is hanging out of FSI bus. The bus
is model such a way that it is embedded
Hello Cedric,
On 11/27/23 10:31, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The Common FRU Access Macro (CFAM), an address space containing
various "engines" that drive accesses
Hello Cedric,
On 11/27/23 10:16, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The Common FRU Access Macro (CFAM), an address space containing
various "engines" that drive accesses
Hello Cedric,
On 11/27/23 10:09, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where scratchpad is introduced.
The scratchpad provides a set of non-functional registers. The firmware
is free to use them, hardware does not support any special
Hello Cedric,
On 11/27/23 10:30, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The LBUS is modelled to maintain the qdev bus hierarchy and to take
advantage of the object model to automatically
Hello Cedric,
On 11/27/23 10:04, Cédric Le Goater wrote:
On 10/26/23 18:47, Ninad Palsule wrote:
This is a part of patchset where IBM's Flexible Service Interface is
introduced.
The LBUS is modelled to maintain the qdev bus hierarchy and to take
advantage of the object model to automatically
of an MMIO-mapping of the CFAM address straight onto a
sub-region of the OPB address space.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
Reviewed-by: Joel Stanley
---
v2:
- Incorporated review comment by Joel.
v5:
- Incorporated review comments by Cedric.
v6:
- Incorporated review
es of GPIO IRQs into FSI symbols, and
calling the associated symbol method on the slave to map the access onto
the CFAM.
Testing:
Tested by reading cfam config address 0 on rainier machine type.
root@p10bmc:~# pdbg -a getcfam 0x0
p0: 0x0 = 0xc0022d15
Signed-off-by: Andrew Jeffery
Sig
Added basic qtests for FSI model.
Signed-off-by: Ninad Palsule
Acked-by: Thomas Huth
---
v3:
- Added new qtest as per Cedric's comment.
V4:
- Remove MAINTAINER and documentation changes from this commit
v6:
- Incorporated review comments by Thomas Huth.
v7:
- Incorporated review comments
, The LBUS device is parent for the scratchpad.
Signed-off-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
---
v2:
- Incorporated Joel's review comments.
v5:
- Incorporated review comments by Cedric.
v6:
- Incorporated review comments by Daniel.
v7:
- Incorporated review comments by Philippe.
- Cleaned
Added maintainer for IBM FSI model
Signed-off-by: Ninad Palsule
---
V4:
- Added separate commit for MAINTAINER change.
V5:
- Use * instead of listing all files in dir
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index d36aa44661
-by: Andrew Jeffery
Signed-off-by: Ninad Palsule
---
v2:
- Incorporated review comments by Joel
v3:
- Incorporated review comments by Thomas Huth
v4:
- Compile FSI with ASPEED_SOC only.
v5:
- Incorporated review comments by Cedric.
v6:
- Incorporated review comments by Cedric.
v7:
- Incorporated
1 - 100 of 310 matches
Mail list logo
