Re: [Qemu-devel] [PATCH 8/8] slirp: VMStatify remaining except for loop

Hello, Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:17 +0100, wrote: > This converts the remaining components, except for the loop, to VMState. > > +/* TODO: Add loop */ > +VMSTATE_UINT16_V(ip_id, Slirp, 2), > +VMSTATE_STRUCT_ARRAY(bootp_clients, Slirp,

Re: [Qemu-devel] [PATCH 7/8] slirp: VMStatify socket level

Hello, Dr. David Alan Gilbert (git), on Thu 27 Oct 2016 16:32:16 +0100, wrote: > -case AF_INET: > -qemu_put_be32(f, so->so_faddr.s_addr); > -qemu_put_be16(f, so->so_fport); > -break; > +if (version_id >= 4 && !is_inet) { > +error_report("%s: so_ffamily

Re: [Qemu-devel] [PATCH 6/8] slirp: VMStatify sbuf

e offsets based on the pointers. > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> Acked-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > slirp/sbuf.h | 4 +- > slirp/slirp.c | 116

[Qemu-devel] [PATCH 1/2] iconv: detect and make curses depend on it

curses will use it for proper wide output support. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- configure | 40 vl.c | 2 +- 2 files changed, 41 insertions(+), 1 deletion(-) diff --git a/configure b/configure index f

[Qemu-devel] [PATCH 2/2] curses: add option to specify VGA font encoding

This uses iconv to convert glyphs from the specified VGA font encoding to unicode, and makes use of cchar_t instead of chtype when using ncursesw, which allows to store all wide char as well as the WACS values. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- con

[Qemu-devel] [PATCHv2 0/2] curses: use wide output functions

Hello, This is a respin of the output part of curses wide output. - curses has been made to now depend on iconv - this allowed to just always use iconv, including to convert from the default CP437 encoding. - this also avoids the problematic usage of L'\u'. Samuel Thibault (2): iconv

[Qemu-devel] [PATCH] curses: support wide input

value is a key code or a character (wide support), or possibly both (non-wide support). The translation tables thus also need to be separated into key code translation and character translation. The curses2foo helper makes it easier to use them. Signed-off-by: Samuel Thibault <samuel.thiba...@

[Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

in, which should be more than enough. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- rebased on master diff --git a/ui/curses.c b/ui/curses.c index 2e132a7..3599295 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -216,7 +216,7 @@ static void curses_refresh(DisplayChangeListene

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

Markus Armbruster, on Fri 28 Oct 2016 08:51:20 +0200, wrote: > Samuel Thibault <samuel.thiba...@gnu.org> writes: > > > Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: > >> http://www.thecodingforums.com/threads/wchar_t-is-useless.806149/#post-4398211 > >

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

Peter Maydell, on Thu 27 Oct 2016 17:52:17 +0100, wrote: > On 27 October 2016 at 17:36, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > > Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: > >> On 27 October 2016 at 16:58, Samuel Thibault <samuel.thiba...@gnu.or

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

Peter Maydell, on Thu 27 Oct 2016 17:14:52 +0100, wrote: > On 27 October 2016 at 16:58, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > > Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: > >> /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal >

Re: [Qemu-devel] [PATCH] curses: build with -std=gnu99

Gerd Hoffmann, on Thu 27 Oct 2016 17:55:47 +0200, wrote: > /home/kraxel/projects/qemu/ui/curses.c:627:18: error: universal > character names are only valid in C++ and C99 [-Werror] > case L'\u23bd': Another way could be to assume unicode encoding of wchar_t characters (which looks

Re: [Qemu-devel] [PATCH 0/5] curses: wide character support

ping > > accented > > letters, and it doesn't depend on patch 4. > > Hmm, seems #5 needs a rebase, doesn't apply cleanly. Here is a patch rebased on current master. Samuel commit c230fb0bee630a1a138acce542ba6ed4aabdc232 Author: Samuel Thibault <samuel.thiba...@ens-lyon.org> Date:

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

Gerd Hoffmann, on Wed 26 Oct 2016 14:51:00 +0200, wrote: > On Sa, 2016-10-15 at 19:24 +0200, Samuel Thibault wrote: > > Peter Maydell, on Wed 22 Jun 2016 21:49:04 +0100, wrote: > > > On 22 June 2016 at 16:44, Samuel Thibault <samuel.thiba...@ens-lyon.org> > > >

Re: [Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device

Gerd Hoffmann, on Wed 26 Oct 2016 14:37:14 +0200, wrote: > On So, 2016-10-23 at 21:54 +0200, Samuel Thibault wrote: > > Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > > Hmm, this one throws strange errors at me: > > kraxel@nilsson ~/projects

Re: [Qemu-devel] [PATCH 0/5] curses: wide character support

Hello, Gerd Hoffmann, on Wed 26 Oct 2016 12:05:55 +0200, wrote: > Back online now after being sick for a while. Oh, sorry about that, hoping you're fine. > > Samuel Thibault, on Sat 15 Oct 2016 21:53:03 +0200, wrote: > > > This patch series adds wide character support to t

Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

Hello, Gerd Hoffmann, on Wed 26 Oct 2016 12:17:44 +0200, wrote: > On So, 2016-10-23 at 21:54 +0200, Samuel Thibault wrote: > > This adds two console functions, qemu_console_set_window_id and > > qemu_graphic_console_get_window_id, to let graphical backend record th

Re: [Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

Hello, It seems that in the flurry of qemu-devel mails, I missed this answer. Paolo Bonzini wrote: > > +#ifdef CONFIG_ICONV > > +if (font_charset) { > > +unsigned char ch; > > +wchar_t wch; > > +char *pch, *pwch; > > +size_t sch, swch; > > +iconv_t

Re: [Qemu-devel] [PATCH 0/5] curses: wide character support

Hello, Ping? Samuel Thibault, on Sat 15 Oct 2016 21:53:03 +0200, wrote: > This patch series adds wide character support to the curses frontend of qemu, > thus allowing to fix a lot of input and output issues with e.g. accented > letters > and semi-graphic glyphs. Since qem

[Qemu-devel] [PATCH 2/3] Defer BrlAPI tty acquisition to when guest starts using device

We do not want to catch the BrlAPI input/ouput immediately, but only when the guest has started discussing withour virtual device. This notably fixes input before the guest driver has started. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.

[Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.c | 234 +++- 1 file changed, 130 insertions(+), 104 deletions(-) diff --git a/backends/baum.c b/backends/baum.c index c537141..9f9f7c0 100644 --- a/backends/

[Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

and Gtk versions of the code. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.c | 25 +++-- include/ui/console.h | 3 +++ ui/console.c | 18 ++ ui/gtk.c | 25 +++-- ui

[Qemu-devel] [PATCHv2 0/3] baum driver update v2

This is a series of updates for the baum driver, to improve its integration of input/output and fix focus tracking with sdl2 and gtk backends. The difference with the previously-posted series is that it should fix the win32 build. Loads of thanks for having set up the build bot :) Samuel

[Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.c | 234 +++- 1 file changed, 130 insertions(+), 104 deletions(-) diff --git a/backends/baum.c b/backends/baum.c index c537141..9f9f7c0 100644 --- a/backends/

[Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend

and Gtk versions of the code. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.c | 20 +++- include/ui/console.h | 3 +++ ui/console.c | 18 ++ ui/gtk.c | 15 +-- ui/sdl.c

[Qemu-devel] [PATCH 0/3] baum driver update

by patch3. Samuel Thibault (3): Add dots keypresses support to the baum braille device Defer BrlAPI tty acquisition to when guest starts using device Move getting XWindow ID from baum driver to graphical backend backends/baum.c | 302

[Qemu-devel] [PATCH 2/3] Defer BrlAPI tty acquisition to when guest starts using device

We do not want to catch the BrlAPI input/ouput immediately, but only when the guest has started discussing withour virtual device. This notably fixes input before the guest driver has started. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- backends/baum.

[Qemu-devel] [PATCH 0/5] curses: wide character support

to specify the keyboard layout with -k). I used option -f to make it simple for now, but I welcome any other idea :) Samuel Samuel Thibault (5): curses: fix left/right arrow translation curses: Use cursesw instead of curses curses: use wide output functions curses: add option to specify VGA font

[Qemu-devel] [PATCH 5/5] curses: support wide input

value is a key code or a character (wide support), or possibly both (non-wide support). The translation tables thus also need to be separated into key code translation and character translation. The curses2foo helper makes it easier to use them. Signed-off-by: Samuel Thibault <samuel.thiba...@

[Qemu-devel] [PATCH 3/5] curses: use wide output functions

This makes use of cchar_t instead of chtype when using ncursesw, which allows to store a wide char as well as the WACS values. This also allows to complete the printable glyphs list beyond ascii and the ACS values. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- con

[Qemu-devel] [PATCH 2/5] curses: Use cursesw instead of curses

Use ncursesw package instead of curses on non-mingw, and check a few functions. Also take cflags from pkg-config, since cursesw headers may be in a separate, non-default directory. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- configure | 29 --

[Qemu-devel] [PATCH 1/5] curses: fix left/right arrow translation

In default VGA font, left/right arrow are glyphs 0x1a and 0x1b, not 0x0a and 0x0b. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index c8be4b7..3599295

[Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

This detects and uses iconv to convert glyphs from the specified VGA font encoding to unicode. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- configure | 37 + include/sysemu/sysemu.h | 1 + qemu-options.hx

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

Hello, Peter Maydell, on Wed 22 Jun 2016 21:49:04 +0100, wrote: > On 22 June 2016 at 16:44, Samuel Thibault <samuel.thiba...@ens-lyon.org> > wrote: > > By default, curses will only report single ESC key event after 1s delay, > > since ESC is also used for keypad escape

Re: [Qemu-devel] [PATCH 1/1] slirp: VMState conversion; tcpcb

ty. > > Tested with >-netdev user,id=unet,guestfwd=tcp:10.0.2.50:-tcp:localhost: > > with a nc hung off port and having the guest spew 'seq' > to the port. > > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Thanks, Samuel

Re: [Qemu-devel] SLIRP migration?

Hello, Dr. David Alan Gilbert, on Wed 28 Sep 2016 19:00:45 +0100, wrote: > I can see that migrating a VM with slirp makes sense (actually more > commonly saving a VM with slirp to a file); but when that happens > aren't you likely to lose all the network connections anyway? Yes. > If that's the

Re: [Qemu-devel] [PATCH] slirp: fix segv when init failed

etdev (net.c:1498) > ==18447==by 0x7F1F99: qemu_opts_foreach (qemu-option.c:1116) > ==18447==by 0x696E60: net_init_clients (net.c:1516) > ==18447== Address 0x0 is not stack'd, malloc'd or (recently) free'd > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.c

Re: [Qemu-devel] [PATCH for-2.7] slirp: Rename "struct arphdr" to "struct slirp_arphdr"

launchpad.net/qemu/+bug/1613133 > Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > slirp/slirp.c | 10 +- > slirp/slirp.h | 4 ++-- > 2 files changed, 7 insertions(+), 7 deletions(-) > >

[Qemu-devel] [PULL 5/6] slirp: Remove superfluous memset() calls from the TFTP code

t;m_size);" for the related buffer first. However, at two spots, the memset() was not removed from the calling function, so it currently done twice in these code paths. Thus let's delete these superfluous memsets in the calling functions now. Signed-off-by: Thomas Huth <th...@redhat.

[Qemu-devel] [PULL 2/6] slirp: Add dns6 resolution

This makes get_dns_addr address family-agnostic, thus allowing to add the IPv6 case. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/ip6.h | 9 +++ slirp/libslirp.h | 1 + slirp/sli

[Qemu-devel] [PULL 0/6] slirp: ipv6 dns & dhcp support

The following changes since commit 9a48e3670030148a8d00c8d4d4cd7f051c0d9f39: Added Bulgarian translation (2016-07-01 16:06:57 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 4/6] slirp: Add RDNSS advertisement

This adds the RDNSS option to IPv6 router advertisements, so that the guest can autoconfigure the DNS server address. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- Changes since last submission: - Disable on windows, u

[Qemu-devel] [PULL 6/6] slirp: Add support for stateless DHCPv6

et nic \ -net user,ipv6=yes,ipv4=no,tftp=/path/to/tftp,bootfile=ppc64.img Signed-off-by: Thomas Huth <th...@redhat.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/Makefile.objs | 2 +- slirp/dhcpv6.c | 209 +

[Qemu-devel] [PULL 3/6] slirp: Support link-local DNS addresses

They look like fe80::%eth0 Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- Changes since last submission: - fix windows build --- slirp/libslirp.h | 2 +- slirp/slirp.c| 32 +++- slirp/soc

[Qemu-devel] [PULL 1/6] slirp: Split get_dns_addr

Separate get_dns_addr into get_dns_addr_cached and get_dns_addr_resolv_conf to make conversion to IPv6 easier. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/slirp.c | 53 ++--

Re: [Qemu-devel] [PATCH v2] slirp: Add support for stateless DHCPv6

Hello, Thomas Huth, on Tue 28 Jun 2016 12:48:31 +0200, wrote: > Provide basic support for stateless DHCPv6 (see RFC 3736) so > that guests can also automatically boot via IPv6 with SLIRP > (for IPv6 network booting, see RFC 5970 for details). > > Tested with: > > qemu-system-ppc64

Re: [Qemu-devel] [PATCH] slirp: Add support for stateless DHCPv6

Thomas Huth, on Tue 28 Jun 2016 09:01:50 +0200, wrote: > The options in the DHCPv6 packet do not have any alignment > requirement, so the can also start at uneven addresses. Aow, OK :/ > So I'd like to keep the current code, but I can add some more comments > if you think that helps to

Re: [Qemu-devel] [PATCH] slirp: Add support for stateless DHCPv6

Hello, Thomas Huth, on Sun 26 Jun 2016 10:04:02 +0200, wrote: > Provide basic support for stateless DHCPv6 (see RFC 3736) so > that guests can also automatically boot via IPv6 with SLIRP > (for IPv6 network booting, see RFC 5970 for details). Cool :) I'm here commenting in my reading order, not

Re: [Qemu-devel] [PATCH] slirp: Remove superfluous memset() calls from the TFTP code

> > Signed-off-by: Thomas Huth <th...@redhat.com> Thanks! Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> > --- > slirp/tftp.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/slirp/tftp.c b/slirp/tftp.c > index 12b5ff6..3673

[Qemu-devel] [PATCH 3/5] curses: use wide output functions

This makes use of cchar_t instead of chtype when using ncursesw, which allows to store a wide char as well as the WACS values. This also allows to complete the printable glyphs list beyond ascii and the ACS values. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- hw/d

[Qemu-devel] [PATCH 1/5] curses: fix left/right arrow translation

In default VGA font, left/right arrow are glyphs 0x1a and 0x1b, not 0x0a and 0x0b. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 49d3ce6..438b8be

[Qemu-devel] [PATCH 4/5] curses: add option to specify VGA font encoding

This detects and uses iconv to convert glyphs from the specified VGA font encoding to unicode. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- configure | 37 + include/sysemu/sysemu.h | 1 + qemu-options.hx

[Qemu-devel] [PATCH 2/5] curses: Use cursesw when available

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- configure | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 10cb212..ff10012 100755 --- a/configure +++ b/con

[Qemu-devel] [PATCH 5/5] curses: support wide input

value is a key code or a character (wide support), or possibly both (non-wide support). The translation tables thus also need to be separated into key code translation and character translation. The curses2foo helper makes it easier to use them. Signed-off-by: Samuel Thibault <samuel.thiba...@

[Qemu-devel] [PATCH 0/5] curses: wide character support

to specify the keyboard layout with -k). I used option -f to make it simple for now, but I welcome any other idea :) Samuel Samuel Thibault (5): curses: fix left/right arrow translation curses: Use cursesw when available curses: use wide output functions curses: add option to specify VGA font

Re: [Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

Peter Maydell, on Wed 22 Jun 2016 21:49:04 +0100, wrote: > On 22 June 2016 at 16:44, Samuel Thibault <samuel.thiba...@ens-lyon.org> > wrote: > > By default, curses will only report single ESC key event after 1s delay, > > since ESC is also used for keypad escape seque

[Qemu-devel] [PATCH] Reduce curses escdelay from 1s to 0.2s

in, which should be more than enough. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- ui/curses.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/curses.c b/ui/curses.c index b475589..49d3ce6 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -222,7

[Qemu-devel] [PATCH] Document that curses usually needs -k option too

Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 17f15ad..ce535a9 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -306,7 +306,7 @@ STEXI @fin

Re: [Qemu-devel] [PATCH 12/16] slirp: Use DIV_ROUND_UP

Laurent Vivier, on Tue 31 May 2016 18:36:01 +0200, wrote: > Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). > > This patch is the result of coccinelle script > scripts/coccinelle/round.cocci > > Signed-off-by: Laurent Vivier <lviv...@redhat.com> Acked-by: Samue

[Qemu-devel] [PULL 4/4] slirp: Clean up osdep.h related header inclusions

edhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip6_icmp.c | 1 - slirp/ip_input.c | 1 - slirp/udp6.c | 1 - 3 files changed, 3 deletions(-) diff --git a/slirp/ip6_icmp.c b/slirp/ip6_icmp.c index

[Qemu-devel] [PULL 0/4] slirp updates

Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20160513-1' into staging (2016-05-13 13:39:38 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up to 9892663dc486755b5534ff8a77913edc5ea28c79

[Qemu-devel] [PULL 2/4] slirp: Remove obsolete backward-compatibility cruft

And we certainly also do not support Ultrix anymore, so no need to keep the code for this platform anymore. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- s

[Qemu-devel] [PULL 1/4] slirp: Clean up slirp_config.h

th <th...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp_config.h | 87 1 file changed, 87 deletions(-) diff --git a/slir

[Qemu-devel] [PULL 3/4] slirp: Remove some unused code from slirp.h

From: Thomas Huth <th...@redhat.com> These hunks are apparently not used anymore, so let's delete them. Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org>

Re: [Qemu-devel] [PATCH v2 08/23] slirp: fix guest network access with darwin host

Hello, Stefan Hajnoczi, on Mon 09 May 2016 13:07:52 +0100, wrote: > From: Samuel Thibault <samuel.thiba...@ens-lyon.org> > > On Darwin, connect, sendto and friends want the exact size of the sockaddr, > not more (and in particular, not sizeof(struct sockaddr_storaget)) >

[Qemu-devel] [PULL] slirp: fix guest network access with darwin host

. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: John Arbuckle <programmingk...@gmail.com> --- slirp/ip_icmp.c | 2 +- slirp/socket.c | 2 +- slirp/socket.h | 12 slirp/tcp_subr.c | 2 +- 4 files changed, 15 insertions(+), 3 deletions(-)

[Qemu-devel] [PULL] slirp: fix guest network access with darwin host

The following changes since commit 8d0d9b9f67d6bdee9eaec1e8c1222ad91dc4ac01: Update version for v2.6.0-rc3 release (2016-04-21 17:46:50 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

Hello, Peter wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full release. > > This is

[Qemu-devel] [PATCH] slirp: fix guest network access with darwin host

On darwin, connect, sendto and friends want the exact size of the sockaddr, not more. This adds the sockaddr_size helper to be used when passing a sockaddr size to such function, and makes use of it for sendto and connect calls. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

Programmingkid, on Wed 27 Apr 2016 20:25:26 -0400, wrote: > Found out which patch was causing problems. This one: > > commit 5379229a2708df3a1506113315214c3ce5325859 > Author: Guillaume Subiron > Date: Sat Dec 19 22:24:59 2015 +0100 > > slirp: Factorizing address

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

Programmingkid, on Wed 27 Apr 2016 20:25:26 -0400, wrote: > Found out which patch was causing problems. This one: > > commit 5379229a2708df3a1506113315214c3ce5325859 > Author: Guillaume Subiron > Date: Sat Dec 19 22:24:59 2015 +0100 > > slirp: Factorizing address

Re: [Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

Wei Liu, on Mon 18 Apr 2016 15:40:15 +0100, wrote: > This patch is already queued by Stefano. Ah, sorry, I missed it. Samuel

Re: [Qemu-devel] last call for bugs that need to be fixed for 2.6 release!

Hello, Peter wrote: > Hi; looking at http://wiki.qemu.org/Planning/2.6#Known_issues and > the mailing list we seem to be in reasonable shape for the 2.6 release. > I would ideally like the 2.6rc3 tarball which we will make later this > week to be the final one before full release. > > This is

[Qemu-devel] [PATCH] xenfb: Fix overzealous ring test

a normal condition and should not be excluded. From: Wei Liu <wei.l...@citrix.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Tested-by: Hao Xudong <xudong@intel.com> --- hw/display/xenfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/d

Re: [Qemu-devel] [PATCH for 2.6] wxx: Fix broken TCP networking (regression)

Hello, Stefan Weil, on Thu 14 Apr 2016 19:46:17 +0200, wrote: > Michael Fritscher reported that it is still slow, so > more fixes might be needed. Michael, what do you mean by "slow", the bandwidth, or the time to connect? Does it help if you disable ipv6? Samuel

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

hat we deliver the appropriate RST to the guest in this case. Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 2 +- slirp/tcp_inp

Re: [Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

Peter Maydell, on Thu 07 Apr 2016 11:37:45 +0100, wrote: > Thanks; Samuel, can I ask you to respin with that line added? Done so. Samuel

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo <steven+q...@steven676.net> Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by re

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

ias <edgar.igles...@xilinx.com> [ste...@steven676.net: coding style adjustments] Signed-off-by: Steven Luo <steven+q...@steven676.net> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c | 17 - 1 file changed, 16 insertions(+), 1 deletion

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo <steven+q...@steven676.net> Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tcp_subr.c | 7 +-- 1 file cha

[Qemu-devel] [PULL 2/4] slirp: avoid use-after-free in slirp_pollfds_poll() if soread() returns an error

From: Steven Luo <steven+q...@steven676.net> Samuel Thibault pointed out that it's possible that slirp_pollfds_poll() will try to use a socket even after soread() returns an error, resulting in an use-after-free if the socket was removed while handling the error. Avoid this by re

[Qemu-devel] [PULL 3/4] slirp: Propagate host TCP RST to the guest.

tyle adjustments] Signed-off-by: Steven Luo <steven+q...@steven676.net> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/slirp/socket.c b/slirp/socket.c index 7f022a6

[Qemu-devel] [PULL 0/4] slirp: deliver received TCP RSTs to the guest

The following changes since commit 7acbff99c6c285b3070bf0e768d56f511e2bf346: Update version for v2.6.0-rc1 release (2016-04-05 21:53:18 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault for you to fetch changes up

[Qemu-devel] [PULL 1/4] slirp: don't crash when tcp_sockclosed() is called with a NULL tp

From: Steven Luo <steven+q...@steven676.net> Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tcp_subr.c | 7 +-- 1 file cha

[Qemu-devel] [PULL 4/4] slirp: handle deferred ECONNREFUSED on non-blocking TCP sockets

hat we deliver the appropriate RST to the guest in this case. Signed-off-by: Steven Luo <steven+q...@steven676.net> Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 2 +- slirp/tcp_inp

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

Hello, Steven Luo, on Wed 06 Apr 2016 17:00:50 -0700, wrote: > That said, sorecvoob() also calls soread(), so I'd guess we need to > deal with the possibility that soread() frees the socket in that case > as well? Indeed, then sorecvoob() needs to return that information, so slirp_pollfds_poll

Re: [Qemu-devel] [PATCH 0/3] slirp: deliver received TCP RSTs to the guest

Hello, Thanks for this! ste...@steven676.net, on Tue 05 Apr 2016 17:13:58 -0700, wrote: > The second, > which fixes delivery of an RST interrupting an already-established TCP > connection, was submitted by Edgar Iglesias in 2008 and appears to have > been missed then. The last patch fixes the

[Qemu-devel] [PULL] slirp: Allow disabling IPv4 or IPv6

Add ipv4 and ipv6 boolean options, so the user can setup IPv4-only and IPv6-only network environments. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- net/slirp.c | 36 ++-- qapi-schem

[Qemu-devel] [PULL] slirp updates

The following changes since commit de1d099a448beb2ec39af4bd9ce4dd6452a18cb5: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault-2' into staging (2016-04-01 11:15:20 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel

Re: [Qemu-devel] [PATCH] slirp: Fix migration from older versions of QEMU to the current one

Samuel Thibault, on Fri 01 Apr 2016 00:00:43 +0200, wrote: > Just realizing... We'd need to add AF_INET6 cases here too, to be able > to save/restore a VM using ipv6 connections. That seems quite involved however, maybe we should postpone that to later? Samuel

[Qemu-devel] [PULL] slirp: Fix migration from older versions of QEMU to the current one

ration stream and by using the old behavior if we've detected version 3 or less. Signed-off-by: Thomas Huth <th...@redhat.com> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp.c | 44 ++-- 1 file changed, 26 insertions(+

[Qemu-devel] [PULL] slirp updates

MAINTAINERS: Delete invalid maintainer entries of the Exynos section (2016-03-31 18:21:01 +0100) are available in the git repository at: http://people.debian.org/~sthibault/qemu.git tags/samuel-thibault-2 for you to fetch changes up to eaf136f9a21e02a2f55346e44d2d88df37b2cde3: slirp

Re: [Qemu-devel] [PATCH] slirp: Fix migration from older versions of QEMU to the current one

t's fix > this by checking the version ID of the migration stream and by using > the old behavior if we've detected version 3 or less. > > Signed-off-by: Thomas Huth <th...@redhat.com> Reviewed-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Just realizing... We'd need to add AF

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 15:44:13 +0100, wrote: > if (get_dns6_addr(>sin6_addr, > >sin6_scope_id) < 0) { > ^ > In file included from > /home/petmay01/linaro/qemu-for-merges/slirp/slirp.h:99:0, > from

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 15:11:27 +0100, wrote: > On 31 March 2016 at 13:51, Samuel Thibault <samuel.thiba...@gnu.org> wrote: > > Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote: > >> On 31 March 2016 at 10:20, Samuel Thibault <samuel.thiba..

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Peter Maydell, on Thu 31 Mar 2016 13:47:28 +0100, wrote: > On 31 March 2016 at 10:20, Samuel Thibault <samuel.thiba...@ens-lyon.org> > wrote: > > Update version for v2.6.0-rc0 release (2016-03-30 19:25:40 +0100) > > > > are available in the git repository at: >

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 15:04:02 +0300, wrote: > 2016-03-31 15:03 GMT+03:00 Vasiliy Tolstov : > > This is debian. I'm use old patch for qemu-2.1.0. > > > May be my problem that my host system have ipv6 address but i'm not > able to connect to remote servers via

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 15:03:31 +0300, wrote: > 2016-03-31 14:57 GMT+03:00 Samuel Thibault <samuel.thiba...@gnu.org>: > > I'm surprised that the vm tries to access the network via ipv6 by > > default. Which OS is this? With the default fec0:: prefix, ipv4 &g

Re: [Qemu-devel] [PULL 0/5] ipv4-only and ipv6-only support

Vasiliy Tolstov, on Thu 31 Mar 2016 14:49:35 +0300, wrote: > Yes, i'm using older version of this patch and without working ipv6 on > host my vm tries to access network via ipv6 (prefered) and not able to > connect. I'm surprised that the vm tries to access the network via ipv6 by default. Which

<    6   7   8   9   10   11   12   13   14   15   >