[Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for produced frames

2015-12-19 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyo

[Qemu-devel] [PATCHv7 0/9] slirp: Adding IPv6 support to Qemu -net user mode

2015-12-19 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. The following patches first make some refactoring to make current code ready for IPv6, and do not change the behavior. The actual IPv6 support will then be submitted as a separate patch series. Difference with version 6 is: - Use

[Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic

2015-12-14 Thread Samuel Thibault
; Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 21 ++--- slirp/socket.h| 22 +- slirp/tcp_input.c | 20 +++- slirp/udp.c | 8 ++-- 4 files changed, 44 insertions(+), 27 deletions(-)

[Qemu-devel] [PATCH 1/9] slirp: goto bad in udp_input if sosendto fails

2015-12-14 Thread Samuel Thibault
patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Reviewed-by: Thomas Huth <th...@redhat.com> --- slirp/udp.c | 1 + 1 file changed, 1 insertion(+) di

[Qemu-devel] [PATCH 5/9] slirp: Factorizing address translation

2015-12-14 Thread Samuel Thibault
accept(), which performs the address translation when a connection is established on the host for port forwarding: if it comes from localhost, the host virtual address is used instead. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Sam

[Qemu-devel] [PATCH 9/9] slirp: Adding family argument to tcp_fconnect()

2015-12-14 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibaul

[Qemu-devel] [PATCH 4/9] slirp: Make Socket structure IPv6 compatible

2015-12-14 Thread Samuel Thibault
isting code is assured. The ss_family field of sockaddr_storage is declared after each socket creation. The whole structure is also saved/restored when a Qemu session is saved/restored. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-of

[Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.

[Qemu-devel] [PATCH 2/9] slirp: Generalizing and neutralizing ARP code

2015-12-14 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> Basically, this patch replaces "arp" by "resolution" every time "arp" means "mac resolution" and not specifically ARP. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <ma

[Qemu-devel] [PATCH 8/9] slirp: Make udp_attach IPv6 compatible

2015-12-14 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel

[Qemu-devel] [PATCHv6 0/9] slirp: Adding IPv6 support to Qemu -net user mode

2015-12-14 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. The following patches first make some refactoring to make current code ready for IPv6, and do not change the behavior. The actual IPv6 support will then be submitted as a separate patch series. Difference with version 5 is: -

[Qemu-devel] [PATCH 6/9] slirp: Factorizing and cleaning solookup()

2015-12-14 Thread Samuel Thibault
mplete socket list). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/socket.c| 37 - slirp/socket.h| 5 +++-- slirp/tcp_input.c | 13 ++

Re: [Qemu-devel] [PATCH 7/9] slirp: Add sockaddr_equal, make solookup family-agnostic

2015-12-14 Thread Samuel Thibault
Thomas Huth, on Mon 14 Dec 2015 21:17:19 +0100, wrote: > > + lhost.ss_family = AF_INET; > > + ((struct sockaddr_in *))->sin_addr = ti->ti_src; > > + ((struct sockaddr_in *))->sin_port = ti->ti_sport; > > + fhost.ss_family = AF_INET; > > + ((struct sockaddr_in *))->sin_addr = ti->ti_dst;

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > +default: > > +/* Do not assert while we don't manage IP6VERSION */ > > +/* assert(0); */ > > Not sure if we ever want to have an assert() here - since I assume this > could be triggered by the guest? No, this is

Re: [Qemu-devel] [PATCH 3/9] slirp: Adding address family switch for incoming frames

2015-12-14 Thread Samuel Thibault
Samuel Thibault, on Mon 14 Dec 2015 23:06:16 +0100, wrote: > Thomas Huth, on Mon 14 Dec 2015 18:50:49 +0100, wrote: > > > +default: > > > +/* Do not assert while we don't manage IP6VERSION */ > > > +/* assert(0); */ > > > > Not sur

Re: [Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 12:54:14 +0100, wrote: > > @@ -5,7 +5,7 @@ > > * terms and conditions of the copyright. > > */ > > > > -//#define DEBUG 1 > > +#define DEBUG 1 > > Please don't enable the debug code by default. Oops, sorry, that wasn't meant to be included in the patch

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > > +switch (iph->ip_v) { > > +case IPVERSION: > > if (iph->ip_dst.s_addr == 0) { > > /* 0.0.0.0 can not be a destination address, something went wrong, > > * avoid making it worse */ > > That indentation looks

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 14:43:42 +0100, wrote: > Anyway, it's IMHO a somewhat strange way to structure a patch ... maybe > it would be nicer to do it in one go instead (after splitting off the > arp_requested renaming)? Please discuss about it with the people who asked for it. I won't

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Just to explain. I'm fine with revamping the patches, provided that we eventually converge somewhere. What I'm afraid of is that splitting patches in yet more many pieces, revamping the code yet more (moving code into their own functions, etc.) will only make the patch series look even bigger

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 15:32:48 +0100, wrote: > So maybe it's better to do smaller steps instead: Would it for example > make sense to split the whole series into two parts - first a series > that does all the preparation and cleanup patches. And then once that > has been reviewed and

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Laszlo Ersek, on Fri 11 Dec 2015 16:40:32 +0100, wrote: > > Sounds good, ... then I'd suggest to sent the preparation patches > > separately next time and get them accepted first. > > And then the next reviewer will say, "nice, but it would be even nicer > to see what *motivates* these

Re: [Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2015-12-11 Thread Samuel Thibault
Hello, Thomas, this is the last refactoring patch which doesn't have a review yet, right? Samuel Samuel Thibault, on Fri 11 Dec 2015 01:15:17 +0100, wrote: > From: Guillaume Subiron <maet...@subiron.org> > > This patch factorizes some duplicate code into a new function, &g

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:29:44 +0100, wrote: > Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > > On 11/12/15 01:15, Samuel Thibault wrote: > > > From: Guillaume Subiron <maet...@subiron.org> > > > > > > This patch makes solookup(

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > I'll however have a look at introducing the optimizations etc. first, so > that both making solookup use sockaddr and introducing sockaddr_equal > looks natural. Yes, it seems to be working very nicely. Samuel

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Samuel Thibault, on Fri 11 Dec 2015 20:51:02 +0100, wrote: > Samuel Thibault, on Fri 11 Dec 2015 20:38:19 +0100, wrote: > > I'll however have a look at introducing the optimizations etc. first, so > > that both making solookup use sockaddr and introducing sockaddr_equal > > lo

Re: [Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 16:06:22 +0100, wrote: > On 11/12/15 01:15, Samuel Thibault wrote: > > From: Guillaume Subiron <maet...@subiron.org> > > > > This patch makes solookup() compatible with varying address families. Also, > > this function was

Re: [Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-11 Thread Samuel Thibault
Thomas Huth, on Fri 11 Dec 2015 14:38:44 +0100, wrote: > Also, I'd prefer if you could split this patch into two: One for > renaming the "arp_requested" field, and one for adding the additional > logic with the switch statement (since there are two different kind of > changes). Ok, at least it's

[Qemu-devel] [PATCH 09/18] qemu/timer.h : Adding function to second scale

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- in

[Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyo

[Qemu-devel] [PATCH 10/18] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2015-12-10 Thread Samuel Thibault
he RFC, to make the guest refresh its route. This also adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Sam

[Qemu-devel] [PATCH 15/18] slirp: Reindent after refactoring

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> No code change. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/tcp_input.c | 95 +++--- slirp

[Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2015-12-10 Thread Samuel Thibault
accept(), which performs the address translation when a connection is established on the host for port forwarding: if it comes from localhost, the host virtual address is used instead. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba.

[Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

2015-12-10 Thread Samuel Thibault
isting code is assured. The ss_family field of sockaddr_storage is declared after each socket creation. The whole structure is also saved/restored when a Qemu session is saved/restored. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba.

[Qemu-devel] [PATCH 03/18] slirp: Reindent after refactoring

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> No code change. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/slirp.c | 117 +- 1 file chan

[Qemu-devel] [PATCH 18/18] qapi-schema, qemu-options & slirp: Adding Qemu options for IPv6 addresses

2015-12-10 Thread Samuel Thibault
ec0::3. Signed-off-by: Yann Bordenave <m...@meowstars.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- net/net.c| 31 +++ net/slirp.c | 49 +++-- qap

[Qemu-devel] [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union

2015-12-10 Thread Samuel Thibault
margin computation in various functions, and makes them compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org&g

[Qemu-devel] [PATCH 17/18] slirp: Adding IPv6 address for DNS relay

2015-12-10 Thread Samuel Thibault
resses. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip6.h| 5 - slirp/slirp.c | 2 ++ slirp/slirp.h | 1 + slirp/socket.c | 35 --- 4 files changed, 3

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-12-10 Thread Samuel Thibault
inside the function (the function look at the last returned result before browsing the complete socket list). This also adds a sockaddr_equal() function to compare two sockaddr_storage. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba.

[Qemu-devel] [PATCHv5 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-12-10 Thread Samuel Thibault
Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Patches 1 to 8 are refactoring of existing code and do not change the behavior, 9 adds

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

2015-12-10 Thread Samuel Thibault
patch adds a goto bad to cut the execution of this function. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/debug.h | 2 +- slirp/udp.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

2015-12-10 Thread Samuel Thibault
From: Guillaume Subiron <maet...@subiron.org> A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...

[Qemu-devel] [PATCH 12/18] slirp: Adding IPv6 UDP support

2015-12-10 Thread Samuel Thibault
<maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/Makefile.objs | 2 +- slirp/ip6_input.c | 3 +- slirp/socket.c | 7 ++- slirp/socket.h | 6 +++ slirp/udp.h | 5 ++ slirp/u

[Qemu-devel] [PATCH 14/18] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2015-12-10 Thread Samuel Thibault
they are working on. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip_input.c | 2 +- slirp/slirp.c | 6 -- slirp/slirp.h | 5 +++-- slirp/tcp_input.c | 53

[Qemu-devel] [PATCH 11/18] slirp: Adding ICMPv6 error sending

2015-12-10 Thread Samuel Thibault
calls in various functions to send ICMP errors, when a received packet is too big, or when its hop limit is 0. Signed-off-by: Yann Bordenave <m...@meowstars.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slir

[Qemu-devel] [PATCH 16/18] slirp: Handle IPv6 in TCP functions

2015-12-10 Thread Samuel Thibault
; Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/ip6_input.c | 4 ++-- slirp/tcp.h| 2 ++ slirp/tcp_input.c | 58 +- slirp/tcp_output.c | 16 +++ slirp/tcp_subr.c | 36 ++

[Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-12-10 Thread Samuel Thibault
xt patches (ip_input…). In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. Signed-off-by: Guillaume Subiron <maet...@subiron.org> Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> --- slirp/mbuf.c | 2 +- slirp/mbuf.h | 2 +- slirp/

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-12-01 Thread Samuel Thibault
Thomas Huth, on Tue 01 Dec 2015 22:28:10 +0100, wrote: > Are you still planning to rebase the patches again to current master and > repost them, so we could maybe get this in for QEMU 2.6 ? If we can get this reviewed, yes, sure! > If you put me on CC:, I can try to review the series if you like

Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation

2015-10-14 Thread Samuel Thibault
Paolo Bonzini, le Wed 14 Oct 2015 17:51:51 +0200, a écrit : > > > On 12/10/2015 17:41, Samuel Thibault wrote: > > Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a écrit : > >> Also, I assume that brlapi_perror() adds additional information to > >> the error mess

Re: [Qemu-devel] [PATCH 14/21] qemu-char: convert braille backend to data-driven creation

2015-10-12 Thread Samuel Thibault
Eric Blake, le Mon 12 Oct 2015 09:30:12 -0600, a écrit : > Also, I assume that brlapi_perror() adds additional information to > the error message it prints, such as conversion of a brlapi-specific > error message in the same manner in which perror() converts errno and in > which

Re: [Qemu-devel] SLIRP segfault?

2015-09-06 Thread Samuel Thibault
Hello, John Snow, le Wed 02 Sep 2015 14:01:07 -0400, a écrit : > There was a downstream bug filed against qemu-kvm-2.3.1-1.fc22.x86_64 > that appeared to segfault in the AHCI code when trying to install OSX > Yosemite. > > The debug output looked a little strange, so I asked for a new >

[Qemu-devel] [PATCH] baum: Fix build with debugging enabled

2015-08-30 Thread Samuel Thibault
cur and buf are pointers, so the difference can be a long int on 64bit platforms. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b/backends/baum.c index a69aaff..0fa8025 100644 --- a/backends/baum.c +++ b/backends/baum.c @@ -303,7 +303,7 @@ static int

[Qemu-devel] [PATCH] baum: Add support for typing ascii

2015-08-30 Thread Samuel Thibault
This adds support for typing ascii through the Baum Braille driver, by translating it to braille with the NABCC table. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b/backends/baum.c index a69aaff..d486e68 100644 --- a/backends/baum.c +++ b/backends

Re: [Qemu-devel] [PATCH] baum: Fix build with debugging enabled

2015-08-30 Thread Samuel Thibault
cur and buf are pointers, so the difference is a ptrdiff_t Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b/backends/baum.c index a69aaff..1f9288e 100644 --- a/backends/baum.c +++ b/backends/baum.c @@ -303,7 +303,7 @@ static int baum_eat_packet

Re: [Qemu-devel] [PATCH] baum: Fix build with debugging enabled

2015-08-30 Thread Samuel Thibault
Stefan Weil, le Sun 30 Aug 2015 16:38:25 +0200, a écrit : Am 30.08.2015 um 16:19 schrieb Samuel Thibault: cur and buf are pointers, so the difference can be a long int on 64bit platforms. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b

[Qemu-devel] [PATCHv2] baum: Add support for typing ascii

2015-08-30 Thread Samuel Thibault
This adds support for typing ascii through the Baum Braille driver, by translating it to braille with the NABCC table. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b/backends/baum.c index a69aaff..50e6e86 100644 --- a/backends/baum.c +++ b/backends

Re: [Qemu-devel] [PATCH] baum: Add support for typing ascii

2015-08-30 Thread Samuel Thibault
Hello, Peter Maydell, le Sun 30 Aug 2015 19:34:25 +0100, a écrit : +fprintf(stderr,passdots %x\n, dots); Should this be a DPRINTF ? D'oh. Sure. (Try scripts/checkpatch.pl.) Ah, I didn't remember there was one. Will use it. +if

[Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2015-08-06 Thread Samuel Thibault
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit : On 2015-07-29 00:12, Samuel Thibault wrote: Hello, Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : Of course, I'm fine with handing this over to someone

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Samuel Thibault
Jan Kiszka, le Wed 29 Jul 2015 09:39:06 +0200, a écrit : Make sure to add the proper From: of the actual author. Ok. Two of the patches are however from a different author, I haven't found how to specify different From addresses with git send-email. Also, some are signed-off by you, others

[Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2015-07-29 Thread Samuel Thibault
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit : On 2015-07-29 00:12, Samuel Thibault wrote: Hello, Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : Of course, I'm fine with handing this over to someone

Re: [Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-29 Thread Samuel Thibault
Jan Kiszka, le Wed 29 Jul 2015 09:58:36 +0200, a écrit : On 2015-07-29 09:47, Samuel Thibault wrote: Ok. Two of the patches are however from a different author, I haven't found how to specify different From addresses with git send-email. This knowledge is buried in scripts here, but IIRC

[Qemu-devel] [PATCH 16/18] slirp: Handle IPv6 in TCP functions

2015-07-28 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org

[Qemu-devel] [PATCH 01/18] slirp: goto bad in udp_input if sosendto fails

2015-07-28 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this

[Qemu-devel] [PATCH 07/18] slirp: Make udp_attach IPv6 compatible

2015-07-28 Thread Samuel Thibault
A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded AF_INET to call qemu_socket(). Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/ip_icmp.c | 2 +- slirp/udp.c | 7 --- slirp/udp.h | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH 12/18] slirp: Adding IPv6 UDP support

2015-07-28 Thread Samuel Thibault
This adds the sin6 case in the fhost and lhost unions and related macros. It adds udp6_input() and udp6_output(). It adds the IPv6 case in sorecvfrom(). Finally, udp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/Makefile.objs | 2 +-

[Qemu-devel] [PATCH 17/18] slirp: Adding IPv6 address for DNS relay

2015-07-28 Thread Samuel Thibault
...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/ip6.h| 5 - slirp/slirp.c | 2 ++ slirp/slirp.h | 1 + slirp/socket.c | 35 --- 4 files changed, 39 insertions(+), 4 deletions(-) diff --git a/slirp/ip6.h b/slirp/ip6.h index

[Qemu-devel] [PATCH 18/18] qapi-schema, qemu-options slirp: Adding Qemu options for IPv6 addresses

2015-07-28 Thread Samuel Thibault
...@meowstars.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- net/net.c| 31 +++ net/slirp.c | 46 -- qapi-schema.json | 40 ++-- qemu-options.hx | 18

[Qemu-devel] [PATCH 03/18] slirp: Reindent after refactoring

2015-07-28 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/slirp.c | 117 +- 1 file changed, 59 insertions(+), 58 deletions(-) diff --git a/slirp/slirp.c b

[Qemu-devel] [PATCH 02/18] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2015-07-28 Thread Samuel Thibault
is factorized. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/mbuf.c | 2 +- slirp/mbuf.h | 2 +- slirp/slirp.c | 24 3 files changed, 22 insertions(+), 6 deletions(-) diff --git a/slirp/mbuf.c b/slirp

[Qemu-devel] [PATCH 09/18] qemu/timer.h : Adding function to second scale

2015-07-28 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- include/qemu/timer.h | 32 1 file

[Qemu-devel] [PATCH 08/18] slirp: Adding family argument to tcp_fconnect()

2015-07-28 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded AF_INET in the call of qemu_socket(). Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 14/18] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2015-07-28 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to switch in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron

[Qemu-devel] [PATCH 11/18] slirp: Adding ICMPv6 error sending

2015-07-28 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a

[Qemu-devel] [PATCH 04/18] slirp: Make Socket structure IPv6 compatible

2015-07-28 Thread Samuel Thibault
This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The ss_family field of

[Qemu-devel] [PATCH 15/18] slirp: Reindent after refactoring

2015-07-28 Thread Samuel Thibault
No code change. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/slirp.h | 3 +- slirp/tcp_input.c | 95 +++--- slirp/tcp_output.c | 29 - slirp

[Qemu-devel] [PATCH 13/18] slirp: Factorizing tcpiphdr structure with an union

2015-07-28 Thread Samuel Thibault
compatible with the new tcpiphdr structure, whose size will be bigger than sizeof(struct tcphdr) + sizeof(struct ip) Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/if.h | 4 ++-- slirp/mbuf.c | 3 ++- slirp

[Qemu-devel] [PATCH 05/18] slirp: Factorizing address translation

2015-07-28 Thread Samuel Thibault
a connection is established on the host for port forwarding: if it comes from localhost, the host virtual address is used instead. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/bootp.c| 2 +- slirp/ip_icmp.c | 19

[Qemu-devel] [PATCH 06/18] slirp: Factorizing and cleaning solookup()

2015-07-28 Thread Samuel Thibault
This patch makes solookup() compatible with varying address families. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned

[Qemu-devel] [PATCHv4 00/18] slirp: Adding IPv6 support to Qemu -net user mode

2015-07-28 Thread Samuel Thibault
Samuel Thibault, le Wed 29 Jul 2015 00:13:57 +0200, a écrit : I can rebase the patch series over the current master and submit again the patches. Here it is: Hello, This is another respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6

[Qemu-devel] [PATCH 10/18] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2015-07-28 Thread Samuel Thibault
adds ip6_cksum() to compute ICMPv6 checksums using IPv6 pseudo-header. Some #define ETH_* are moved upper in slirp.h to make them accessible to other slirp/*.h Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- slirp/Makefile.objs

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-28 Thread Samuel Thibault
zhanghailiang, le Tue 21 Jul 2015 09:59:22 +0800, a écrit : I didn't find any news since that version, are you still trying to push them to qemu upstream ? I'd still be trying if I had any actual answer other than we need to find time to deal about it :) I can rebase the patch series over the

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-28 Thread Samuel Thibault
Hello, Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit : Of course, I'm fine with handing this over to someone who'd like to pick up. Do we have volunteers? Samuel, would you like to do this? As a subsystem maintainer, you are already familiar with QEMU processes. I can help with

Re: [Qemu-devel] [POC] colo-proxy in qemu

2015-07-27 Thread Samuel Thibault
Hello, I'm just back from vacancy with no Internet access, so will answer shortly :) Samuel

Re: [Qemu-devel] [PULL 18/19] usb: usb-serial QOMify

2015-05-10 Thread Samuel Thibault
Gerd Hoffmann, le Fri 08 May 2015 13:45:52 +0200, a écrit : From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Acked-by: Samuel Thibault samuel.thiba...@ens-lyon.org Tested-by: Samuel Thibault samuel.thiba

[Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Hello, I've written mostly all of usb-serial.c and baum.c, and keep maintaining them, since I use them regularly. Samuel

Re: [Qemu-devel] MAINTAINERS: please add myself as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Markus Armbruster, le Wed 22 Oct 2014 15:00:20 +0200, a écrit : Samuel Thibault samuel.thiba...@ens-lyon.org writes: I've written mostly all of usb-serial.c and baum.c, and keep maintaining them, since I use them regularly. Please post the obvious patch to MAINTAINERS then :) Well

Re: [Qemu-devel] [PATCH] MAINTAINERS: add Samuel Thibault as usb-serial.c and baum.c maintainer

2014-10-22 Thread Samuel Thibault
Paolo Bonzini, le Wed 22 Oct 2014 14:54:20 +0200, a écrit : He wrote I've written mostly all of usb-serial.c and baum.c, and keep maintaining them, since I use them regularly. Cc: Samuel Thibault samuel.thiba...@ens-lyon.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off

[Qemu-devel] [PATCH, braille]: Error out if the real braille device is not connected

2014-09-07 Thread Samuel Thibault
message to the user to understand what is happening. This change makes qemu refuse to configure the character device in such case, and let the user know what to fix. Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org diff --git a/backends/baum.c b/backends/baum.c index 759003f..f5fcdaa

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Hello, Vasiliy Tolstov, le Mon 21 Jul 2014 15:34:16 +0400, a écrit : Hello. I have now slirp qemu network with ipv4 address, but for tests i need also ipv6 addresses in slirp network. How can i provide this args for qemu via libvirt or (best) via qemu args? I found some commits about ipv6

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 15:42:54 +0400, a écrit : 2014-07-21 15:41 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: ? The support was submitted to the list, but not commited. You can find the patches on http://lists.gnu.org/archive/html/qemu-devel/2014-03/msg05731.html

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 15:59:53 +0400, a écrit : Does it possible to get this patches via git branch or by another way? As i see i can't get it via email because of html contents =( I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in the tosubmit branch. Samuel

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : 2014-07-21 16:06 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in the tosubmit branch. Inside packer (i'm try to build some centos 7 boxes) i have errors

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit : Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : 2014-07-21 16:06 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: I have pushed it to http://dept-info.labri.fr/~thibault/qemu-ipv6 , in the tosubmit branch

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 16:47:09 +0200, a écrit : Samuel Thibault, le Mon 21 Jul 2014 16:29:34 +0200, a écrit : Vasiliy Tolstov, le Mon 21 Jul 2014 18:19:17 +0400, a écrit : 2014-07-21 16:06 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: I have pushed it to http://dept

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 18:47:00 +0400, a écrit : 2014-07-21 18:29 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: A gdb backtrace would also be useful. Can you provide me info how can i get it from running qemu? As i understand i need to gdb load-symbol and specify debuging

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Mon 21 Jul 2014 23:22:39 +0400, a écrit : 2014-07-21 18:52 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: For instance, yes, but you probably want to try my patch before. Yes, patch fix issue. And now all works fine. Last question - is that possible to enable

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Tue 22 Jul 2014 00:12:23 +0400, a écrit : 2014-07-21 23:49 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: There's no current support for this, but that could be useful to add indeed. I hit another issue, but may be not related to the patch. In centos 7 (test

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Vasiliy Tolstov, le Tue 22 Jul 2014 00:19:46 +0400, a écrit : 2014-07-22 0:13 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: It is related to the patch. I have fixed it, and pushed a newer tosubmit branch. Nothing new in tosubmit branch I have regenerated the branch, you need

Re: [Qemu-devel] ipv6 slirp network

2014-07-21 Thread Samuel Thibault
Samuel Thibault, le Mon 21 Jul 2014 22:30:40 +0200, a écrit : Vasiliy Tolstov, le Tue 22 Jul 2014 00:19:46 +0400, a écrit : 2014-07-22 0:13 GMT+04:00 Samuel Thibault samuel.thiba...@gnu.org: It is related to the patch. I have fixed it, and pushed a newer tosubmit branch. Nothing new

[Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-07-11 Thread Samuel Thibault
Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut the execution of this

Re: [Qemu-devel] [PATCH] slirp: goto bad in udp_input if sosendto fails

2014-06-14 Thread Samuel Thibault
Jan Kiszka, le Thu 12 Jun 2014 07:47:25 +0200, a écrit : On 2014-06-11 10:55, Samuel Thibault wrote: Before this patch, if sosendto fails, udp_input is executed as if the packet was sent. This could cause memory leak. Cannot follow yet how this could leak (not saying I fully got what

<    9   10   11   12   13   14   15   16   >