[PATCH v1 0/1] aspeed/hace: Support AST1030 HACE

2022-05-02 Thread Steven Lee
Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE engine. Please help to review. Thanks, Steven Based-on: 20220426021120.28255-3-steven_...@aspeedtech.com ([v6,2/3] aspeed/hace: Support AST2600 HACE) Steven Lee (1): aspeed/hace: Support AST1030 HACE hw/misc

[PATCH v1 1/1] aspeed/hace: Support AST1030 HACE

2022-05-02 Thread Steven Lee
Per ast1030_v7.pdf, AST1030 HACE engine is identical to AST2600's HACE engine. Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 20 include/hw/misc/aspeed_hace.h | 2 ++ 2 files changed, 22 insertions(+) diff --git a/hw/misc/aspeed_hace.c b/hw/misc

[PATCH v6 1/3] aspeed/hace: Support HMAC Key Buffer register.

2022-04-25 Thread Steven Lee
Support HACE28: Hash HMAC Key Buffer Base Address Register. Signed-off-by: Troy Lee Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/misc/aspeed_hace.c | 7 +++ include/hw/misc/aspeed_hace.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/misc/aspeed_hace.c

[PATCH v6 2/3] aspeed/hace: Support AST2600 HACE

2022-04-25 Thread Steven Lee
-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 132 -- include/hw/misc/aspeed_hace.h | 4 ++ 2 files changed, 131 insertions(+), 5 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 59fe5bfca2..0f4059e6df 100644

[PATCH v6 0/3] aspeed/hace: Support AST2600 HACE

2022-04-25 Thread Steven Lee
login. - AST1030 with ASPEED zephyr SDK v1.04 - run `hash sha256` command in zephyr shell to verify aspeed hace. Please help to review. Thanks, Steven Changes in v6: - Bug fixes in reconstruct_iov(). Steven Lee (3): aspeed/hace: Support HMAC Key Buffer register. aspeed/hace: Support AST2600

[PATCH v6 3/3] tests/qtest: Add test for Aspeed HACE accumulative mode

2022-04-25 Thread Steven Lee
/sha256sum utilities without padding, i.e. only "abc" ascii text. Signed-off-by: Troy Lee Signed-off-by: Steven Lee Acked-by: Thomas Huth Reviewed-by: Joel Stanley --- tests/qtest/aspeed_hace-test.c | 145 + 1 file changed, 145 insertions(+) diff

Re: [PATCH v5 2/3] aspeed/hace: Support AST2600 HACE

2022-04-25 Thread Steven Lee
The 04/25/2022 21:46, Cédric Le Goater wrote: > On 4/22/22 07:19, Steven Lee wrote: > > +/** > > + * Check whether the request contains padding message. > > + * > > + * @param s aspeed hace state object > > + * @param iov iov of curre

[PATCH v5 0/3] aspeed/hace: Support AST2600 HACE

2022-04-21 Thread Steven Lee
in AspeedHACEState. Steven Lee (3): aspeed/hace: Support HMAC Key Buffer register. aspeed/hace: Support AST2600 HACE tests/qtest: Add test for Aspeed HACE accumulative mode hw/misc/aspeed_hace.c | 139 +-- include/hw/misc/aspeed_hace.h | 5 ++ tests/qtest

[PATCH v5 1/3] aspeed/hace: Support HMAC Key Buffer register.

2022-04-21 Thread Steven Lee
Support HACE28: Hash HMAC Key Buffer Base Address Register. Signed-off-by: Troy Lee Signed-off-by: Steven Lee Reviewed-by: Cédric Le Goater --- hw/misc/aspeed_hace.c | 7 +++ include/hw/misc/aspeed_hace.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/misc/aspeed_hace.c

[PATCH v5 2/3] aspeed/hace: Support AST2600 HACE

2022-04-21 Thread Steven Lee
-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 132 -- include/hw/misc/aspeed_hace.h | 4 ++ 2 files changed, 131 insertions(+), 5 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 59fe5bfca2..3164f6 100644

[PATCH v5 3/3] tests/qtest: Add test for Aspeed HACE accumulative mode

2022-04-21 Thread Steven Lee
/sha256sum utilities without padding, i.e. only "abc" ascii text. Signed-off-by: Troy Lee Signed-off-by: Steven Lee Acked-by: Thomas Huth Reviewed-by: Joel Stanley --- tests/qtest/aspeed_hace-test.c | 145 + 1 file changed, 145 insertions(+) diff

Re: [PATCH v4 2/3] aspeed/hace: Support AST2600 HACE

2022-04-20 Thread Steven Lee
The 04/20/2022 20:53, Cédric Le Goater wrote: > On 3/31/22 09:48, Steven Lee wrote: > > The aspeed ast2600 accumulative mode is described in datasheet > > ast2600v10.pdf section 25.6.4: > > 1. Allocating and initiating accumulative hash digest write buffer > &

[PATCH v4 3/3] tests/qtest: Add test for Aspeed HACE accumulative mode

2022-03-31 Thread Steven Lee
/sha256sum utilities without padding, i.e. only "abc" ascii text. Signed-off-by: Troy Lee Signed-off-by: Steven Lee --- tests/qtest/aspeed_hace-test.c | 145 + 1 file changed, 145 insertions(+) diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspe

[PATCH v4 0/3] aspeed/hace: Support AST2600 HACE

2022-03-31 Thread Steven Lee
login. - AST1030 with ASPEED zephyr SDK v1.04 - run `hash sha256` command in zephyr shell to verify aspeed hace. Please help to review. Thanks, Steven Changes in v4: - Separate HACE28 support to another patch. - Refactor acc_mode message handling flow. Steven Lee (3): aspeed/hace: Support HMAC

[PATCH v4 2/3] aspeed/hace: Support AST2600 HACE

2022-03-31 Thread Steven Lee
-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 140 -- 1 file changed, 136 insertions(+), 4 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 59fe5bfca2..5a7a144602 100644 --- a/hw/misc/aspeed_hace.c +++ b/hw

[PATCH v4 1/3] aspeed/hace: Support HMAC Key Buffer register.

2022-03-31 Thread Steven Lee
Support HACE28: Hash HMAC Key Buffer Base Address Register. Signed-off-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 7 +++ include/hw/misc/aspeed_hace.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index

Re: [PATCH v3 1/2] aspeed/hace: Support AST2600 HACE

2022-03-29 Thread Steven Lee
> Hi Joel, Thanks for the review and sorry for late reply, I was taking Monday off. I added some examples to describe the driver behavior below, hope it helps. > On Fri, 25 Mar 2022 at 03:58, Steven Lee wrote: > > > > The aspeed ast2600 acculumative mode is described in d

[PATCH v3 1/2] aspeed/hace: Support AST2600 HACE

2022-03-24 Thread Steven Lee
-by: Troy Lee Signed-off-by: Steven Lee --- hw/misc/aspeed_hace.c | 113 +++--- include/hw/misc/aspeed_hace.h | 1 + 2 files changed, 105 insertions(+), 9 deletions(-) diff --git a/hw/misc/aspeed_hace.c b/hw/misc/aspeed_hace.c index 10f00e65f4..a883625e92 100644

[PATCH v3 0/2] Supporting AST2600 HACE engine accumulative mode

2022-03-24 Thread Steven Lee
login. - AST1030 with ASPEED zephyr SDK v1.04 - run `hash sha256` command in zephyr shell to verify aspeed hace. Please help to review Thanks, Steven Changes in v3: - Refactor acc_mode message handling flow. Steven Lee (2): aspeed/hace: Support AST2600 HACE tests/qtest: Add test for Aspeed HACE

[PATCH v3 2/2] tests/qtest: Add test for Aspeed HACE accumulative mode

2022-03-24 Thread Steven Lee
/sha256sum utilities without padding, i.e. only "abc" ascii text. Signed-off-by: Troy Lee Signed-off-by: Steven Lee --- tests/qtest/aspeed_hace-test.c | 145 + 1 file changed, 145 insertions(+) diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspe

[PATCH v2 0/2] hw: aspeed_scu: Add AST2600 hpll calculation function

2022-03-15 Thread Steven Lee
and ast2600 get_apb_freq class handlers. - introduce clkin_25Mhz attribute. Please help to review. Thanks, Steven Steven Lee (2): hw: aspeed_scu: Add AST2600 apb_freq and hpll calculation function hw: aspeed_scu: Introduce clkin_25Mhz attribute hw/misc/aspeed_scu.c | 45

[PATCH v2 2/2] hw: aspeed_scu: Introduce clkin_25Mhz attribute

2022-03-15 Thread Steven Lee
AST2600 clkin is always 25MHz, introduce clkin_25Mhz attribute for aspeed_scu_get_clkin() to return the correct clkin for ast2600. Signed-off-by: Steven Lee --- hw/misc/aspeed_scu.c | 6 +- include/hw/misc/aspeed_scu.h | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff

[PATCH v2 1/2] hw: aspeed_scu: Add AST2600 apb_freq and hpll calculation function

2022-03-15 Thread Steven Lee
AST2600's HPLL register offset and bit definition are different from AST2500. Add a hpll calculation function and an apb frequency calculation function based on SCU200 register description in ast2600v11.pdf. Signed-off-by: Steven Lee --- hw/misc/aspeed_scu.c | 39

Re: [PATCH v1 1/1] hw: aspeed_scu: Add AST2600 hpll calculation function

2022-03-14 Thread Steven Lee
The 03/14/2022 20:21, Cédric Le Goater wrote: > Hello Steven, > > On 3/14/22 10:54, Steven Lee wrote: > > AST2600's HPLL register offset and bit definition are different from > > AST2500. Add a hpll calculation function for ast2600 and modify apb > > frequency >

[PATCH v1 0/1] hw: aspeed_scu: Add AST2600 hpll calculation function

2022-03-14 Thread Steven Lee
Steven Lee (1): hw: aspeed_scu: Add AST2600 hpll calculation function hw/misc/aspeed_scu.c | 43 include/hw/misc/aspeed_scu.h | 17 ++ 2 files changed, 56 insertions(+), 4 deletions(-) -- 2.17.1

[PATCH v1 1/1] hw: aspeed_scu: Add AST2600 hpll calculation function

2022-03-14 Thread Steven Lee
AST2600's HPLL register offset and bit definition are different from AST2500. Add a hpll calculation function for ast2600 and modify apb frequency calculation function based on SCU200 register description in ast2600v11.pdf. Signed-off-by: Steven Lee --- hw/misc/aspeed_scu.c | 43