Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Yuri Benditovich
On Sun, Mar 8, 2020 at 2:17 PM Michael S. Tsirkin wrote: > > On Sun, Mar 08, 2020 at 11:56:38AM +0200, Yuri Benditovich wrote: > > On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin wrote: > > > > > > On Fri, Mar 06, 2020 at 11:50:30AM

Re: [PATCH 0/3] reference implementation of RSS

2020-03-08 Thread Yuri Benditovich
On Sun, Mar 8, 2020 at 10:06 AM Michael S. Tsirkin wrote: > > On Fri, Mar 06, 2020 at 11:50:30AM +0200, Yuri Benditovich wrote: > > > > > > On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > > > > > On 2020/2/27 上午1:48, Yuri Benditovich wro

Re: [PATCH 0/3] reference implementation of RSS

2020-03-06 Thread Yuri Benditovich
On Fri, Mar 6, 2020 at 11:27 AM Jason Wang wrote: > > On 2020/2/27 上午1:48, Yuri Benditovich wrote: > > Support for VIRTIO_NET_F_RSS feature in QEMU for reference > > purpose. Implements Toeplitz hash calculation for incoming > > packets according to configur

Re: [PATCH 1/3] virtio-net: introduce RSS RX steering feature

2020-03-06 Thread Yuri Benditovich
On Thu, Mar 5, 2020 at 3:21 PM Michael S. Tsirkin wrote: > On Wed, Feb 26, 2020 at 07:48:07PM +0200, Yuri Benditovich wrote: > > Signed-off-by: Yuri Benditovich > > --- > > include/standard-headers/linux/virtio_net.h | 37 +++-- > > 1 file changed, 35

Re: [PATCH 3/3] virtio-net: implement RX RSS processing

2020-03-05 Thread Yuri Benditovich
On Thu, Mar 5, 2020 at 10:02 PM Michael S. Tsirkin wrote: > On Thu, Mar 05, 2020 at 09:54:31PM +0200, Yuri Benditovich wrote: > > On Thu, Mar 5, 2020 at 3:20 PM Michael S. Tsirkin > wrote: > > > > > > On Wed, Feb 26, 2020 at 07:48:09PM +0200, Yuri Benditovich wrot

Re: [PATCH 3/3] virtio-net: implement RX RSS processing

2020-03-05 Thread Yuri Benditovich
On Thu, Mar 5, 2020 at 3:20 PM Michael S. Tsirkin wrote: > > On Wed, Feb 26, 2020 at 07:48:09PM +0200, Yuri Benditovich wrote: > > If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process > > incoming packets, calculate packet's hash and place the > > packet into

Re: [PULL 1/1] qxl: introduce hardware revision 5

2020-03-05 Thread Yuri Benditovich
- Original Message - > From: "Laszlo Ersek" > To: "Yuri Benditovich" > Cc: "Gerd Hoffmann" , qemu-devel@nongnu.org, "Eduardo > Habkost" , "Yan Vugenfirer" > Sent: Thursday, March 5, 2020 5:01:24 PM > Subject: Re: [PUL

Re: [PULL 1/1] qxl: introduce hardware revision 5

2020-03-05 Thread Yuri Benditovich
- Original Message - > From: "Gerd Hoffmann" > To: "Laszlo Ersek" > Cc: qemu-devel@nongnu.org, "Eduardo Habkost" , "Yuri > Benditovich" , "Yan Vugenfirer" > Sent: Thursday, March 5, 2020 10:08:36 AM > Subject: Re:

Re: [PULL 1/1] qxl: introduce hardware revision 5

2020-03-05 Thread Yuri Benditovich
- Original Message - > From: "Laszlo Ersek" > To: "Gerd Hoffmann" > Cc: qemu-devel@nongnu.org, "Eduardo Habkost" , "Yuri > Benditovich" , "Yan Vugenfirer" > Sent: Thursday, March 5, 2020 1:28:23 AM > Subject: Re: [PUL

Re: [PATCH 0/3] reference implementation of RSS

2020-03-05 Thread Yuri Benditovich
ping On Wed, Feb 26, 2020 at 7:48 PM Yuri Benditovich wrote: > > Support for VIRTIO_NET_F_RSS feature in QEMU for reference > purpose. Implements Toeplitz hash calculation for incoming > packets according to configuration provided by driver. > > This series requires pr

[PATCH 2/3] virtio-net: implement RSS configuration command

2020-02-26 Thread Yuri Benditovich
Optionally report RSS feature. Handle RSS configuration command and keep RSS parameters in virtio-net device context. Signed-off-by: Yuri Benditovich --- hw/net/trace-events| 3 + hw/net/virtio-net.c| 148 +++-- include/hw/virtio/virtio

[PATCH 3/3] virtio-net: implement RX RSS processing

2020-02-26 Thread Yuri Benditovich
If VIRTIO_NET_F_RSS negotiated and RSS is enabled, process incoming packets, calculate packet's hash and place the packet into respective RX virtqueue. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 86 +- include/hw/virtio/virtio-net.h | 1

[PATCH 0/3] reference implementation of RSS

2020-02-26 Thread Yuri Benditovich
/2020-01/msg06448.html Yuri Benditovich (3): virtio-net: introduce RSS RX steering feature virtio-net: implement RSS configuration command virtio-net: implement RX RSS processing hw/net/trace-events | 3 + hw/net/virtio-net.c | 234

[PATCH 1/3] virtio-net: introduce RSS RX steering feature

2020-02-26 Thread Yuri Benditovich
Signed-off-by: Yuri Benditovich --- include/standard-headers/linux/virtio_net.h | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/include/standard-headers/linux/virtio_net.h b/include/standard-headers/linux/virtio_net.h index 260c3681d7..3bc100afe3

Re: [PATCH 1/2] NetRxPkt: Introduce support for additional hash types

2020-02-12 Thread Yuri Benditovich
Hi Jason, Can you please review these 2 patches and apply if there are no objections. Thanks, Yuri Benditovich On Wed, Jan 29, 2020 at 6:09 PM Dmitry Fleytman wrote: > > > > > On 27 Jan 2020, at 13:54, Yuri Benditovich > > wrote: > > > > Add support for f

[PATCH] e1000e: Avoid hw_error if legacy mode used

2020-01-27 Thread Yuri Benditovich
for BSIZE0 and BSIZE1 when legacy mode used. Signed-off-by: Yuri Benditovich --- hw/net/e1000e_core.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 5b05c8ea8a..94ea34dca5 100644 --- a/hw/net/e1000e_core.c +++ b

[PATCH 2/2] NetRxPkt: fix hash calculation of IPV6 TCP

2020-01-27 Thread Yuri Benditovich
of the addresses. Signed-off-by: Yuri Benditovich --- hw/net/e1000e_core.c | 2 +- hw/net/net_rx_pkt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index 9b76f82db5..5b05c8ea8a 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net

[PATCH 1/2] NetRxPkt: Introduce support for additional hash types

2020-01-27 Thread Yuri Benditovich
Add support for following hash types: IPV6 TCP with extension headers IPV4 UDP IPV6 UDP IPV6 UDP with extension headers Signed-off-by: Yuri Benditovich --- hw/net/net_rx_pkt.c | 42 ++ hw/net/net_rx_pkt.h | 6 +- hw/net/trace-events | 4 3

[PATCH v3 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2020-01-08 Thread Yuri Benditovich
removes this capability (starting from machine 5.0) Set 'usb-host.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.2 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c| 1 + hw/usb/host-libusb.c | 20

[PATCH v3 2/2] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2020-01-08 Thread Yuri Benditovich
removes this capability (starting from machine 5.0) Set 'usb-redir.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.2 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c | 1 + hw/usb/redirect.c | 20 2

[PATCH v3 0/2] Remove 'remote wakeup' flag from USB config descriptor

2020-01-08 Thread Yuri Benditovich
This series of patches addresses possible functional problem of USB devices with 'remote wakeup' capability, redirected to Windows VM (local redirection using libusb or spice redirection using usbredir). Yuri Benditovich (2): usb-host: remove 'remote wakeup' flag from configuration descriptor

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-07 Thread Yuri Benditovich
On Mon, Jan 6, 2020 at 12:37 PM Yuri Benditovich < yuri.benditov...@daynix.com> wrote: > > On Mon, Jan 6, 2020 at 11:58 AM Michael S. Tsirkin wrote: > >> I guess it somehow has to do with the following: >> >> if (proxy->disable_legacy == ON_OFF_AUTO_AUTO

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-06 Thread Yuri Benditovich
rface on modern device even if it has one. > > On Mon, Jan 06, 2020 at 11:10:18AM +0200, Yuri Benditovich wrote: > > Michael, > > Can you please comment on Jason's question: why we have a problem only > with q35 > > and not with legacy pc? > > If you have a si

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-06 Thread Yuri Benditovich
Michael, Can you please comment on Jason's question: why we have a problem only with q35 and not with legacy pc? If you have a simple answer, it will help us in further work with other hot plug/unplug problems. Thanks, Yuri Benditovich On Sun, Jan 5, 2020 at 6:21 PM Yuri Benditovich wrote

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 1:39 PM Michael S. Tsirkin wrote: > On Thu, Jan 02, 2020 at 09:09:04AM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin > wrote: > > > > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Bend

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-05 Thread Yuri Benditovich
On Sun, Jan 5, 2020 at 2:22 PM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 06:36:48AM +0200, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplu

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2020-01-01 Thread Yuri Benditovich
On Thu, Jan 2, 2020 at 1:50 AM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 11:29:50AM +0200, Yuri Benditovich wrote: > > On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > > > > > > > On 2019/12/26 下午12:36, Yuri Benditovich wrote: > > &g

Re: [PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted

2020-01-01 Thread Yuri Benditovich
On Thu, Jan 2, 2020 at 1:43 AM Michael S. Tsirkin wrote: > On Thu, Dec 26, 2019 at 06:36:49AM +0200, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > If the control queue is not deleted together with TX/RX, it > > later will be ign

Re: [PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-26 Thread Yuri Benditovich
On Thu, Dec 26, 2019 at 10:58 AM Jason Wang wrote: > > > On 2019/12/26 下午12:36, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1708480 > > Fix leak of region reference that prevents complete > > device deletion on hot unplug. > > > More

[PATCH 2/2] virtio-net: delete also control queue when TX/RX deleted

2019-12-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1708480 If the control queue is not deleted together with TX/RX, it later will be ignored in freeing cache resources and hot unplug will not be completed. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 3 ++- 1 file changed, 2 insertions

[PATCH 1/2] virtio: reset region cache when on queue deletion

2019-12-25 Thread Yuri Benditovich
https://bugzilla.redhat.com/show_bug.cgi?id=1708480 Fix leak of region reference that prevents complete device deletion on hot unplug. Signed-off-by: Yuri Benditovich --- hw/virtio/virtio.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

[PATCH 0/2] Solve problem of hot removal of virtio-net-pci

2019-12-25 Thread Yuri Benditovich
with the same name can not be added. These 2 patches solve the problem. Yuri Benditovich (2): virtio: reset region cache when on queue deletion virtio-net: delete also control queue when TX/RX deleted hw/net/virtio-net.c | 3 ++- hw/virtio/virtio.c | 5 + 2 files changed, 7 insertions

Re: [PATCH v2 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2019-12-09 Thread Yuri Benditovich
On Tue, Dec 10, 2019 at 12:32 AM Eduardo Habkost wrote: > > On Tue, Dec 03, 2019 at 09:07:15PM +0200, Yuri Benditovich wrote: > > If the redirected device has this capability, Windows guest may > > place the device into D2 and expect it to wake when the device

[PATCH v2 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2019-12-03 Thread Yuri Benditovich
removes this capability (starting from machine 4.2) Set 'usb-host.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.1 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c| 1 + hw/usb/host-libusb.c | 20

[PATCH v2 0/2] Remove 'remote wakeup' flag from USB config descriptor

2019-12-03 Thread Yuri Benditovich
This series of patches addresses possible functional problem of USB devices with 'remote wakeup' capability, redirected to Windows VM (local redirection using libusb or spice redirection using usbredir). Changes from v1: minor fixes per v1 review and checkpatch Yuri Benditovich (2): usb-host

[PATCH v2 2/2] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2019-12-03 Thread Yuri Benditovich
removes this capability (starting from machine 4.2) Set 'usb-redir.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.1 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c | 1 + hw/usb/redirect.c | 20 2

[PATCH 1/2] usb-host: remove 'remote wakeup' flag from configuration descriptor

2019-12-02 Thread Yuri Benditovich
removes this capability (starting from machine 4.2) Set 'usb-host.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.1 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c| 1 + hw/usb/host-libusb.c | 18 ++ hw

[PATCH 2/2] usb-redir: remove 'remote wakeup' flag from configuration descriptor

2019-12-02 Thread Yuri Benditovich
removes this capability (starting from machine 4.2) Set 'usb-redir.suppress-remote-wake' property to 'off' to keep 'remote wake' as is or to 'on' to remove 'remote wake' on 4.1 or earlier. Signed-off-by: Yuri Benditovich --- hw/core/machine.c | 1 + hw/usb/redirect.c | 19 +++ 2

[PATCH 0/2] Remove 'remote wakeup' flag from USB config descriptor

2019-12-02 Thread Yuri Benditovich
This series of patches addresses possible functional problem of USB devices with 'remote wakeup' capability, redirected to Windows VM (local redirection using libusb or spice redirection using usbredir). Yuri Benditovich (2): usb-host: remove 'remote wakeup' flag from configuration descriptor

Re: [PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-27 Thread Yuri Benditovich
On Wed, Nov 27, 2019 at 11:40 AM Gerd Hoffmann wrote: > > On Wed, Nov 27, 2019 at 09:36:21AM +0200, Yuri Benditovich wrote: > > On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote: > > > > > > Yuri Benditovich writes: > > > > > > > If the r

Re: [PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-26 Thread Yuri Benditovich
On Wed, Nov 27, 2019 at 8:36 AM Markus Armbruster wrote: > > Yuri Benditovich writes: > > > If the redirected device has this capability, Windows guest may > > place the device into D2 and expect it to wake when the device > > becomes active, but this will neve

[PATCH] usbredir: remove 'remote wake' capability from configuration descriptor

2019-11-26 Thread Yuri Benditovich
property 'usb-redir.nowake=off' keeps 'remote wake' as is. Signed-off-by: Yuri Benditovich --- hw/usb/redirect.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index e0f5ca6f81..e95898fe80 100644 --- a/hw/usb/redirect.c +++ b/hw/usb

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-25 Thread Yuri Benditovich
You're right, with just one latest patch things work. On Mon, Mar 25, 2019 at 11:59 AM Jason Wang wrote: > > > On 2019/3/25 下午5:56, Yuri Benditovich wrote: > > Hi Jason, > > > > This seems ok now (4 previous patches + this one) > > > Thanks for the testing.

Re: [Qemu-devel] [PATCH V2 RFT] vhost_net: don't set backend for the uninitialized virtqueue

2019-03-25 Thread Yuri Benditovich
Hi Jason, This seems ok now (4 previous patches + this one) On Mon, Mar 25, 2019 at 5:56 AM Jason Wang wrote: > > We used to set backend unconditionally, this won't work for some > guests (e.g windows driver) who may not initialize all virtqueues. For > kernel backend, this will fail since it

Re: [Qemu-devel] [RFT 0/4] Don't start virtqueues that are not enabled for vhost

2019-03-24 Thread Yuri Benditovich
Hi Jason, This series does not do the job. Test case: tap, 4 queues, 2 CPU (so only 2 queues are enabled) For Q0 and Q1 vhost_net_start_one succeeds, For Q2: vhost_net_start_one calls vhost_dev_start (the call succeeds, does not start queue that is not enabled), then vhost_net_start_one calls

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-21 Thread Yuri Benditovich
On Thu, Feb 21, 2019 at 8:49 AM Jason Wang wrote: > > > On 2019/2/21 下午2:00, Yuri Benditovich wrote: > > On Tue, Feb 19, 2019 at 8:27 AM Jason Wang wrote: > >> > >> On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: > >>> On Mon, Feb 18, 201

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-20 Thread Yuri Benditovich
On Tue, Feb 19, 2019 at 8:27 AM Jason Wang wrote: > > > On 2019/2/19 上午7:34, Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 10:49:08PM +0200, Yuri Benditovich wrote: > >> On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: > >>> On Mon, Fe

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-18 Thread Yuri Benditovich
On Mon, Feb 18, 2019 at 6:39 PM Michael S. Tsirkin wrote: > > On Mon, Feb 18, 2019 at 11:58:51AM +0200, Yuri Benditovich wrote: > > On Mon, Feb 18, 2019 at 5:49 AM Jason Wang wrote: > > > > > > > > > On 2019/2/13 下午10:51, Yuri Benditovich wrote: > >

Re: [Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-18 Thread Yuri Benditovich
On Mon, Feb 18, 2019 at 5:49 AM Jason Wang wrote: > > > On 2019/2/13 下午10:51, Yuri Benditovich wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1608226 > > On startup/link-up in multiqueue configuration the virtio-net > > tries to starts all the queues, inc

[Qemu-devel] [PATCH] virtio-net: do not start queues that are not enabled by the guest

2019-02-13 Thread Yuri Benditovich
, upon VIRTIO_NET_CTRL_MQ_VQ_PAIRS_SET started all the queues requested by the guest. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 3f319ef723..d3b1ac6d3a 100644

[Qemu-devel] [PATCH 1/2] usb: XHCI shall not halt isochronous endpoints

2019-01-28 Thread Yuri Benditovich
According to the XHCI spec (4.10.2) the controller never halts isochronous endpoints. This commit prevent stop of isochronous streaming when sporadic errors status received from backends. Signed-off-by: Yuri Benditovich --- hw/usb/hcd-xhci.c | 5 + 1 file changed, 5 insertions(+) diff

[Qemu-devel] [PATCH 0/2] Fix XHCI errors with isochronous transfer

2019-01-28 Thread Yuri Benditovich
as this construction is used in this file everywhere. Yuri Benditovich (2): usb: XHCI shall not halt isochronous endpoints usb: implement XHCI underrun/overrun events hw/usb/hcd-xhci.c | 22 -- hw/usb/hcd-xhci.h | 1 + 2 files changed, 21 insertions(+), 2 deletions(-) -- 2.9.5

[Qemu-devel] [PATCH 2/2] usb: implement XHCI underrun/overrun events

2019-01-28 Thread Yuri Benditovich
of assigned interrupter to the XHCISlot structure. Guest software assigns interrupter to the slot on 'Address Device' and 'Evaluate Context' commands. Signed-off-by: Yuri Benditovich --- hw/usb/hcd-xhci.c | 17 +++-- hw/usb/hcd-xhci.h | 1 + 2 files changed, 16 insertions(+), 2

[Qemu-devel] [PATCH v4 0/2] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2019-01-03 Thread Yuri Benditovich
migration * Mail address in signature * Style fixes Changes in v3: * added comment regarding chain loss on migration Changes in v4: * added patch changing feature bit from 38 to 61 Yuri Benditovich (2): virtio-net: support RSC v4/v6 tcp traffic for Windows HCK virtio-net: changed

[Qemu-devel] [PATCH v4 2/2] virtio-net: changed VIRTIO_NET_F_RSC_EXT to be 61

2019-01-03 Thread Yuri Benditovich
Allocated feature bit changed in spec draft per TC request. Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 5a3952f84b..2db80e1f71 100644 --- a/hw/net/virtio-net.c +++ b

[Qemu-devel] [PATCH v4 1/2] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2019-01-03 Thread Yuri Benditovich
to the guest will be lost in case of migration. Signed-off-by: Wei Xu Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 667 - include/hw/virtio/virtio-net.h | 83 include/net/eth.h | 2 + 3 files changed, 751 insertions(+), 1 deletion

[Qemu-devel] [PATCH v3] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-14 Thread Yuri Benditovich
to the guest will be lost in case of migration. Signed-off-by: Wei Xu Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 667 - include/hw/virtio/virtio-net.h | 83 include/net/eth.h | 2 + 3 files changed, 751 insertions(+), 1 deletion

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-13 Thread Yuri Benditovich
On Mon, Nov 12, 2018 at 10:53 PM Michael S. Tsirkin wrote: > On Mon, Nov 12, 2018 at 01:31:36PM +0200, Yuri Benditovich wrote: > > > > > > On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > > > > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: &

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-12 Thread Yuri Benditovich
On Mon, Nov 12, 2018 at 11:26 AM Jason Wang wrote: > > On 2018/11/12 下午4:57, Yuri Benditovich wrote: > > > > On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin > <mailto:m...@redhat.com>> wrote: > > > > On Sun, Nov 11, 2018 a

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-12 Thread Yuri Benditovich
On Mon, Nov 12, 2018 at 4:54 AM Michael S. Tsirkin wrote: > On Sun, Nov 11, 2018 at 12:18:54PM +0200, Yuri Benditovich wrote: > > > @@ -66,12 +143,16 @@ typedef struct VirtIONet { > > > VirtIONetQueue *vqs; > > > VirtQueue *ctrl_vq

[Qemu-devel] [PATCH v2 1/1] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
to the guest will be lost in case of migration. Signed-off-by: Wei Xu Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c| 667 - include/hw/virtio/virtio-net.h | 81 include/net/eth.h | 2 + 3 files changed, 749 insertions(+), 1 deletion

[Qemu-devel] [PATCH v2 0/1] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
migration * Mail address in signature * Style fixes Yuri Benditovich (1): virtio-net: support RSC v4/v6 tcp traffic for Windows HCK hw/net/virtio-net.c| 667 - include/hw/virtio/virtio-net.h | 81 include/net/eth.h | 2 + 3 files

Re: [Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-11 Thread Yuri Benditovich
On Fri, Nov 9, 2018 at 8:11 PM Michael S. Tsirkin wrote: > Looks good to me. Some comments below > > On Fri, Nov 09, 2018 at 04:58:27PM +0200, Yuri Benditovich wrote: > > This commit adds implementation of RX packets > > coalescing, compatible with requirements of

[Qemu-devel] [PATCH] virtio-net: support RSC v4/v6 tcp traffic for Windows HCK

2018-11-09 Thread Yuri Benditovich
intuitively. Difference between ip v4 and v6 processing: Fragment length in ipv4 header includes itself, while it's not included for ipv6, thus means ipv6 can carry a real 65535 payload. Signed-off-by: Wei Xu Signed-off-by: Yuri Benditovich --- hw/net/virtio-net.c | 648

[Qemu-devel] [PATCH v3 2/4] net: vhost stop updates virtio queue state

2016-12-13 Thread Yuri Benditovich
Make virtio queue suitable for push operation from qemu after vhost was stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index f7f7023..d396b22 100644 --

[Qemu-devel] [PATCH v3 3/4] virtio: Introduce virtqueue_drop_all procedure

2016-12-13 Thread Yuri Benditovich
Add procedure for fast drop of queued packets, acting like pop and push without mapping the buffers into memory. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/virtio.c | 38 ++ include/hw/virtio/virtio.h | 1 + 2

[Qemu-devel] [PATCH v3 4/4] net: virtio-net discards TX data after link down

2016-12-13 Thread Yuri Benditovich
by the host, the Windows guest will never be able to finish disable/removal/shutdown. Now each packet sent by guest after NIC indicated link down will be completed immediately. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/net/virtio-net.c | 26 ++

[Qemu-devel] [PATCH v3 0/4] virtio-net discards TX data after link down

2016-12-13 Thread Yuri Benditovich
virtqueue_drop_all instead of pop/push Changes from v1: added drop for outstanding tx packets for tx=timer (mainly for case of vhost=off) fixed link down flow to drop outstanding packets and ensure tx queue notification enabled Yuri Benditovich (4): net: Add virtio queue interface

[Qemu-devel] [PATCH v3 1/4] net: Add virtio queue interface to update used index from vring state

2016-12-13 Thread Yuri Benditovich
Bring virtio queue to correct internal state for host-to-guest operations when vhost is temporary stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/virtio.c | 5 + include/hw/virtio/virtio.h | 1 + 2 files changed, 6 insertions(+) diff --gi

Re: [Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down

2016-11-23 Thread Yuri Benditovich
On Thu, Nov 10, 2016 at 3:54 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Nov 10, 2016 at 01:56:05AM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Nov 9, 2016 at 10:28 PM, Michael S. Tsirkin <m...@redhat.com> > wrote: > > > &

Re: [Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down

2016-11-10 Thread Yuri Benditovich
On Thu, Nov 10, 2016 at 3:54 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Thu, Nov 10, 2016 at 01:56:05AM +0200, Yuri Benditovich wrote: > > > > > > On Wed, Nov 9, 2016 at 10:28 PM, Michael S. Tsirkin <m...@redhat.com> > wrote: > > > &

Re: [Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down

2016-11-09 Thread Yuri Benditovich
On Wed, Nov 9, 2016 at 10:28 PM, Michael S. Tsirkin <m...@redhat.com> wrote: > On Wed, Nov 09, 2016 at 05:22:02PM +0200, yuri.benditov...@daynix.com > wrote: > > From: Yuri Benditovich <yuri.benditov...@daynix.com> > > > > https://bugzilla.redhat.com/show_

[Qemu-devel] [PATCH v2 1/3] net: Add virtio queue interface to update used index from vring state

2016-11-09 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> Bring virtio queue to correct internal state for host-to-guest operations when vhost is temporary stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/virtio.c | 5 + include/hw/virtio/

[Qemu-devel] [PATCH v2 2/3] net: vhost stop updates virtio queue state

2016-11-09 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> Make virtio queue suitable for push operation from qemu after vhost was stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/

[Qemu-devel] [PATCH v2 0/3] virtio-net discards TX data after link down

2016-11-09 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX

[Qemu-devel] [PATCH v2 3/3] net: virtio-net discards TX data after link down

2016-11-09 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX

Re: [Qemu-devel] [PATCH 3/3] net: virtio-net discards TX data after link down

2016-11-08 Thread Yuri Benditovich
On Tue, Nov 8, 2016 at 8:48 AM, Jason Wang <jasow...@redhat.com> wrote: > > > On 2016年11月07日 16:20, yuri.benditov...@daynix.com wrote: > >> From: Yuri Benditovich <yuri.benditov...@daynix.com> >> >> https://bugzilla.redhat.com/show_bug.cgi?id=129563

[Qemu-devel] [PATCH 3/3] net: virtio-net discards TX data after link down

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX

[Qemu-devel] [PATCH 2/3] net: vhost stop updates virtio queue state

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> Prepare virtio queue for push operation from qemu after vhost was stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.c

[Qemu-devel] [PATCH 0/3] virtio-net discards TX data after link down

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1295637 Upon set_link monitor command or upon netdev deletion virtio-net sends link down indication to the guest and stops vhost if one is used. Guest driver can still submit data for TX

[Qemu-devel] [PATCH 1/3] net: Add virtio queue interface to update used index from vring state

2016-11-07 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> Bring virtio queue to correct internal state for host-to-guest operations when vhost is temporary stopped. Signed-off-by: Yuri Benditovich <yuri.benditov...@daynix.com> --- hw/virtio/virtio.c | 5 + include/hw/virtio/

[Qemu-devel] [PATCH 1/1] net: skip virtio-net config of deleted nic's peers

2016-10-31 Thread yuri . benditovich
From: Yuri Benditovich <yuri.benditov...@daynix.com> https://bugzilla.redhat.com/show_bug.cgi?id=1373816 qemu core dump happens during repetitive unpug-plug with multiple queues and Windows RSS-capable guest. If back-end delete requested during virtio-net device initialization, driver sti

<    1   2   3