Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-02-22 Thread Hanna Reitz
On 21.02.22 20:45, Peter Maydell wrote: On Tue, 1 Feb 2022 at 11:25, Hanna Reitz wrote: On 28.01.22 17:55, Peter Maydell wrote: Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Fixes: Coverity CID

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-02-21 Thread Peter Maydell
On Tue, 1 Feb 2022 at 11:25, Hanna Reitz wrote: > > On 28.01.22 17:55, Peter Maydell wrote: > > Coverity points out that we aren't checking the return value > > from curl_easy_setopt() for any of the calls to it we make > > in block/curl.c. > > > > Fixes: Coverity CID 1459336, 1459482, 1460331 >

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-02-01 Thread Hanna Reitz
On 28.01.22 17:55, Peter Maydell wrote: Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Fixes: Coverity CID 1459336, 1459482, 1460331 Signed-off-by: Peter Maydell --- Big fat disclaimer: tested only with

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-01-28 Thread Peter Maydell
On Fri, 28 Jan 2022 at 17:50, Daniel P. Berrangé wrote: > > On Fri, Jan 28, 2022 at 04:55:35PM +, Peter Maydell wrote: > > Coverity points out that we aren't checking the return value > > from curl_easy_setopt() for any of the calls to it we make > > in block/curl.c. > > > > Fixes: Coverity

Re: [PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-01-28 Thread Daniel P . Berrangé
On Fri, Jan 28, 2022 at 04:55:35PM +, Peter Maydell wrote: > Coverity points out that we aren't checking the return value > from curl_easy_setopt() for any of the calls to it we make > in block/curl.c. > > Fixes: Coverity CID 1459336, 1459482, 1460331 > Signed-off-by: Peter Maydell > --- >

[PATCH] block/curl.c: Check error return from curl_easy_setopt()

2022-01-28 Thread Peter Maydell
Coverity points out that we aren't checking the return value from curl_easy_setopt() for any of the calls to it we make in block/curl.c. Fixes: Coverity CID 1459336, 1459482, 1460331 Signed-off-by: Peter Maydell --- Big fat disclaimer: tested only with 'make check', which I suspect may not be