On Tue, Mar 17, 2020 at 11:09:22AM +, Peter Maydell wrote:
> On Tue, 17 Mar 2020 at 11:01, Philippe Mathieu-Daudé
> wrote:
> >
> > ping
>
> Eduardo said he'd queued it -- I've been assuming he'll send
> a pullreq for it.
It will be on today's pull request, sorry for the delay.
--
Eduardo
On Tue, 17 Mar 2020 at 11:01, Philippe Mathieu-Daudé wrote:
>
> ping
Eduardo said he'd queued it -- I've been assuming he'll send
a pullreq for it.
(The followup work I was planning to base on this turned out
to have complications I hadn't expected, so I've put it on
the shelf for the moment.
ping?
On 3/3/20 11:05 AM, Peter Maydell wrote:
The CPUClass has a 'reset' method. This is a legacy from when
TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
function is kept as the API which most places
On 03.03.20 11:05, Peter Maydell wrote:
> The CPUClass has a 'reset' method. This is a legacy from when
> TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
> more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
> function is kept as the API which most places
On 3/3/20 7:36 PM, Peter Maydell wrote:
On Tue, 3 Mar 2020 at 18:33, Philippe Mathieu-Daudé wrote:
Nitpick: you don't need to include the bracket symbol in the diff:
@@
-resetfn(CPUState *cpu)
+resetfn(DeviceState *dev)
{
(simply indent it with a space).
I think this was
On Tue, Mar 03, 2020 at 10:05:11AM +, Peter Maydell wrote:
> The CPUClass has a 'reset' method. This is a legacy from when
> TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
> more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
> function is kept as the
On Tue, Mar 03, 2020 at 10:05:11AM +, Peter Maydell wrote:
> The CPUClass has a 'reset' method. This is a legacy from when
> TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
> more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
> function is kept as the
On 3/3/20 2:05 AM, Peter Maydell wrote:
> The CPUClass has a 'reset' method. This is a legacy from when
> TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
> more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
> function is kept as the API which most places use
On Tue, 3 Mar 2020 at 18:33, Philippe Mathieu-Daudé wrote:
> Nitpick: you don't need to include the bracket symbol in the diff:
>
>@@
>-resetfn(CPUState *cpu)
>+resetfn(DeviceState *dev)
> {
>
> (simply indent it with a space).
I think this was probably leftover from trying to
On 3/3/20 3:19 PM, Philippe Mathieu-Daudé wrote:
On 3/3/20 11:05 AM, Peter Maydell wrote:
The CPUClass has a 'reset' method. This is a legacy from when
TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
On 3/3/20 11:05 AM, Peter Maydell wrote:
The CPUClass has a 'reset' method. This is a legacy from when
TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
function is kept as the API which most places use to
Patchew URL:
https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/
Hi,
This series failed build test on FreeBSD host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a
Patchew URL:
https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
Patchew URL:
https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] cpu: Use DeviceClass reset instead of a special CPUClass reset
Message-id
Patchew URL:
https://patchew.org/QEMU/20200303100511.5498-1-peter.mayd...@linaro.org/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT
The CPUClass has a 'reset' method. This is a legacy from when
TYPE_CPU used not to inherit from TYPE_DEVICE. We don't need it any
more, as we can simply use the TYPE_DEVICE reset. The 'cpu_reset()'
function is kept as the API which most places use to reset a CPU; it
is now a wrapper which calls
16 matches
Mail list logo
