Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-07 Thread Gerd Hoffmann
> > QEMU_EFI reports the below error: > > ProcessCmdAddPointer: invalid pointer value in "etc/acpi/tables" > > OnRootBridgesConnected: InstallAcpiTables: Protocol Error > > > > Debugging shows that on first reboot(after hot-adding NVDIMM), > > Qemu updates the etc/table-loader len, > > > >

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-09-07 Thread Igor Mammedov
On Thu, 25 Aug 2022 17:18:42 +0100 Shameer Kolothum wrote: > Hi > > On arm/virt platform, Chen Xiang reported a Guest crash while > attempting the below steps, > > 1. Launch the Guest with nvdimm=on > 2. Hot-add a NVDIMM dev > 3. Reboot > 4. Guest boots fine. > 5. Reboot again. > 6. Guest boot

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-30 Thread Christian A. Ehrhardt
o: 'Laszlo Ersek' ; qemu-devel@nongnu.org; > > qemu-...@nongnu.org > > Cc: imamm...@redhat.com; peter.mayd...@linaro.org; Linuxarm > > ; chenxiang (M) ; Ard > > Biesheuvel (kernel.org address) ; Gerd Hoffmann > > > > Subject: RE: [PATCH] fw_c

RE: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-30 Thread Shameerali Kolothum Thodi via
address) ; Gerd Hoffmann > > Subject: RE: [PATCH] fw_cfg: Don't set callback_opaque NULL in > fw_cfg_modify_bytes_read() > > > > > -Original Message- > > From: Laszlo Ersek [mailto:ler...@redhat.com] > > Sent: 26 August 2022 13:07 > >

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-26 Thread Laszlo Ersek
+Ard +Gerd, one pointer at the bottom On 08/26/22 13:59, Laszlo Ersek wrote: > On 08/25/22 18:18, Shameer Kolothum wrote: >> Hi >> >> On arm/virt platform, Chen Xiang reported a Guest crash while >> attempting the below steps, >> >> 1. Launch the Guest with nvdimm=on >> 2. Hot-add a NVDIMM dev >>

RE: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-26 Thread Shameerali Kolothum Thodi via
; Biesheuvel (kernel.org address) ; Gerd Hoffmann > > Subject: Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in > fw_cfg_modify_bytes_read() > > +Ard +Gerd, one pointer at the bottom > > On 08/26/22 13:59, Laszlo Ersek wrote: > > On 08/25/22 18:18, Shameer Kolothum

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-26 Thread Laszlo Ersek
On 08/25/22 18:18, Shameer Kolothum wrote: > Hi > > On arm/virt platform, Chen Xiang reported a Guest crash while > attempting the below steps, > > 1. Launch the Guest with nvdimm=on > 2. Hot-add a NVDIMM dev > 3. Reboot > 4. Guest boots fine. > 5. Reboot again. > 6. Guest boot fails. > >

[PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

2022-08-25 Thread Shameer Kolothum via
Hi On arm/virt platform, Chen Xiang reported a Guest crash while attempting the below steps, 1. Launch the Guest with nvdimm=on 2. Hot-add a NVDIMM dev 3. Reboot 4. Guest boots fine. 5. Reboot again. 6. Guest boot fails. QEMU_EFI reports the below error: ProcessCmdAddPointer: invalid pointer