Re: [PATCH] migration: Unify and trace vmstate field_exists() checks

2023-10-04 Thread Juan Quintela
Peter Xu wrote: > For both save/load we actually share the logic on deciding whether a field > should exist. Merge the checks into a helper and use it for both save and > load. When doing so, add documentations and reformat the code to make it > much easier to read. > > The real benefit here

Re: [PATCH] migration: Unify and trace vmstate field_exists() checks

2023-10-03 Thread Peter Xu
On Thu, Sep 07, 2023 at 08:55:52AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > For both save/load we actually share the logic on deciding whether a field > > should exist. Merge the checks into a helper and use it for both save and > > load. When doing so, add documentations and

Re: [PATCH] migration: Unify and trace vmstate field_exists() checks

2023-09-07 Thread Fabiano Rosas
Peter Xu writes: > For both save/load we actually share the logic on deciding whether a field > should exist. Merge the checks into a helper and use it for both save and > load. When doing so, add documentations and reformat the code to make it > much easier to read. > > The real benefit here

[PATCH] migration: Unify and trace vmstate field_exists() checks

2023-09-06 Thread Peter Xu
For both save/load we actually share the logic on deciding whether a field should exist. Merge the checks into a helper and use it for both save and load. When doing so, add documentations and reformat the code to make it much easier to read. The real benefit here (besides code cleanups) is we