Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-05 Thread Richard W.M. Jones
On Thu, Feb 04, 2021 at 02:44:03PM -0600, Eric Blake wrote: > On 2/4/21 2:09 PM, Peter Lieven wrote: > > Am 02.02.21 um 16:51 schrieb Eric Blake: > >> On 1/28/21 8:07 AM, Peter Lieven wrote: > >>> Signed-off-by: Peter Lieven > >> Your commit message says 'what', but not 'why'. Generally, the

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-05 Thread Max Reitz
On 05.02.21 10:16, Max Reitz wrote: On 05.02.21 09:47, Peter Lieven wrote: Am 05.02.21 um 09:18 schrieb Max Reitz: On 04.02.21 21:09, Peter Lieven wrote: Am 02.02.21 um 16:51 schrieb Eric Blake: On 1/28/21 8:07 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven Your commit message says

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-05 Thread Max Reitz
On 05.02.21 09:47, Peter Lieven wrote: Am 05.02.21 um 09:18 schrieb Max Reitz: On 04.02.21 21:09, Peter Lieven wrote: Am 02.02.21 um 16:51 schrieb Eric Blake: On 1/28/21 8:07 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven Your commit message says 'what', but not 'why'.  Generally, the

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-05 Thread Peter Lieven
Am 05.02.21 um 09:18 schrieb Max Reitz: > On 04.02.21 21:09, Peter Lieven wrote: >> Am 02.02.21 um 16:51 schrieb Eric Blake: >>> On 1/28/21 8:07 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven >>> Your commit message says 'what', but not 'why'.  Generally, the one-line >>> 'what' works

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-05 Thread Max Reitz
On 04.02.21 21:09, Peter Lieven wrote: Am 02.02.21 um 16:51 schrieb Eric Blake: On 1/28/21 8:07 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven Your commit message says 'what', but not 'why'. Generally, the one-line 'what' works well as the subject line, but you want the commit body to

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-04 Thread Eric Blake
On 2/4/21 2:09 PM, Peter Lieven wrote: > Am 02.02.21 um 16:51 schrieb Eric Blake: >> On 1/28/21 8:07 AM, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >> Your commit message says 'what', but not 'why'. Generally, the one-line >> 'what' works well as the subject line, but you want the

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-04 Thread Peter Lieven
Am 02.02.21 um 16:51 schrieb Eric Blake: > On 1/28/21 8:07 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven > Your commit message says 'what', but not 'why'. Generally, the one-line > 'what' works well as the subject line, but you want the commit body to > give an argument why your patch

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-02 Thread Eric Blake
On 1/28/21 8:07 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven Your commit message says 'what', but not 'why'. Generally, the one-line 'what' works well as the subject line, but you want the commit body to give an argument why your patch should be applied, rather than blank. Here's the

Re: [PATCH] qemu-img: add seek and -n option to dd command

2021-02-02 Thread David Edmondson
On Thursday, 2021-01-28 at 15:07:04 +01, Peter Lieven wrote: > Signed-off-by: Peter Lieven > > diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst > index b615aa8419..7d4564c2b8 100644 > --- a/docs/tools/qemu-img.rst > +++ b/docs/tools/qemu-img.rst > @@ -209,6 +209,10 @@ Parameters to

[PATCH] qemu-img: add seek and -n option to dd command

2021-01-28 Thread Peter Lieven
Signed-off-by: Peter Lieven diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index b615aa8419..7d4564c2b8 100644 --- a/docs/tools/qemu-img.rst +++ b/docs/tools/qemu-img.rst @@ -209,6 +209,10 @@ Parameters to dd subcommand: .. program:: qemu-img-dd +.. option:: -n + + Skip the