Re: [PATCH 0/2] Enable -Wvla, forbidding use of variable length arrays

2024-01-31 Thread Peter Maydell
On Wed, 31 Jan 2024 at 14:56, Thomas Huth wrote: > There's still a vla left in the ppc kvm code: > > https://gitlab.com/thuth/qemu/-/jobs/6063230079#L2005 > > ../target/ppc/kvm.c: In function ‘kvmppc_save_htab’: > ../target/ppc/kvm.c:2691:5: error: ISO C90 forbids variable length array > ‘buf’

Re: [PATCH 0/2] Enable -Wvla, forbidding use of variable length arrays

2024-01-31 Thread Thomas Huth
On 25/01/2024 18.32, Peter Maydell wrote: For a while now I've had an on-and-off-again campaign to get rid of the handful of uses of C variable-length-array syntax in our codebase. The rationale for this is that if the array size can be controlled by the guest and we don't get the size limit

Re: [PATCH 0/2] Enable -Wvla, forbidding use of variable length arrays

2024-01-26 Thread Richard Henderson
On 1/26/24 03:32, Peter Maydell wrote: Peter Maydell (2): tests/qtest/xlnx-versal-trng-test.c: Drop use of variable length array meson: Enable -Wvla Reviewed-by: Richard Henderson r~

[PATCH 0/2] Enable -Wvla, forbidding use of variable length arrays

2024-01-25 Thread Peter Maydell
For a while now I've had an on-and-off-again campaign to get rid of the handful of uses of C variable-length-array syntax in our codebase. The rationale for this is that if the array size can be controlled by the guest and we don't get the size limit checking right, this is an easy to exploit