Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-31 Thread Alistair Francis
On Fri, Jan 26, 2024 at 4:04 AM Peter Maydell wrote: > > This commit was created with scripts/clean-includes: > ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] > > All .c should include qemu/osdep.h first. The script performs three > related cleanups: > > * Ensure .c files include

Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. *

Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:01PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:01 + > From: Peter Maydell > Subject: [PATCH 03/10] disas/riscv: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes:

Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-25 Thread Philippe Mathieu-Daudé
On 25/1/24 17:34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. *

[PATCH 03/10] disas/riscv: Clean up includes

2024-01-25 Thread Peter Maydell
This commit was created with scripts/clean-includes: ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c