Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes. All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Peter Maydell
On Fri, 26 Jan 2024 at 15:26, Zhao Liu wrote: > > On Thu, Jan 25, 2024 at 04:34:02PM +, Peter Maydell wrote: > > Date: Thu, 25 Jan 2024 16:34:02 + > > From: Peter Maydell > > Subject: [PATCH 04/10] aspeed: Clean up includes > > X-Mailer: git-send-em

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Zhao Liu
On Thu, Jan 25, 2024 at 04:34:02PM +, Peter Maydell wrote: > Date: Thu, 25 Jan 2024 16:34:02 + > From: Peter Maydell > Subject: [PATCH 04/10] aspeed: Clean up includes > X-Mailer: git-send-email 2.34.1 > > This commit was created with scripts/clean-includes. > &g

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-25 Thread Philippe Mathieu-Daudé
On 25/1/24 17:34, Peter Maydell wrote: This commit was created with scripts/clean-includes. All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes

[PATCH 04/10] aspeed: Clean up includes

2024-01-25 Thread Peter Maydell
This commit was created with scripts/clean-includes. All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such inclusions. * Likewise,