Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-24 Thread Mark Cave-Ayland
On 22/02/2022 15:03, Dr. David Alan Gilbert wrote: * Mark Cave-Ayland (mark.cave-ayl...@ilande.co.uk) wrote: On 21/02/2022 17:11, Daniel P. Berrangé wrote: On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-22 Thread Dr. David Alan Gilbert
* Mark Cave-Ayland (mark.cave-ayl...@ilande.co.uk) wrote: > On 21/02/2022 17:11, Daniel P. Berrangé wrote: > > > On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: > > > On 08/02/2022 13:10, Daniel P. Berrangé wrote: > > > > > > > On Tue, Feb 08, 2022 at 01:06:59PM +, Mark

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Mark Cave-Ayland
On 21/02/2022 17:11, Daniel P. Berrangé wrote: On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Mark Cave-Ayland
On 21/02/2022 12:20, Philippe Mathieu-Daudé wrote: +Thomas On 20/2/22 18:18, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Daniel P . Berrangé
On Sun, Feb 20, 2022 at 05:18:33PM +, Mark Cave-Ayland wrote: > On 08/02/2022 13:10, Daniel P. Berrangé wrote: > > > On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: > > > On 08/02/2022 12:49, Daniel P. Berrangé wrote: > > > > > > > > I was under the impression that

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-21 Thread Philippe Mathieu-Daudé
+Thomas On 20/2/22 18:18, Mark Cave-Ayland wrote: On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression that monitor_register_hmp_info_hrt() does all the

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-20 Thread Mark Cave-Ayland
On 08/02/2022 13:10, Daniel P. Berrangé wrote: On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression that monitor_register_hmp_info_hrt() does all the magic here i.e. it declares the underlying QMP command

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Feb 08, 2022 at 10:29:09AM +, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >> > Philippe Mathieu-Daudé writes: >> > >> > > On 7/2/22 20:34, Peter Maydell wrote: >> > >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland >>

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Dr. David Alan Gilbert
* Mark Cave-Ayland (mark.cave-ayl...@ilande.co.uk) wrote: > On 08/02/2022 11:52, Daniel P. Berrangé wrote: > > (cut) > > > > > The proposed device-specific command uses a mechanism originally made > > > > for modules instead (more on that below). > > > > > > > > I think we should make up our

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Daniel P . Berrangé
On Tue, Feb 08, 2022 at 12:39:04PM +, Mark Cave-Ayland wrote: > On 08/02/2022 11:38, Daniel P. Berrangé wrote: > > > On Thu, Jan 27, 2022 at 08:54:02PM +, Mark Cave-Ayland wrote: > > > This displays detailed information about the device registers and timers > > > o aid > > > debugging

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Daniel P . Berrangé
On Tue, Feb 08, 2022 at 01:06:59PM +, Mark Cave-Ayland wrote: > On 08/02/2022 12:49, Daniel P. Berrangé wrote: > > > > I was under the impression that monitor_register_hmp_info_hrt() does all > > > the > > > magic here i.e. it declares the underlying QMP command with an x- prefix > > > and

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Mark Cave-Ayland
On 08/02/2022 11:52, Daniel P. Berrangé wrote: (cut) The proposed device-specific command uses a mechanism originally made for modules instead (more on that below). I think we should make up our minds which way we want device-specific commands done, then do *all* of them that way. I think

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Mark Cave-Ayland
On 08/02/2022 10:29, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: Philippe Mathieu-Daudé writes: On 7/2/22 20:34, Peter Maydell wrote: On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: This displays detailed information about the device registers and

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Mark Cave-Ayland
On 08/02/2022 12:49, Daniel P. Berrangé wrote: I was under the impression that monitor_register_hmp_info_hrt() does all the magic here i.e. it declares the underlying QMP command with an x- prefix and effectively encapsulates the text field in a way that says "this is an unreliable text opaque

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Mark Cave-Ayland
On 08/02/2022 11:38, Daniel P. Berrangé wrote: On Thu, Jan 27, 2022 at 08:54:02PM +, Mark Cave-Ayland wrote: This displays detailed information about the device registers and timers to aid debugging problems with timers and interrupts. Signed-off-by: Mark Cave-Ayland ---

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Dr. David Alan Gilbert
* Mark Cave-Ayland (mark.cave-ayl...@ilande.co.uk) wrote: > On 08/02/2022 10:29, Dr. David Alan Gilbert wrote: > > > * Markus Armbruster (arm...@redhat.com) wrote: > > > Philippe Mathieu-Daudé writes: > > > > > > > On 7/2/22 20:34, Peter Maydell wrote: > > > > > On Thu, 27 Jan 2022 at 21:03,

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Daniel P . Berrangé
On Tue, Feb 08, 2022 at 10:29:09AM +, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: > > Philippe Mathieu-Daudé writes: > > > > > On 7/2/22 20:34, Peter Maydell wrote: > > >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland > > >> wrote: > > >>> > > >>> This

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Daniel P . Berrangé
On Thu, Jan 27, 2022 at 08:54:02PM +, Mark Cave-Ayland wrote: > This displays detailed information about the device registers and timers to > aid > debugging problems with timers and interrupts. > > Signed-off-by: Mark Cave-Ayland > --- > hmp-commands-info.hx | 12 ++ >

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Philippe Mathieu-Daudé writes: > > > On 7/2/22 20:34, Peter Maydell wrote: > >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland > >> wrote: > >>> > >>> This displays detailed information about the device registers and timers > >>> to aid > >>>

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-08 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/2/22 20:34, Peter Maydell wrote: >> On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland >> wrote: >>> >>> This displays detailed information about the device registers and timers to >>> aid >>> debugging problems with timers and interrupts. >>> >>>

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-07 Thread Philippe Mathieu-Daudé via
On 7/2/22 20:34, Peter Maydell wrote: On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: This displays detailed information about the device registers and timers to aid debugging problems with timers and interrupts. Signed-off-by: Mark Cave-Ayland --- hmp-commands-info.hx | 12 ++

Re: [PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-02-07 Thread Peter Maydell
On Thu, 27 Jan 2022 at 21:03, Mark Cave-Ayland wrote: > > This displays detailed information about the device registers and timers to > aid > debugging problems with timers and interrupts. > > Signed-off-by: Mark Cave-Ayland > --- > hmp-commands-info.hx | 12 ++ > hw/misc/mos6522.c| 92

[PATCH 08/11] mos6522: add "info via" HMP command for debugging

2022-01-27 Thread Mark Cave-Ayland
This displays detailed information about the device registers and timers to aid debugging problems with timers and interrupts. Signed-off-by: Mark Cave-Ayland --- hmp-commands-info.hx | 12 ++ hw/misc/mos6522.c| 92 2 files changed, 104