Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-12 Thread Cédric Le Goater
On 3/11/21 6:27 PM, Peter Xu wrote: > On Thu, Mar 11, 2021 at 05:21:49PM +0100, Philippe Mathieu-Daudé wrote: >> +Aspeed team >> >> On 3/11/21 1:18 PM, Philippe Mathieu-Daudé wrote: >>> On 3/10/21 9:29 PM, Peter Xu wrote: >> Yeah no worry - it's just that I feel one memory_region_init_alias()

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Philippe Mathieu-Daudé
On 3/11/21 6:27 PM, Peter Xu wrote: > On Thu, Mar 11, 2021 at 05:21:49PM +0100, Philippe Mathieu-Daudé wrote: >> +Aspeed team >> >> On 3/11/21 1:18 PM, Philippe Mathieu-Daudé wrote: >>> On 3/10/21 9:29 PM, Peter Xu wrote: >> Yeah no worry - it's just that I feel one memory_region_init_alias()

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Philippe Mathieu-Daudé
On 3/11/21 5:21 PM, Philippe Mathieu-Daudé wrote: > +Aspeed team > > On 3/11/21 1:18 PM, Philippe Mathieu-Daudé wrote: >> On 3/10/21 9:29 PM, Peter Xu wrote: > >>> Yeah no worry - it's just that I feel one memory_region_init_alias() call is >>> probably missing in your huge series somewhere, so

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Peter Xu
On Thu, Mar 11, 2021 at 05:21:49PM +0100, Philippe Mathieu-Daudé wrote: > +Aspeed team > > On 3/11/21 1:18 PM, Philippe Mathieu-Daudé wrote: > > On 3/10/21 9:29 PM, Peter Xu wrote: > > >> Yeah no worry - it's just that I feel one memory_region_init_alias() call > >> is > >> probably missing in

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Peter Xu
On Thu, Mar 11, 2021 at 05:21:49PM +0100, Philippe Mathieu-Daudé wrote: > So using: > > -- >8 -- > diff --git a/softmmu/memory.c b/softmmu/memory.c > index 874a8fccdee..8ce2d7f83b9 100644 > --- a/softmmu/memory.c > +++ b/softmmu/memory.c > @@ -713,6 +713,12 @@ static MemoryRegion >

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Philippe Mathieu-Daudé
+Aspeed team On 3/11/21 1:18 PM, Philippe Mathieu-Daudé wrote: > On 3/10/21 9:29 PM, Peter Xu wrote: >> Yeah no worry - it's just that I feel one memory_region_init_alias() call is >> probably missing in your huge series somewhere, so that you'll take that >> alias >> MR as subregion rather

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-11 Thread Philippe Mathieu-Daudé
On 3/10/21 9:29 PM, Peter Xu wrote: > On Wed, Mar 10, 2021 at 09:11:40PM +0100, Philippe Mathieu-Daudé wrote: /* ISA bus: IO space at 0x9000, mem space at 0x9100 */ -memory_region_init(isa_io, NULL, "isa-io", 0x0001); memory_region_init(isa_mem, NULL,

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-10 Thread Jiaxun Yang
On Thu, Mar 11, 2021, at 3:12 AM, Philippe Mathieu-Daudé wrote: > No need to create a local ISA I/O MemoryRegion, use get_system_io(). > > This partly reverts commit 5c63bcf7501527b844f61624957bdba254d75bfc. > > Signed-off-by: Philippe Mathieu-Daudé No luck to boot arcboot with current jazz

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-10 Thread Peter Xu
On Wed, Mar 10, 2021 at 09:11:40PM +0100, Philippe Mathieu-Daudé wrote: > >> /* ISA bus: IO space at 0x9000, mem space at 0x9100 */ > >> -memory_region_init(isa_io, NULL, "isa-io", 0x0001); > >> memory_region_init(isa_mem, NULL, "isa-mem", 0x0100); > >> -

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-10 Thread Philippe Mathieu-Daudé
On 3/10/21 8:49 PM, Peter Xu wrote: > On Wed, Mar 10, 2021 at 08:12:54PM +0100, Philippe Mathieu-Daudé wrote: >> No need to create a local ISA I/O MemoryRegion, use get_system_io(). >> >> This partly reverts commit 5c63bcf7501527b844f61624957bdba254d75bfc. > > I think it's not a clean revert of

Re: [PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-10 Thread Peter Xu
On Wed, Mar 10, 2021 at 08:12:54PM +0100, Philippe Mathieu-Daudé wrote: > No need to create a local ISA I/O MemoryRegion, use get_system_io(). > > This partly reverts commit 5c63bcf7501527b844f61624957bdba254d75bfc. I think it's not a clean revert of that, see below. > > Signed-off-by:

[PATCH 1/2] hw/mips/jazz: Use generic I/O bus via get_system_io()

2021-03-10 Thread Philippe Mathieu-Daudé
No need to create a local ISA I/O MemoryRegion, use get_system_io(). This partly reverts commit 5c63bcf7501527b844f61624957bdba254d75bfc. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/jazz.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/mips/jazz.c