Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-31 Thread Peter Xu
On Wed, Jan 31, 2024 at 10:14:58AM -0300, Fabiano Rosas wrote: > > I am thinking the p->normal is mostly redundant.. at least on the sender > > side that I just read. Since I'll be preparing a new spin of the multifd > > cleanup series I posted, maybe I can append one more to try dropping > >

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-31 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Jan 30, 2024 at 12:11:47PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: >> >> >> +static

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 12:11:47PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: > >> >> +static MultiFDMethods

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-30 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: >> >> +static MultiFDMethods multifd_socket_ops = { >> >> +.send_setup = multifd_socket_send_setup, >> >> +

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-30 Thread Peter Xu
On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: > >> +static MultiFDMethods multifd_socket_ops = { > >> +.send_setup = multifd_socket_send_setup, > >> +.send_cleanup =

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-29 Thread Fabiano Rosas
Peter Xu writes: > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: >> +static MultiFDMethods multifd_socket_ops = { >> +.send_setup = multifd_socket_send_setup, >> +.send_cleanup = multifd_socket_send_cleanup, >> +.send_prepare = multifd_socket_send_prepare, > > Here

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-28 Thread Peter Xu
On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: > +static MultiFDMethods multifd_socket_ops = { > +.send_setup = multifd_socket_send_setup, > +.send_cleanup = multifd_socket_send_cleanup, > +.send_prepare = multifd_socket_send_prepare, Here it's named with "socket",

[PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-26 Thread Fabiano Rosas
For multifd we currently choose exclusively between migration using compression or migration without compression. The compression method is chosen via the multifd_compression parameter (none, zlib, zstd). We've been using the 'none' value to mean the regular socket migration. Rename the