Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:59, Yuri Benditovich wrote: On Mon, Feb 8, 2021 at 6:11 AM Jason Wang wrote: On 2021/2/5 上午4:29, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by respective vhost. This may create migration problems in future if vhost

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:46, Yuri Benditovich wrote: On Mon, Feb 8, 2021 at 5:15 AM Jason Wang wrote: On 2021/2/5 下午9:38, Michael S. Tsirkin wrote: On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Yuri Benditovich
On Mon, Feb 8, 2021 at 5:15 AM Jason Wang wrote: > > > On 2021/2/5 下午9:38, Michael S. Tsirkin wrote: > > On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: > >> Currently virtio-net silently clears features if they are > >> not supported by respective vhost. This may create

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-08 Thread Yuri Benditovich
On Mon, Feb 8, 2021 at 6:11 AM Jason Wang wrote: > > > On 2021/2/5 上午4:29, Yuri Benditovich wrote: > > Currently virtio-net silently clears features if they are > > not supported by respective vhost. This may create migration > > problems in future if vhost features on the source and destination

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-07 Thread Jason Wang
On 2021/2/5 下午9:38, Michael S. Tsirkin wrote: On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by respective vhost. This may create migration problems in future if vhost features on the source and

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-07 Thread Jason Wang
On 2021/2/5 上午4:29, Yuri Benditovich wrote: Currently virtio-net silently clears features if they are not supported by respective vhost. This may create migration problems in future if vhost features on the source and destination are different. Implement graceful fallback to no-vhost mode when

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-05 Thread Michael S. Tsirkin
On Fri, Feb 05, 2021 at 08:38:49AM -0500, Michael S. Tsirkin wrote: > On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: > > Currently virtio-net silently clears features if they are > > not supported by respective vhost. This may create migration > > problems in future if vhost

Re: [PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-05 Thread Michael S. Tsirkin
On Thu, Feb 04, 2021 at 10:29:15PM +0200, Yuri Benditovich wrote: > Currently virtio-net silently clears features if they are > not supported by respective vhost. This may create migration > problems in future if vhost features on the source and destination > are different. Implement graceful

[PATCH 3/3] virtio-net: graceful fallback to vhost=off for tap netdev

2021-02-04 Thread Yuri Benditovich
Currently virtio-net silently clears features if they are not supported by respective vhost. This may create migration problems in future if vhost features on the source and destination are different. Implement graceful fallback to no-vhost mode when some acked features contradict with vhost. The