Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-09-09 Thread Andrew Melnichenko
Hi, > Ther first two are bogus. /work/armbru/tmp/inst-qemu/... is where "make > install" would put things. I last ran "make install" almost three > months ago. > The stamp check is implemented only for the RSS helper. Qemu looks for a helper first in HelpDir, then next to the binary. Bridge/PR

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-09-03 Thread Markus Armbruster
Andrew Melnichenko writes: > Hi, > >> Got something I could git-pull? >> > I can share some links for tests: > https://github.com/daynix/qemu/tree/HelperEBPFv3 - qemu with helper > https://github.com/daynix/libvirt/tree/RSS_RFC_v1 - libvirt with RSS Thanks! I get a few warnings. I'm copying

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-09-03 Thread Markus Armbruster
Yuri Benditovich writes: > On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster wrote: >> >> Yuri Benditovich writes: >> >> > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster >> > wrote: >> >> >> >> Yuri Benditovich writes: >> >> >> >> > On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster >>

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-31 Thread Andrew Melnichenko
Hi, > Got something I could git-pull? > I can share some links for tests: https://github.com/daynix/qemu/tree/HelperEBPFv3 - qemu with helper https://github.com/daynix/libvirt/tree/RSS_RFC_v1 - libvirt with RSS On Tue, Aug 31, 2021 at 6:00 PM Markus Armbruster wrote: > Yuri Benditovich

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-31 Thread Markus Armbruster
Yuri Benditovich writes: > On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster wrote: >> >> Yuri Benditovich writes: >> >> > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster >> > wrote: [...] >> >> So let's try again: if libvirt does use the wrong RSS helper, how does >> >> the system

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-30 Thread Yuri Benditovich
On Mon, Aug 30, 2021 at 11:14 AM Markus Armbruster wrote: > > Yuri Benditovich writes: > > > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster wrote: > >> > >> Yuri Benditovich writes: > >> > >> > On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster > >> > wrote: > >> >> > >> >> Andrew

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-30 Thread Markus Armbruster
Yuri Benditovich writes: > On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster wrote: >> >> Yuri Benditovich writes: >> >> > On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster >> > wrote: >> >> >> >> Andrew Melnichenko writes: >> >> >> >> > Hi, >> >> > >> >> >> The helper may or may not be

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-30 Thread Yuri Benditovich
On Mon, Aug 30, 2021 at 9:10 AM Markus Armbruster wrote: > > Yuri Benditovich writes: > > > On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster wrote: > >> > >> Andrew Melnichenko writes: > >> > >> > Hi, > >> > > >> >> The helper may or may not be installed at the path compiled into QEMU. > >>

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-30 Thread Markus Armbruster
Yuri Benditovich writes: > On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster wrote: >> >> Andrew Melnichenko writes: >> >> > Hi, >> > >> >> The helper may or may not be installed at the path compiled into QEMU. >> >> >> > Yes, so the helper will not be called - QEMU will try to initiate eBPF

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-29 Thread Yuri Benditovich
On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster wrote: > > Andrew Melnichenko writes: > > > Hi, > > > >> The helper may or may not be installed at the path compiled into QEMU. > >> > > Yes, so the helper will not be called - QEMU will try to initiate eBPF RSS > > or use "in-qemu" RSS. > > My

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-25 Thread Markus Armbruster
Andrew Melnichenko writes: > Hi, > Yes, the stamp check was added. > So the qemu emulator should return a suitable RSS BPF helper or nothing. > Each qemu emulator may have a different helper that suits it. > So, the idea is to ask for the helper from qemu. Please answer the question below. > >

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-25 Thread Andrew Melnichenko
Hi, Yes, the stamp check was added. So the qemu emulator should return a suitable RSS BPF helper or nothing. Each qemu emulator may have a different helper that suits it. So, the idea is to ask for the helper from qemu. On Tue, Aug 24, 2021 at 9:41 AM Markus Armbruster wrote: > Andrew

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-24 Thread Markus Armbruster
Andrew Melnichenko writes: > Hi, > >> The helper may or may not be installed at the path compiled into QEMU. >> > Yes, so the helper will not be called - QEMU will try to initiate eBPF RSS > or use "in-qemu" RSS. My point is: the proposed command's mission is to help the management application

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-10 Thread Andrew Melnichenko
Hi, > The helper may or may not be installed at the path compiled into QEMU. > Yes, so the helper will not be called - QEMU will try to initiate eBPF RSS or use "in-qemu" RSS. What happens when you use the wrong helper? > UB - in most cases, eBPF program will work with wrong configurations.

Re: [PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-08-07 Thread Markus Armbruster
Andrew Melnychenko writes: > New qmp command to query ebpf helper. > It's crucial that qemu and helper are in sync and in touch. > Technically helper should pass eBPF fds that qemu may accept. > And different qemu's builds may have different eBPF programs and helpers. > Qemu returns helper that

[PATCH 5/5] qmp: Added qemu-ebpf-rss-path command.

2021-07-13 Thread Andrew Melnychenko
New qmp command to query ebpf helper. It's crucial that qemu and helper are in sync and in touch. Technically helper should pass eBPF fds that qemu may accept. And different qemu's builds may have different eBPF programs and helpers. Qemu returns helper that should "fit" to virtio-net.