Re: [PATCH for-9.1] util/log: add cleanup function

2024-04-24 Thread Vladimir Sementsov-Ogievskiy
On 22.04.24 22:29, Stefan Hajnoczi wrote: On Wed, Apr 17, 2024 at 09:33:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: We leak global_filename, and do not close global_file. Let's fix that. What is the goal? Leaking global_filename does not cause unbounded memory consumption. I guess the

Re: [PATCH for-9.1] util/log: add cleanup function

2024-04-22 Thread Stefan Hajnoczi
On Wed, Apr 17, 2024 at 09:33:33PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We leak global_filename, and do not close global_file. Let's fix that. What is the goal? Leaking global_filename does not cause unbounded memory consumption. I guess the goal in freeing global_filename is to keep

[PATCH for-9.1] util/log: add cleanup function

2024-04-17 Thread Vladimir Sementsov-Ogievskiy
We leak global_filename, and do not close global_file. Let's fix that. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Interesting: seems, nobody is maintainer of util/log.c util/log.c | 9 + 1 file changed, 9 insertions(+) diff --git a/util/log.c b/util/log.c index