Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-20 Thread BALATON Zoltan
On Tue, 20 Jun 2023, Michael S. Tsirkin wrote: On Tue, Jun 20, 2023 at 02:50:55AM +0200, BALATON Zoltan wrote: On Thu, 8 Jun 2023, BALATON Zoltan wrote: On Thu, 8 Jun 2023, Michael S. Tsirkin wrote: On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: On 07/06/2023 21:01,

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-20 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 05:20:37PM +0200, BALATON Zoltan wrote: > On Thu, 8 Jun 2023, Michael S. Tsirkin wrote: > > On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: > > > On 07/06/2023 21:01, BALATON Zoltan wrote: > > > > > > > On pegasos2 which has ACPI as part of VT8231 south

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-20 Thread Michael S. Tsirkin
On Tue, Jun 20, 2023 at 02:50:55AM +0200, BALATON Zoltan wrote: > On Thu, 8 Jun 2023, BALATON Zoltan wrote: > > On Thu, 8 Jun 2023, Michael S. Tsirkin wrote: > > > On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: > > > > On 07/06/2023 21:01, BALATON Zoltan wrote: > > > > > > > >

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-19 Thread BALATON Zoltan
On Thu, 8 Jun 2023, BALATON Zoltan wrote: On Thu, 8 Jun 2023, Michael S. Tsirkin wrote: On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: On 07/06/2023 21:01, BALATON Zoltan wrote: On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 08:35:42PM +0100, Mark Cave-Ayland wrote: > On 08/06/2023 16:13, Michael S. Tsirkin wrote: > > > On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: > > > On 07/06/2023 21:01, BALATON Zoltan wrote: > > > > > > > On pegasos2 which has ACPI as part of VT8231

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread Mark Cave-Ayland
On 08/06/2023 16:13, Michael S. Tsirkin wrote: On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: On 07/06/2023 21:01, BALATON Zoltan wrote: On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control register by accessing the second byte so

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread BALATON Zoltan
On Thu, 8 Jun 2023, Michael S. Tsirkin wrote: On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: On 07/06/2023 21:01, BALATON Zoltan wrote: On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control register by accessing the second byte so

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 12:37:08PM +0100, Mark Cave-Ayland wrote: > On 07/06/2023 21:01, BALATON Zoltan wrote: > > > On pegasos2 which has ACPI as part of VT8231 south bridge the board > > firmware writes PM control register by accessing the second byte so > > addr will be 1. This wasn't handled

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread Mark Cave-Ayland
On 07/06/2023 21:01, BALATON Zoltan wrote: On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control register by accessing the second byte so addr will be 1. This wasn't handled correctly and the write went to addr 0 instead. Remove the acpi_pm1_cnt_write()

Re: [PATCH v2] hw/acpi: Fix PM control register access

2023-06-08 Thread Igor Mammedov
On Wed, 7 Jun 2023 22:01:25 +0200 (CEST) BALATON Zoltan wrote: > On pegasos2 which has ACPI as part of VT8231 south bridge the board > firmware writes PM control register by accessing the second byte so > addr will be 1. This wasn't handled correctly and the write went to > addr 0 instead.

[PATCH v2] hw/acpi: Fix PM control register access

2023-06-07 Thread BALATON Zoltan
On pegasos2 which has ACPI as part of VT8231 south bridge the board firmware writes PM control register by accessing the second byte so addr will be 1. This wasn't handled correctly and the write went to addr 0 instead. Remove the acpi_pm1_cnt_write() function which is used only once and does not