Re: [PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows

2023-06-29 Thread Richard Henderson
On 6/29/23 12:21, Ard Biesheuvel wrote: +/* AES ShiftRows, for complete unrolling. */ +enum { +AES_SH_0 = 0x0, +AES_SH_1 = 0x5, +AES_SH_2 = 0xa, +AES_SH_3 = 0xf, +AES_SH_4 = 0x4, +AES_SH_5 = 0x9, +AES_SH_6 = 0xe, +AES_SH_7 = 0x3, +AES_SH_8 = 0x8, +AES_SH_9

Re: [PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows

2023-06-29 Thread Ard Biesheuvel
On Fri, 9 Jun 2023 at 04:24, Richard Henderson wrote: > > These symbols will avoid the indirection through memory > when fully unrolling some new primitives. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > crypto/aes.c | 50

Re: [PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows

2023-06-19 Thread Daniel P . Berrangé
On Thu, Jun 08, 2023 at 07:23:28PM -0700, Richard Henderson wrote: > These symbols will avoid the indirection through memory > when fully unrolling some new primitives. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > crypto/aes.c | 50

[PATCH v2 05/38] crypto/aes: Add constants for ShiftRows, InvShiftRows

2023-06-08 Thread Richard Henderson
These symbols will avoid the indirection through memory when fully unrolling some new primitives. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- crypto/aes.c | 50 -- 1 file changed, 48 insertions(+), 2 deletions(-)