Re: [PATCH v2 1/6] migration/multifd: Join the TLS thread

2024-02-06 Thread Daniel P . Berrangé
On Tue, Feb 06, 2024 at 05:15:07PM +0800, Peter Xu wrote: > On Tue, Feb 06, 2024 at 08:53:45AM +, Daniel P. Berrangé wrote: > > AFAICS, it is not ovewriting 'p->thread' because at the time when the > > TLS thread is created, the main 'send thread' has not yet been > > created. The TLS thread

Re: [PATCH v2 1/6] migration/multifd: Join the TLS thread

2024-02-06 Thread Peter Xu
On Tue, Feb 06, 2024 at 08:53:45AM +, Daniel P. Berrangé wrote: > AFAICS, it is not ovewriting 'p->thread' because at the time when the > TLS thread is created, the main 'send thread' has not yet been > created. The TLS thread and send thread execution times are mutually > exclusive. IIUC

Re: [PATCH v2 1/6] migration/multifd: Join the TLS thread

2024-02-06 Thread Daniel P . Berrangé
On Mon, Feb 05, 2024 at 04:49:24PM -0300, Fabiano Rosas wrote: > We're currently leaking the resources of the TLS thread by not joining > it and also overwriting the p->thread pointer altogether. AFAICS, it is not ovewriting 'p->thread' because at the time when the TLS thread is created, the main

[PATCH v2 1/6] migration/multifd: Join the TLS thread

2024-02-05 Thread Fabiano Rosas
We're currently leaking the resources of the TLS thread by not joining it and also overwriting the p->thread pointer altogether. Fixes: a1af605bd5 ("migration/multifd: fix hangup with TLS-Multifd due to blocking handshake") Cc: qemu-stable Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas