Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
> > > > diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c > > index 68ca7e7fc2..756c69b3b0 100644 > > --- a/hw/i386/acpi-microvm.c > > +++ b/hw/i386/acpi-microvm.c > > @@ -189,6 +189,11 @@ static void acpi_build_microvm(AcpiBuildTables *tables, > > .reset_val =

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
> }; > +if (isa_check_device_existence("i8042")) { > +/* Indicates if i8042 is present or not */ > +fadt.iapc_boot_arch = (1 << 1); > +} > + > *data = fadt; > } > We do these things slightly differently. how about /* * second bit of 16 but IAPC_BOOT_ARCH

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Ani Sinha
On Mon, 21 Feb 2022, Liav Albani wrote: > This can allow the guest OS to determine more easily if i8042 controller > is present in the system or not, so it doesn't need to do probing of the > controller, but just initialize it immediately, before enumerating the > ACPI AML namespace. > >

Re: [PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Liav Albani
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index ebd47aa26f..5dc625b8d8 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -192,6 +192,11 @@ static void init_common_fadt_data(MachineState *ms, Object *o, .address = object_property_get_uint(o,

[PATCH v2 2/2] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table

2022-02-21 Thread Liav Albani
This can allow the guest OS to determine more easily if i8042 controller is present in the system or not, so it doesn't need to do probing of the controller, but just initialize it immediately, before enumerating the ACPI AML namespace. Signed-off-by: Liav Albani --- hw/acpi/aml-build.c