Re: [PATCH v2 2/6] target/arm: Fix nregs computation in do_ld_zpa

2024-02-06 Thread Richard Henderson
On 2/7/24 00:46, Peter Maydell wrote: @@ -4600,7 +4601,7 @@ static void do_ld_zpa(DisasContext *s, int zt, int pg, * accessible via the instruction encoding. */ assert(fn != NULL); -do_mem_zpa(s, zt, pg, addr, dtype, nreg, false, fn); +do_mem_zpa(s, zt, pg, addr,

Re: [PATCH v2 2/6] target/arm: Fix nregs computation in do_ld_zpa

2024-02-06 Thread Peter Maydell
On Tue, 6 Feb 2024 at 03:06, Richard Henderson wrote: > > The field is encoded as [0-3], which is convenient for > indexing our array of function pointers, but the true > value is [1-4]. Adjust before calling do_mem_zpa. > > Add an assert, and move the comment re passing ZT to > the helper back

[PATCH v2 2/6] target/arm: Fix nregs computation in do_ld_zpa

2024-02-05 Thread Richard Henderson
The field is encoded as [0-3], which is convenient for indexing our array of function pointers, but the true value is [1-4]. Adjust before calling do_mem_zpa. Add an assert, and move the comment re passing ZT to the helper back next to the relevant code. Cc: qemu-sta...@nongnu.org Fixes: