Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2024 at 01:15:43PM +0200, Philippe Mathieu-Daudé wrote: > On 25/4/24 12:40, Mark Cave-Ayland wrote: > > On 25/04/2024 11:26, Manos Pitsidianakis wrote: > > > > > On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: > > > > > > > > On Thu, Apr 25, 2024 at 01:04:31PM +0300,

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Philippe Mathieu-Daudé
On 25/4/24 12:40, Mark Cave-Ayland wrote: On 25/04/2024 11:26, Manos Pitsidianakis wrote: On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland wrote: On 25/04/2024

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Mark Cave-Ayland
On 25/04/2024 11:26, Manos Pitsidianakis wrote: On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland wrote: On 25/04/2024 07:30, Manos Pitsidianakis wrote: On Wed, 24

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Mark Cave-Ayland
On 25/04/2024 11:04, Manos Pitsidianakis wrote: On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland wrote: On 25/04/2024 07:30, Manos Pitsidianakis wrote: On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland wrote: On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: On 23/4/24 11:18, Manos

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2024 at 01:26:38PM +0300, Manos Pitsidianakis wrote: > On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: > > > > On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: > > > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland > > > wrote: > > > > > > > > On

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Manos Pitsidianakis
On Thu, 25 Apr 2024 at 13:24, Michael S. Tsirkin wrote: > > On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: > > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland > > wrote: > > > > > > On 25/04/2024 07:30, Manos Pitsidianakis wrote: > > > > > > > On Wed, 24 Apr 2024 at 13:31,

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Michael S. Tsirkin
On Thu, Apr 25, 2024 at 01:04:31PM +0300, Manos Pitsidianakis wrote: > On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland > wrote: > > > > On 25/04/2024 07:30, Manos Pitsidianakis wrote: > > > > > On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland > > > wrote: > > >> > > >> On 23/04/2024 12:05, Philippe

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Manos Pitsidianakis
On Thu, 25 Apr 2024 at 10:49, Mark Cave-Ayland wrote: > > On 25/04/2024 07:30, Manos Pitsidianakis wrote: > > > On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland > > wrote: > >> > >> On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: > >> > >>> On 23/4/24 11:18, Manos Pitsidianakis wrote: > On

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Mark Cave-Ayland
On 25/04/2024 07:30, Manos Pitsidianakis wrote: On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland wrote: On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: On 23/4/24 11:18, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 00:11,

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-25 Thread Manos Pitsidianakis
On Wed, 24 Apr 2024 at 13:31, Mark Cave-Ayland wrote: > > On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: > > > On 23/4/24 11:18, Manos Pitsidianakis wrote: > >> On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis > >> wrote: > >>> > >>> On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote:

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-24 Thread Mark Cave-Ayland
On 23/04/2024 12:05, Philippe Mathieu-Daudé wrote: On 23/4/24 11:18, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: On

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Philippe Mathieu-Daudé
On 23/4/24 11:18, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: On 22/4/24 23:02, Michael S. Tsirkin wrote: On Mon, Apr

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Manos Pitsidianakis
On Tue, 23 Apr 2024 at 11:47, Manos Pitsidianakis wrote: > > On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: > > > > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > > > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > > > On Mon, Apr 22, 2024 at 04:20:56PM +0200,

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-23 Thread Manos Pitsidianakis
On Tue, 23 Apr 2024 at 00:11, Michael S. Tsirkin wrote: > > On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > > > > Since VirtIO devices can change

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2024 at 11:07:21PM +0200, Philippe Mathieu-Daudé wrote: > On 22/4/24 23:02, Michael S. Tsirkin wrote: > > On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > > > Since VirtIO devices can change endianness at runtime, > > > we need to use the device endianness,

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-22 Thread Philippe Mathieu-Daudé
On 22/4/24 23:02, Michael S. Tsirkin wrote: On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: Since VirtIO devices can change endianness at runtime, we need to use the device endianness, not the target one. Cc: qemu-sta...@nongnu.org Fixes: eb9ad377bb ("virtio-sound:

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-22 Thread Michael S. Tsirkin
On Mon, Apr 22, 2024 at 04:20:56PM +0200, Philippe Mathieu-Daudé wrote: > Since VirtIO devices can change endianness at runtime, > we need to use the device endianness, not the target > one. > > Cc: qemu-sta...@nongnu.org > Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams") >

Re: [PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-22 Thread Manos Pitsidianakis
On Mon, 22 Apr 2024 17:20, Philippe Mathieu-Daudé wrote: Since VirtIO devices can change endianness at runtime, we need to use the device endianness, not the target one. Cc: qemu-sta...@nongnu.org Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams") Signed-off-by: Philippe

[PATCH v3] hw/audio/virtio-snd: Use device endianness instead of target one

2024-04-22 Thread Philippe Mathieu-Daudé
Since VirtIO devices can change endianness at runtime, we need to use the device endianness, not the target one. Cc: qemu-sta...@nongnu.org Fixes: eb9ad377bb ("virtio-sound: handle control messages and streams") Signed-off-by: Philippe Mathieu-Daudé --- v2: Use virtio_is_big_endian() v3: Remove