Re: [PATCH v3 12/14] target/ppc: Clean up ifdefs in excp_helper.c, part 1

2023-06-20 Thread BALATON Zoltan
On Tue, 20 Jun 2023, Nicholas Piggin wrote: On Fri Jun 16, 2023 at 9:03 AM AEST, BALATON Zoltan wrote: Use #ifdef, #ifndef for brevity and add comments to #endif that are more than a few lines apart for clarity. These will collide with the SOFTMMU ifdef changes that Philippe is working on I

Re: [PATCH v3 12/14] target/ppc: Clean up ifdefs in excp_helper.c, part 1

2023-06-19 Thread Nicholas Piggin
On Fri Jun 16, 2023 at 9:03 AM AEST, BALATON Zoltan wrote: > Use #ifdef, #ifndef for brevity and add comments to #endif that are > more than a few lines apart for clarity. These will collide with the SOFTMMU ifdef changes that Philippe is working on I think? They seem okay but maybe wait until

[PATCH v3 12/14] target/ppc: Clean up ifdefs in excp_helper.c, part 1

2023-06-15 Thread BALATON Zoltan
Use #ifdef, #ifndef for brevity and add comments to #endif that are more than a few lines apart for clarity. Signed-off-by: BALATON Zoltan --- target/ppc/excp_helper.c | 49 1 file changed, 24 insertions(+), 25 deletions(-) diff --git