Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-03-01 Thread Anthony Harivel
Hi Paolo, > > > +static void compute_default_paths(void) > > > +{ > > > +socket_path = g_build_filename("/run", "qemu-vmsr-helper.sock", > > > NULL); > > > +pidfile = g_build_filename("/run", "qemu-vmsr-helper.pid", NULL); > > > +} > > > > We shouldn't be hardcoding /run, we need to

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-02-21 Thread Anthony Harivel
Daniel P. Berrangé, Feb 21, 2024 at 14:47: > On Wed, Feb 21, 2024 at 02:19:11PM +0100, Anthony Harivel wrote: > > Daniel P. Berrangé, Jan 29, 2024 at 20:45: > > > On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote: > > > > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé > > > >

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-02-21 Thread Anthony Harivel
Daniel P. Berrangé, Jan 29, 2024 at 20:45: > On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote: > > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé > > wrote: > > > > diff --git a/meson.build b/meson.build > > > > index d0329966f1b4..93fc233b0891 100644 > > > > --- a/meson.build >

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-02-21 Thread Daniel P . Berrangé
On Wed, Feb 21, 2024 at 02:19:11PM +0100, Anthony Harivel wrote: > Daniel P. Berrangé, Jan 29, 2024 at 20:45: > > On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote: > > > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé > > > wrote: > > > > > diff --git a/meson.build b/meson.build

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-29 Thread Paolo Bonzini
On Mon, Jan 29, 2024 at 8:54 PM Daniel P. Berrangé wrote: > Looking again, the TID is never used after being checked. QEMU sends > the TID, but the helper never does anything with this information > except to check the TID belongs the PID. Why are we sending the TID ? Doh! sched_getaffinity's

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-29 Thread Daniel P . Berrangé
On Mon, Jan 29, 2024 at 07:45:51PM +, Daniel P. Berrangé wrote: > On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote: > > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé > > wrote: > > > > diff --git a/meson.build b/meson.build > > > > index d0329966f1b4..93fc233b0891 100644 >

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-29 Thread Daniel P . Berrangé
On Mon, Jan 29, 2024 at 08:33:21PM +0100, Paolo Bonzini wrote: > On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé > wrote: > > > diff --git a/meson.build b/meson.build > > > index d0329966f1b4..93fc233b0891 100644 > > > --- a/meson.build > > > +++ b/meson.build > > > @@ -4015,6 +4015,11 @@ if

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-29 Thread Paolo Bonzini
On Mon, Jan 29, 2024 at 7:53 PM Daniel P. Berrangé wrote: > > diff --git a/meson.build b/meson.build > > index d0329966f1b4..93fc233b0891 100644 > > --- a/meson.build > > +++ b/meson.build > > @@ -4015,6 +4015,11 @@ if have_tools > > dependencies: [authz, crypto, io, qom,

Re: [PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-29 Thread Daniel P . Berrangé
On Thu, Jan 25, 2024 at 08:22:13AM +0100, Anthony Harivel wrote: > Introduce a privileged helper to access RAPL MSR. > > The privileged helper tool, qemu-vmsr-helper, is designed to provide > virtual machines with the ability to read specific RAPL (Running Average > Power Limit) MSRs without

[PATCH v3 2/3] tools: build qemu-vmsr-helper

2024-01-24 Thread Anthony Harivel
Introduce a privileged helper to access RAPL MSR. The privileged helper tool, qemu-vmsr-helper, is designed to provide virtual machines with the ability to read specific RAPL (Running Average Power Limit) MSRs without requiring CAP_SYS_RAWIO privileges or relying on external, out-of-tree patches.