Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-30 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Fri, Jan 27, 2023 at 10:01:57AM -0500, Michael S. Tsirkin wrote: >> On Fri, Jan 27, 2023 at 02:54:30PM +, Peter Maydell wrote: >> > On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote: >> > > >> > > Also, why didn't you move sys/resource.h and other such files

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-28 Thread Michael S. Tsirkin
On Fri, Jan 27, 2023 at 10:01:57AM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 27, 2023 at 02:54:30PM +, Peter Maydell wrote: > > On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote: > > > > > > Also, why didn't you move sys/resource.h and other such files > > > to os-dep.h? I'm struggling to

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-27 Thread Michael S. Tsirkin
On Fri, Jan 27, 2023 at 02:54:30PM +, Peter Maydell wrote: > On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote: > > > > Also, why didn't you move sys/resource.h and other such files > > to os-dep.h? I'm struggling to understand the rules around what > > is or isn't included where? > > The

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-27 Thread Peter Maydell
On Thu, 19 Jan 2023 at 14:42, Warner Losh wrote: > > Also, why didn't you move sys/resource.h and other such files > to os-dep.h? I'm struggling to understand the rules around what > is or isn't included where? The rough rule of thumb is that if some OS needs a compatibility fixup or workaround

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-27 Thread Markus Armbruster
Warner Losh writes: [...] > So I'm happy with it. Thanks for the cleanup and the time to answer my > questions. > > Reviewed-by: Warner Losh Thank *you* for reviewing my patch :)

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 9:42 AM Markus Armbruster wrote: > Warner Losh writes: > > > On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster > > wrote: > > > >> Clean up includes so that osdep.h is included first and headers > >> which it implies are not included manually. > >> > >> This commit was

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Markus Armbruster
Warner Losh writes: > On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster > wrote: > >> Clean up includes so that osdep.h is included first and headers >> which it implies are not included manually. >> >> This commit was created with scripts/clean-includes. >> >> Signed-off-by: Markus Armbruster

Re: [PATCH v4 04/19] bsd-user: Clean up includes

2023-01-19 Thread Warner Losh
On Thu, Jan 19, 2023 at 12:00 AM Markus Armbruster wrote: > Clean up includes so that osdep.h is included first and headers > which it implies are not included manually. > > This commit was created with scripts/clean-includes. > > Signed-off-by: Markus Armbruster > --- > bsd-user/bsd-proc.h

[PATCH v4 04/19] bsd-user: Clean up includes

2023-01-18 Thread Markus Armbruster
Clean up includes so that osdep.h is included first and headers which it implies are not included manually. This commit was created with scripts/clean-includes. Signed-off-by: Markus Armbruster --- bsd-user/bsd-proc.h | 4 bsd-user/qemu.h | 1 -