Re: [PATCH v4 1/3] hw/riscv/boot.c: calculate fdt size after fdt_pack()

2023-01-28 Thread Bin Meng
On Sun, Jan 29, 2023 at 10:20 AM Bin Meng wrote: > > Hi Daniel, > > On Thu, Jan 26, 2023 at 9:53 PM Daniel Henrique Barboza > wrote: > > > > fdt_pack() can change the fdt size, meaning that fdt_totalsize() can > > contain a now deprecated (bigger) value. > > The commit message is a bit

Re: [PATCH v4 1/3] hw/riscv/boot.c: calculate fdt size after fdt_pack()

2023-01-28 Thread Bin Meng
Hi Daniel, On Thu, Jan 26, 2023 at 9:53 PM Daniel Henrique Barboza wrote: > > fdt_pack() can change the fdt size, meaning that fdt_totalsize() can > contain a now deprecated (bigger) value. The commit message is a bit confusing. The original code in this patch does not call fdt_pack(). So not

[PATCH v4 1/3] hw/riscv/boot.c: calculate fdt size after fdt_pack()

2023-01-26 Thread Daniel Henrique Barboza
fdt_pack() can change the fdt size, meaning that fdt_totalsize() can contain a now deprecated (bigger) value. Reviewed-by: Alistair Francis Signed-off-by: Daniel Henrique Barboza --- hw/riscv/boot.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/boot.c