Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-31 Thread Bin Meng
On Tue, Jan 31, 2023 at 5:57 PM Daniel Henrique Barboza wrote: > > > > On 1/30/23 22:00, Bin Meng wrote: > > On Tue, Jan 31, 2023 at 1:16 AM Daniel Henrique Barboza > > wrote: > >> > >> > >> > >> On 1/29/23 02:45, Bin Meng wrote: > >>> On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza >

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-31 Thread Daniel Henrique Barboza
On 1/30/23 22:00, Bin Meng wrote: On Tue, Jan 31, 2023 at 1:16 AM Daniel Henrique Barboza wrote: On 1/29/23 02:45, Bin Meng wrote: On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza wrote: As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a mem_size (which is

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-30 Thread Bin Meng
On Tue, Jan 31, 2023 at 1:16 AM Daniel Henrique Barboza wrote: > > > > On 1/29/23 02:45, Bin Meng wrote: > > On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza > > wrote: > >> > >> As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a > >> mem_size (which is defaulted to

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-30 Thread Daniel Henrique Barboza
On 1/30/23 14:16, Daniel Henrique Barboza wrote: On 1/29/23 02:45, Bin Meng wrote: On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza wrote: As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a mem_size (which is defaulted to MachineState::ram_size in all boards) and

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-30 Thread Daniel Henrique Barboza
On 1/29/23 02:45, Bin Meng wrote: On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza wrote: As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a mem_size (which is defaulted to MachineState::ram_size in all boards) and the FDT pointer. And it makes a very important

Re: [PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-28 Thread Bin Meng
On Thu, Jan 26, 2023 at 9:54 PM Daniel Henrique Barboza wrote: > > As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a > mem_size (which is defaulted to MachineState::ram_size in all boards) > and the FDT pointer. And it makes a very important assumption: the DRAM > interval

[PATCH v4 3/3] hw/riscv: change riscv_compute_fdt_addr() semantics

2023-01-26 Thread Daniel Henrique Barboza
As it is now, riscv_compute_fdt_addr() is receiving a dram_base, a mem_size (which is defaulted to MachineState::ram_size in all boards) and the FDT pointer. And it makes a very important assumption: the DRAM interval dram_base + mem_size is contiguous. This is indeed the case for most boards that