Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Wed, Nov 15, 2023 at 2:09 PM Akihiko Odaki wrote: > > > > On 2023/11/15 7:09, Yuri Benditovich wrote: > > > > > > On Tue, Nov 14, 2023 at 9:03 AM Akihiko Odaki > > wrote: > > > > On 2023/11/14 2:26, Yuri Benditovich wrote: > > > > > > > > >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/15 7:09, Yuri Benditovich wrote: On Tue, Nov 14, 2023 at 9:03 AM Akihiko Odaki > wrote: On 2023/11/14 2:26, Yuri Benditovich wrote: > > > On Mon, Nov 13, 2023 at 2:44 PM Akihiko Odaki mailto:akihiko.od...@daynix.com>

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Tue, Nov 14, 2023 at 9:03 AM Akihiko Odaki wrote: > On 2023/11/14 2:26, Yuri Benditovich wrote: > > > > > > On Mon, Nov 13, 2023 at 2:44 PM Akihiko Odaki > > wrote: > > > > On 2023/11/13 20:44, Yuri Benditovich wrote: > > > > > > > > > On

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/14 2:26, Yuri Benditovich wrote: On Mon, Nov 13, 2023 at 2:44 PM Akihiko Odaki > wrote: On 2023/11/13 20:44, Yuri Benditovich wrote: > > > On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Mon, Nov 13, 2023 at 2:44 PM Akihiko Odaki wrote: > On 2023/11/13 20:44, Yuri Benditovich wrote: > > > > > > On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki > > wrote: > > > > On 2023/11/03 22:14, Yuri Benditovich wrote: > > > > > > > > > On

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/13 20:44, Yuri Benditovich wrote: On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki > wrote: On 2023/11/03 22:14, Yuri Benditovich wrote: > > > On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Sat, Nov 11, 2023 at 5:28 PM Akihiko Odaki wrote: > On 2023/11/03 22:14, Yuri Benditovich wrote: > > > > > > On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki > > wrote: > > > > On 2023/11/03 18:35, Yuri Benditovich wrote: > > > > > > > > > On

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/03 22:14, Yuri Benditovich wrote: On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki > wrote: On 2023/11/03 18:35, Yuri Benditovich wrote: > > > On Thu, Nov 2, 2023 at 4:56 PM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Fri, Nov 3, 2023 at 11:55 AM Akihiko Odaki wrote: > On 2023/11/03 18:35, Yuri Benditovich wrote: > > > > > > On Thu, Nov 2, 2023 at 4:56 PM Akihiko Odaki > > wrote: > > > > On 2023/11/02 19:20, Yuri Benditovich wrote: > > > > > > > > > On

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/03 18:35, Yuri Benditovich wrote: On Thu, Nov 2, 2023 at 4:56 PM Akihiko Odaki > wrote: On 2023/11/02 19:20, Yuri Benditovich wrote: > > > On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin mailto:m...@redhat.com> >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 2, 2023 at 4:56 PM Akihiko Odaki wrote: > On 2023/11/02 19:20, Yuri Benditovich wrote: > > > > > > On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin > > wrote: > > > > On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > > > Probably

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/02 19:20, Yuri Benditovich wrote: On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin > wrote: On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > Probably we mix two different patches in this discussion. > Focusing on the patch

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 02, 2023 at 02:00:46PM +0200, Yuri Benditovich wrote: > > > On Thu, Nov 2, 2023 at 1:26 PM Michael S. Tsirkin wrote: > > On Thu, Nov 02, 2023 at 12:20:39PM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin > wrote: >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 2, 2023 at 1:26 PM Michael S. Tsirkin wrote: > On Thu, Nov 02, 2023 at 12:20:39PM +0200, Yuri Benditovich wrote: > > > > > > On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin > wrote: > > > > On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > > > Probably

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 02, 2023 at 12:20:39PM +0200, Yuri Benditovich wrote: > > > On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin wrote: > > On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > > Probably we mix two different patches in this discussion. > > Focusing on the

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 2, 2023 at 11:33 AM Michael S. Tsirkin wrote: > On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > > Probably we mix two different patches in this discussion. > > Focusing on the patch in the e-mail header: > > > > IMO it is not acceptable to fail QEMU run for one

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Thu, Nov 02, 2023 at 11:09:27AM +0200, Yuri Benditovich wrote: > Probably we mix two different patches in this discussion. > Focusing on the patch in the e-mail header: > > IMO it is not acceptable to fail QEMU run for one feature that we can't make > active when we silently drop all other

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

Probably we mix two different patches in this discussion. Focusing on the patch in the e-mail header: IMO it is not acceptable to fail QEMU run for one feature that we can't make active when we silently drop all other features in such a case. On Wed, Nov 1, 2023 at 11:15 AM Akihiko Odaki wrote:

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/01 18:09, Michael S. Tsirkin wrote: On Wed, Nov 01, 2023 at 05:35:50PM +0900, Akihiko Odaki wrote: On 2023/11/01 15:38, Michael S. Tsirkin wrote: On Wed, Nov 01, 2023 at 01:50:00PM +0900, Akihiko Odaki wrote: We had another discussion regarding migration for patch "virtio-net: Do

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Wed, Nov 01, 2023 at 05:35:50PM +0900, Akihiko Odaki wrote: > On 2023/11/01 15:38, Michael S. Tsirkin wrote: > > On Wed, Nov 01, 2023 at 01:50:00PM +0900, Akihiko Odaki wrote: > > > We had another discussion regarding migration for patch "virtio-net: Do > > > not > > > clear

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/01 15:38, Michael S. Tsirkin wrote: On Wed, Nov 01, 2023 at 01:50:00PM +0900, Akihiko Odaki wrote: We had another discussion regarding migration for patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT". It does change the runtime behavior so we need to take migration into

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Wed, Nov 01, 2023 at 01:50:00PM +0900, Akihiko Odaki wrote: > We had another discussion regarding migration for patch "virtio-net: Do not > clear VIRTIO_NET_F_HASH_REPORT". It does change the runtime behavior so we > need to take migration into account. I still think the patch does not >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/11/01 13:19, Jason Wang wrote: On Mon, Oct 30, 2023 at 9:15 PM Akihiko Odaki wrote: On 2023/10/30 21:51, Yuri Benditovich wrote: On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki mailto:akihiko.od...@daynix.com>> wrote: On 2023/10/30 21:14, Yuri Benditovich wrote: > >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Mon, Oct 30, 2023 at 9:15 PM Akihiko Odaki wrote: > > On 2023/10/30 21:51, Yuri Benditovich wrote: > > > > > > On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki > > wrote: > > > > On 2023/10/30 21:14, Yuri Benditovich wrote: > > > > > > > > > On

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/10/30 21:51, Yuri Benditovich wrote: On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki > wrote: On 2023/10/30 21:14, Yuri Benditovich wrote: > > > On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki mailto:akihiko.od...@daynix.com> >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Mon, Oct 30, 2023 at 2:21 PM Akihiko Odaki wrote: > On 2023/10/30 21:14, Yuri Benditovich wrote: > > > > > > On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki > > wrote: > > > > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > >

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On 2023/10/30 21:14, Yuri Benditovich wrote: On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki > wrote: vhost requires eBPF for RSS. When eBPF is not available, virtio-net implicitly disables RSS even if the user explicitly requests it. Return an

Re: [PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

On Mon, Oct 30, 2023 at 7:14 AM Akihiko Odaki wrote: > vhost requires eBPF for RSS. When eBPF is not available, virtio-net > implicitly disables RSS even if the user explicitly requests it. Return > an error instead of implicitly disabling RSS if RSS is requested but not > available. > I think

[PATCH v6 11/21] virtio-net: Return an error when vhost cannot enable RSS

vhost requires eBPF for RSS. When eBPF is not available, virtio-net implicitly disables RSS even if the user explicitly requests it. Return an error instead of implicitly disabling RSS if RSS is requested but not available. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 97