Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-28 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] cutils: Define min and max marcos Type: series Message-id: 1480069886-11703-1-git-send-email

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-27 Thread Yuval Shaia
On Sun, Nov 27, 2016 at 11:20:41PM +0100, Samuel Thibault wrote: > Yuval Shaia, on Mon 28 Nov 2016 00:18:26 +0200, wrote: > > On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote: > > > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > > > > -#ifndef _WIN32 > > > > -#define

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-27 Thread Samuel Thibault
Yuval Shaia, on Mon 28 Nov 2016 00:18:26 +0200, wrote: > On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote: > > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > > > -#ifndef _WIN32 > > > -#define min(x,y) ((x) < (y) ? (x) : (y)) > > > -#define max(x,y) ((x) > (y) ? (x) : (y))

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-27 Thread Yuval Shaia
On Sun, Nov 27, 2016 at 03:10:04PM +0100, Samuel Thibault wrote: > Hello, > > Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > > -#ifndef _WIN32 > > -#define min(x,y) ((x) < (y) ? (x) : (y)) > > -#define max(x,y) ((x) > (y) ? (x) : (y)) > > -#endif > > This has protection against _WIN32,

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-27 Thread Samuel Thibault
Hello, Yuval Shaia, on Fri 25 Nov 2016 12:31:26 +0200, wrote: > -#ifndef _WIN32 > -#define min(x,y) ((x) < (y) ? (x) : (y)) > -#define max(x,y) ((x) > (y) ? (x) : (y)) > -#endif This has protection against _WIN32, I guess that was on purpose. Perhaps qemu should avoid risking a clash with

Re: [Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-25 Thread Markus Armbruster
Yuval Shaia writes: > Signed-off-by: Yuval Shaia > --- > disas/m68k.c | 5 + > include/qemu/cutils.h | 3 +++ > slirp/slirp.h | 6 +- > 3 files changed, 5 insertions(+), 9 deletions(-) > > diff --git a/disas/m68k.c

[Qemu-devel] [PATCH] cutils: Define min and max marcos

2016-11-25 Thread Yuval Shaia
Signed-off-by: Yuval Shaia --- disas/m68k.c | 5 + include/qemu/cutils.h | 3 +++ slirp/slirp.h | 6 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/disas/m68k.c b/disas/m68k.c index 8e7c3f7..7794abc 100644 --- a/disas/m68k.c +++