[Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Carlo Marcelo Arenas Belon
Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Carlo --- Index: block-vvfat.c === RCS file: /sources/qemu/qemu/block-vvfat.c,v retrieving revision 1.16 diff -u -p

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Andreas Färber
Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this actually makes a difference? I believe Perl makes sizeof(char)

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Samuel Thibault
Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit : Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Thiemo Seufer
Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this actually makes a difference? Thiemo --- Index: block-vvfat.c

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Thiemo Seufer
Andreas Färber wrote: Am 04.01.2008 um 15:00 schrieb Samuel Thibault: Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit : Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Andreas_Färber [EMAIL PROTECTED] writes: : : Am 04.01.2008 um 15:00 schrieb Samuel Thibault: : : Andreas Färber, le Fri 04 Jan 2008 14:41:29 +0100, a écrit : : : Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: : : Carlo Marcelo Arenas Belon wrote: :

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Andreas Schwab
Andreas Färber [EMAIL PROTECTED] writes: Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this actually makes a

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Rob Landley
On Friday 04 January 2008 07:41:29 Andreas Färber wrote: Am 04.01.2008 um 14:20 schrieb Thiemo Seufer: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this

Re: [Qemu-devel] [PATCH] ensure all invocations to bdrv_{read, write} use (uint8_t *) for its third parameter

2008-01-04 Thread Carlo Marcelo Arenas Belon
On Fri, Jan 04, 2008 at 01:20:39PM +, Thiemo Seufer wrote: Carlo Marcelo Arenas Belon wrote: Trivial fix that ensures that all buffers used for bdrv_read or bdrv_write are from an array of the uint8_t type Do we have a host where this actually makes a difference? No that I know of