Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Kevin Wolf
Am 21.10.2009 20:08, schrieb Anthony Liguori: Glauber Costa wrote: On Wed, Oct 21, 2009 at 2:55 PM, Anthony Liguori anth...@codemonkey.ws wrote: Glauber Costa wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Luiz Capitulino
On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: Mulyadi Santosa wrote: On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa glom...@gmail.com wrote: You can provide a monitor command to do that something in the lines of: - add_macro key command_list -

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Kevin Wolf
Am 22.10.2009 16:40, schrieb Luiz Capitulino: On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: If the monitor accepted ; as a command separator, to put multiple commands on a single line, command_list could just be a quoted string which is processed as a line.

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Anthony Liguori
Luiz Capitulino wrote: Yeah, I agree. When testing migration, for example, I have to type 'migrate -d tcp:0:' several times... Maybe there's a smarter way to do this, but the monitor macros idea seems interesting to me. When we have QMP, we can create a QMP socket at a well known

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Luiz Capitulino
On Thu, 22 Oct 2009 17:02:29 +0200 Kevin Wolf kw...@redhat.com wrote: Am 22.10.2009 16:40, schrieb Luiz Capitulino: On Wed, 21 Oct 2009 19:35:03 +0100 Jamie Lokier ja...@shareable.org wrote: If the monitor accepted ; as a command separator, to put multiple commands on a single line,

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-22 Thread Anthony Liguori
Luiz Capitulino wrote: On Thu, 22 Oct 2009 10:40:54 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Luiz Capitulino wrote: Yeah, I agree. When testing migration, for example, I have to type 'migrate -d tcp:0:' several times... Maybe there's a smarter way to do this, but the

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Kevin Wolf
Am 20.10.2009 19:08, schrieb Daniel P. Berrange: On Tue, Oct 20, 2009 at 12:40:08PM +0200, Kevin Wolf wrote: Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 5:27 AM, Kevin Wolf kw...@redhat.com wrote: Am 20.10.2009 19:08, schrieb Daniel P. Berrange: On Tue, Oct 20, 2009 at 12:40:08PM +0200, Kevin Wolf wrote: Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 2:04 PM, Mulyadi Santosa mulyadi.sant...@gmail.com wrote: On Wed, Oct 21, 2009 at 8:52 PM, Glauber Costa glom...@gmail.com wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign whatever he wants out of

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Mulyadi Santosa
On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa glom...@gmail.com wrote: You can provide a monitor command to do that something in the lines of: - add_macro key command_list - remove_macro key - list_macros Please CMIIW, command_list here refers to at least one of monitor commands, right?

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 2:44 PM, Mulyadi Santosa mulyadi.sant...@gmail.com wrote: On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa glom...@gmail.com wrote: You can provide a monitor command to do that something in the lines of: - add_macro key command_list - remove_macro key - list_macros

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Anthony Liguori
Glauber Costa wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign whatever he wants out of that? Really? This seems exceedingly complicated to me. Redirecting the kernel output to serial and logging is a considerably

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Glauber Costa
On Wed, Oct 21, 2009 at 2:55 PM, Anthony Liguori anth...@codemonkey.ws wrote: Glauber Costa wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign whatever he wants out of that? Really?  This seems exceedingly complicated to

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Anthony Liguori
Glauber Costa wrote: On Wed, Oct 21, 2009 at 2:55 PM, Anthony Liguori anth...@codemonkey.ws wrote: Glauber Costa wrote: Why don't we provide a mechanism to make a macro out of a sequence of monitor commands, and let the user assign whatever he wants out of that? Really? This

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-21 Thread Jamie Lokier
Mulyadi Santosa wrote: On Wed, Oct 21, 2009 at 11:24 PM, Glauber Costa glom...@gmail.com wrote: You can provide a monitor command to do that something in the lines of: - add_macro key command_list - remove_macro key - list_macros Please CMIIW, command_list here refers to at least

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Gerd Hoffmann
On 10/20/09 05:16, Mulyadi Santosa wrote: As these message scrolls fast, I find it more intuitive if we could just press a key to pause the guest, giving us enough time to capture the display and resume the execution. If we switch to qemu monitor first, most of the time we already lost the

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2009 at 10:16:09AM +0700, Mulyadi Santosa wrote: Hi Anthony... On Tue, Oct 20, 2009 at 5:20 AM, Anthony Liguori anth...@codemonkey.ws wrote: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Kevin Wolf
Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console monitor first and type s or c respectively. Is this

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Anthony Liguori
Kevin Wolf wrote: Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console monitor first and type s or c

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Daniel P. Berrange
On Tue, Oct 20, 2009 at 12:40:08PM +0200, Kevin Wolf wrote: Am 20.10.2009 00:20, schrieb Anthony Liguori: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-20 Thread Mulyadi Santosa
Hi... On Wed, Oct 21, 2009 at 12:08 AM, Daniel P. Berrange berra...@redhat.com wrote: The problem with adding lots of magic key-sequences, is that the more you add, the more likely they are to clash with something that the guest OS wants to use. You may make this use case work, but break

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-19 Thread Anthony Liguori
Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console monitor first and type s or c respectively. Is this really common of an operation that you would need an

Re: [Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-19 Thread Mulyadi Santosa
Hi Anthony... On Tue, Oct 20, 2009 at 5:20 AM, Anthony Liguori anth...@codemonkey.ws wrote: Mulyadi Santosa wrote: IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console monitor first

[Qemu-devel] [PATCH] new SDL keyboard shortcuts to start and stop VM

2009-10-18 Thread Mulyadi Santosa
IMO, it would be faster if we provide keyboard shortcuts that will stop and resume VM execution right from SDL guest interface, rather than switching to console monitor first and type s or c respectively. Note: I simply skip checking the keys in encrypted block devices when resuming the VM. Not