Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-14 Thread Stefan Hajnoczi
On Mon, Nov 14, 2016 at 12:01:02AM +0100, Samuel Thibault wrote: > if_start() goes through the slirp->if_fastq and slirp->if_batchq > list of pending messages, and accesses ifm->ifq_so->so_nqueued of its > elements if ifm->ifq_so != NULL. When freeing a socket, we thus need > to make sure that

Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread Samuel Thibault
Hello, Note: no-re...@patchew.org, on Sun 13 Nov 2016 15:13:47 -0800, wrote: > Your series seems to have some coding style problems. See output below for > more information: > > === OUTPUT BEGIN === > fatal: unrecognized argument: --no-patch > Checking PATCH 1/1: ... > ERROR: suspect code

Re: [Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] slirp: Fix access to freed memory Message-id: 20161113230102.12173-1-samuel.thiba...@ens-lyon.org === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] slirp: Fix access to freed memory

2016-11-13 Thread Samuel Thibault
if_start() goes through the slirp->if_fastq and slirp->if_batchq list of pending messages, and accesses ifm->ifq_so->so_nqueued of its elements if ifm->ifq_so != NULL. When freeing a socket, we thus need to make sure that any pending message for this socket does not refer to the socket any more.