Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

Hello, Vincent Bernat, on Thu 17 Nov 2016 13:22:32 +0100, wrote: > ❦ 17 novembre 2016 13:20 +0100, Vincent Bernat  : > > > Some network equipments are requesting a file using the netascii > > protocol and this is not configurable. Currently, qemu's tftpd only > >

Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

❦ 17 novembre 2016 07:27 -0800, no-re...@patchew.org : > === OUTPUT BEGIN === > Checking PATCH 1/1: tftp: fake support for netascii protocol... > ERROR: suspect code indent for conditional statements (2, 6) > #24: FILE: slirp/tftp.c:329: > + if (strcasecmp(>x.tp_buf[k], "octet") == 0) { > +

Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

Hi, Your series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol Type: series Message-id: 20161117122000.22577-1-vincent.ber...@exoscale.ch === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

[Qemu-devel] [PATCH] tftp: fake support for netascii protocol

From: Vincent Bernat Some network equipments are requesting a file using the netascii protocol and this is not configurable. Currently, qemu's tftpd only supports the octet protocol. This commit makes it accept the netascii protocol as well but do not perform the requested

Re: [Qemu-devel] [PATCH] tftp: fake support for netascii protocol

❦ 17 novembre 2016 13:20 +0100, Vincent Bernat  : > Some network equipments are requesting a file using the netascii > protocol and this is not configurable. Currently, qemu's tftpd only > supports the octet protocol. This commit makes it accept the netascii >