Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-02-03 Thread Kevin Wolf
Am 31.01.2014 um 21:07 hat Max Reitz geschrieben: So in summary, it looks technically correct, but I'm not sure about maintainability. If the problems are only for this intermediate state, I'm okay with leaving them as they are, but otherwise we should try and figure out something. You're

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-31 Thread Max Reitz
On 29.01.2014 12:50, Kevin Wolf wrote: Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-29 Thread Kevin Wolf
Am 26.01.2014 um 20:02 hat Max Reitz geschrieben: Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be reused (in

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Max Reitz
On 27.01.2014 03:38, Benoît Canet wrote: Le Sunday 26 Jan 2014 à 20:02:34 (+0100), Max Reitz a écrit : Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Jeff Cody
On Sun, Jan 26, 2014 at 08:02:34PM +0100, Max Reitz wrote: Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-27 Thread Max Reitz
On 27.01.2014 20:31, Jeff Cody wrote: On Sun, Jan 26, 2014 at 08:02:34PM +0100, Max Reitz wrote: Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is

[Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-26 Thread Max Reitz
Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will be reused (in the same way as bdrv_open() already did).

Re: [Qemu-devel] [PATCH 01/10] block: Change BDS parameter of bdrv_open() to **

2014-01-26 Thread Benoît Canet
Le Sunday 26 Jan 2014 à 20:02:34 (+0100), Max Reitz a écrit : Make bdrv_open() take a pointer to a BDS pointer, similarly to bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open() will create a new BDS with an empty name; if the BDS pointer is not NULL, that existing BDS will