Re: [Qemu-devel] [PATCH 08/19] target/ppc: Fix nip on power management instructions

2019-02-15 Thread Cédric Le Goater
On 2/13/19 1:04 AM, Benjamin Herrenschmidt wrote: > On Tue, 2019-02-12 at 17:02 +1100, David Gibson wrote: >> On Mon, Jan 28, 2019 at 10:46:14AM +0100, Cédric Le Goater wrote: >>> From: Benjamin Herrenschmidt >>> >>> Those instructions currently raise an exception from within >>> the helper. This

Re: [Qemu-devel] [PATCH 08/19] target/ppc: Fix nip on power management instructions

2019-02-12 Thread Benjamin Herrenschmidt
On Tue, 2019-02-12 at 17:02 +1100, David Gibson wrote: > On Mon, Jan 28, 2019 at 10:46:14AM +0100, Cédric Le Goater wrote: > > From: Benjamin Herrenschmidt > > > > Those instructions currently raise an exception from within > > the helper. This tends to result in a bogus nip value in > > the env

Re: [Qemu-devel] [PATCH 08/19] target/ppc: Fix nip on power management instructions

2019-02-12 Thread David Gibson
On Mon, Jan 28, 2019 at 10:46:14AM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Those instructions currently raise an exception from within > the helper. This tends to result in a bogus nip value in > the env context (typically the beginning of the TB). Such > a helper needs

[Qemu-devel] [PATCH 08/19] target/ppc: Fix nip on power management instructions

2019-01-28 Thread Cédric Le Goater
From: Benjamin Herrenschmidt Those instructions currently raise an exception from within the helper. This tends to result in a bogus nip value in the env context (typically the beginning of the TB). Such a helper needs a gen_update_nip() first. This fixes it with a different approach which is