Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-23 Thread Anthony Liguori
Alex Horn alex.h...@cs.ox.ac.uk writes: * Define enum for TMP105 registers * Move tmp105_set() from I2C to TMP105 header * Document units and range of temperature as preconditions Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk Applied. Thanks. Regards, Anthony Liguori --- hw/i2c.h

[Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-05 Thread Alex Horn
* Define enum for TMP105 registers * Move tmp105_set() from I2C to TMP105 header * Document units and range of temperature as preconditions Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk --- hw/i2c.h|3 -- hw/tmp105.c | 17 --- hw/tmp105.h | 67

Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-05 Thread Andreas Färber
Am 05.12.2012 13:34, schrieb Alex Horn: * Define enum for TMP105 registers * Move tmp105_set() from I2C to TMP105 header * Document units and range of temperature as preconditions Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk Looks great, thanks! Reviewed-by: Andreas Färber

[Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-04 Thread Alex Horn
* Define constants for TMP105 registers. * Move tmp105_set() from I2C to TMP105 header. Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk --- hw/i2c.h|3 --- hw/tmp105.c | 17 + hw/tmp105.h | 34 ++ 3 files changed, 43 insertions(+), 11

Re: [Qemu-devel] [PATCH 1/1] tmp105: Create API for TMP105 temperature sensor.

2012-12-04 Thread Andreas Färber
Am 04.12.2012 20:23, schrieb Alex Horn: * Define constants for TMP105 registers. * Move tmp105_set() from I2C to TMP105 header. Signed-off-by: Alex Horn alex.h...@cs.ox.ac.uk CC'ing TMP105 author and ARM maintainer. Comments inline. --- hw/i2c.h|3 --- hw/tmp105.c | 17