Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-12-02 Thread Anthony Liguori
Gerd Hoffmann wrote: On 11/23/09 16:20, Anthony Liguori wrote: Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/20/09 18:41, Paul Brook wrote: On Tuesday 17 November 2009, Gerd Hoffmann wrote: Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid walking all the chardevs a second time after initialization

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Paul Brook
On Monday 23 November 2009, Gerd Hoffmann wrote: On 11/20/09 18:41, Paul Brook wrote: On Tuesday 17 November 2009, Gerd Hoffmann wrote: Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. cheers, Gerd

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Paul Brook
On Monday 23 November 2009, Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. That's

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2009 at 04:10:48PM +0100, Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Anthony Liguori
Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc. A vc is what renders the for VNC so

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-23 Thread Gerd Hoffmann
On 11/23/09 16:20, Anthony Liguori wrote: Gerd Hoffmann wrote: On 11/23/09 14:26, Paul Brook wrote: I thinking more that this should be done by the character backend itself. For example, the graphical consoles should probably be putting this as part of the window title Doesn't work with vnc.

Re: [Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-20 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid walking all the chardevs a second time after initialization just to print the greeting. I doubt this

[Qemu-devel] [PATCH 1/9] chardev: add greeting

2009-11-17 Thread Gerd Hoffmann
Add a greeting string to CharDriverState which is printed after initialization. Used to have the qemu vc consoles labeled. This way we can avoid walking all the chardevs a second time after initialization just to print the greeting. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---