Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-05 Thread Cédric Le Goater
On 12/04/2017 01:20 AM, David Gibson wrote: > On Sat, Dec 02, 2017 at 08:46:19AM -0600, Benjamin Herrenschmidt wrote: >> On Sat, 2017-12-02 at 08:45 -0600, Benjamin Herrenschmidt wrote: >>> On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote: Hm, ok. Guest endian (or at least, not

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-03 Thread David Gibson
On Sat, Dec 02, 2017 at 08:46:19AM -0600, Benjamin Herrenschmidt wrote: > On Sat, 2017-12-02 at 08:45 -0600, Benjamin Herrenschmidt wrote: > > On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote: > > > > > > Hm, ok. Guest endian (or at least, not definitively host-endian) data > > > in a plain

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-02 Thread Benjamin Herrenschmidt
On Sat, 2017-12-02 at 08:45 -0600, Benjamin Herrenschmidt wrote: > On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote: > > > > Hm, ok. Guest endian (or at least, not definitively host-endian) data > > in a plain uint32_t makes me uncomfortable. Could we use char data[4] > > instead, to make

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-02 Thread Benjamin Herrenschmidt
On Fri, 2017-12-01 at 15:10 +1100, David Gibson wrote: > > Hm, ok. Guest endian (or at least, not definitively host-endian) data > in a plain uint32_t makes me uncomfortable. Could we use char data[4] > instead, to make it clear it's a byte-ordered buffer, rather than a > number as far as the

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-01 Thread Cédric Le Goater
On 12/01/2017 05:10 AM, David Gibson wrote: > On Thu, Nov 30, 2017 at 02:16:30PM +, Cédric Le Goater wrote: >> On 11/30/2017 04:49 AM, David Gibson wrote: >>> On Thu, Nov 23, 2017 at 02:29:44PM +0100, Cédric Le Goater wrote: If a triggered event is let through, the Event Queue data

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-12-01 Thread David Gibson
On Thu, Nov 30, 2017 at 02:16:30PM +, Cédric Le Goater wrote: > On 11/30/2017 04:49 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 02:29:44PM +0100, Cédric Le Goater wrote: > >> If a triggered event is let through, the Event Queue data defined in the > >> associated IVE is pushed in the

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-11-30 Thread Cédric Le Goater
On 11/30/2017 04:49 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:44PM +0100, Cédric Le Goater wrote: >> If a triggered event is let through, the Event Queue data defined in the >> associated IVE is pushed in the in-memory event queue. The latter is a >> circular buffer provided by the

Re: [Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-11-29 Thread David Gibson
On Thu, Nov 23, 2017 at 02:29:44PM +0100, Cédric Le Goater wrote: > If a triggered event is let through, the Event Queue data defined in the > associated IVE is pushed in the in-memory event queue. The latter is a > circular buffer provided by the OS using the H_INT_SET_QUEUE_CONFIG hcall, > one

[Qemu-devel] [PATCH 14/25] spapr: push the XIVE EQ data in OS event queue

2017-11-23 Thread Cédric Le Goater
If a triggered event is let through, the Event Queue data defined in the associated IVE is pushed in the in-memory event queue. The latter is a circular buffer provided by the OS using the H_INT_SET_QUEUE_CONFIG hcall, one per server and priority couple. It is composed of Event Queue entries which