Re: [Qemu-devel] [PATCH 3/3] block: per caller dirty bitmap

2013-11-04 Thread Paolo Bonzini
Il 04/11/2013 07:59, Fam Zheng ha scritto: I think callers outside block.c should only call hbitmap_set/hbitmap_reset; resetting is typically done before processing sectors and setting after an error (both of which happen privately to each task). Thus you probably should add a fourth patch

Re: [Qemu-devel] [PATCH 3/3] block: per caller dirty bitmap

2013-11-03 Thread Fam Zheng
On 10/30/2013 03:49 PM, Paolo Bonzini wrote: Il 30/10/2013 08:08, Fam Zheng ha scritto: Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates one HBitmap for each caller, the

[Qemu-devel] [PATCH 3/3] block: per caller dirty bitmap

2013-10-30 Thread Fam Zheng
Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates one HBitmap for each caller, the lifecycle is managed with these new functions: bdrv_create_dirty_bitmap

Re: [Qemu-devel] [PATCH 3/3] block: per caller dirty bitmap

2013-10-30 Thread Fam Zheng
Eric, This touches qapi code, forgot to Cc you. Fam On Wed, 10/30 15:08, Fam Zheng wrote: Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates one HBitmap for each caller,

Re: [Qemu-devel] [PATCH 3/3] block: per caller dirty bitmap

2013-10-30 Thread Paolo Bonzini
Il 30/10/2013 08:08, Fam Zheng ha scritto: Previously a BlockDriverState has only one dirty bitmap, so only one caller (e.g. a block job) can keep track of writing. This changes the dirty bitmap to a list and creates one HBitmap for each caller, the lifecycle is managed with these new